style: use reverse attribute for selected widget states#1154
Draft
ljluestc wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #1133
Selected-state rendering in several widgets is currently implemented by swapping foreground and background colors directly. This can produce inconsistent visuals across themes and terminals, and requires each widget to duplicate style inversion logic.
The issue proposes using reverse video attributes for selected items instead of manually inverting explicit foreground/background pairs.
What changed and how does it work?
This PR updates selected-item styling to use reverse attributes:
tcell.StyleDefault.Reverse(true)(or equivalent style composition preserving existing text attributes).Why this approach?
Check List
Tests
Documentation
Release note
Use reverse video attributes for selected widget items instead of manual foreground/background inversion to improve cross-terminal consistency.