Skip to content

Conversation

@NathanFlurry
Copy link
Member

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 23, 2026

Merge activity

  • Jan 23, 1:43 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Jan 23, 1:44 AM UTC: CI is running for this pull request on a draft pull request (#4017) due to your merge queue CI optimization settings.
  • Jan 23, 1:45 AM UTC: Merged by the Graphite merge queue via draft PR: #4017.

@railway-app
Copy link

railway-app bot commented Jan 23, 2026

🚅 Deployed to the rivet-pr-4016 environment in rivet-frontend

Service Status Web Updated (UTC)
website ❌ Build Failed (View Logs) Web Jan 23, 2026 at 1:44 am
mcp-hub ✅ Success (View Logs) Web Jan 23, 2026 at 1:44 am
frontend-cloud 🕒 Building (View Logs) Web Jan 23, 2026 at 1:44 am
frontend-inspector 🕒 Building (View Logs) Web Jan 23, 2026 at 1:44 am

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4016 January 23, 2026 01:43 Destroyed
Copy link
Member Author


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

graphite-app bot pushed a commit that referenced this pull request Jan 23, 2026
@claude
Copy link

claude bot commented Jan 23, 2026

PR Review

Summary

This PR removes the build-website step from the release script, specifically removing it from:

  1. The main STEPS array (line 292)
  2. The setup-ci phase (line 329)
  3. The main execution flow (lines 605-609)

Analysis

Good Changes:

  • The change successfully prevents duplicate website builds during the release process
  • The PR correctly removes the step from both the STEPS array and the PHASE_MAP

Issues Found:

Critical: Unused Function

The buildWebsite function (lines 209-219) is now completely unused but still exists in the codebase. This creates technical debt.

Recommendation: Remove the unused buildWebsite function entirely (lines 209-219).

Important: runLocalChecks Still Calls buildWebsite

The runLocalChecks function (lines 221-234) still calls buildWebsite(opts) on line 231. This means:

  • The website is still being built during the setup-local phase (line 322)
  • If this was intentional (build locally but not in CI), the PR title/description should clarify this
  • If this was unintentional, line 231 should also be removed

Current behavior after this PR:

  • setup-local phase: Website IS built (via runLocalChecks)
  • setup-ci phase: Website is NOT built
  • Direct calls to build-website step: Removed

Questions for Author

  1. Intent clarification: Should the website build be removed from runLocalChecks as well, or is the intent to build locally but skip in CI?
  2. If keeping website build in runLocalChecks, should we update the comment on line 222 to reflect that website build is still included?

Recommendation

If the goal is to completely eliminate duplicate website builds:

  1. Remove the buildWebsite function (lines 209-219)
  2. Remove the buildWebsite(opts) call from runLocalChecks (line 231)
  3. Update the comment on line 222 to remove "website build" from the description

If the goal is to build website locally but not in CI:

  1. Keep the current changes
  2. Update PR title to clarify: "fix(release): skip website build in CI"
  3. Update the comment on line 315-317 to mention that run-local-checks includes website build

Code Quality

  • No security concerns
  • No performance issues
  • Follows existing code patterns
  • No test coverage issues (this is a build script)

Verdict: Request changes to either remove the unused buildWebsite function or clarify the intent if website builds in runLocalChecks should remain.

@graphite-app graphite-app bot closed this Jan 23, 2026
@graphite-app graphite-app bot deleted the 01-22-fix_release_build_website_only_once branch January 23, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants