-
Notifications
You must be signed in to change notification settings - Fork 146
doc: document version upgrades #3901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚅 Deployed to the rivet-pr-3901 environment in rivet-frontend
|
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: Document Version UpgradesOverviewThis PR adds documentation for Rivet Actor version management and upgrade behavior. The documentation is well-structured and informative. ✅ Strengths
📝 Issues Found1. Incomplete Sentence (Line 41)Severity: Medium This sentence is incomplete. It should clarify what happens to the old actors. Suggested fix: 2. Inconsistent Indentation in Mermaid DiagramsSeverity: Low Lines 32 and 50 use tabs instead of spaces for indentation in the Mermaid diagrams: - R2->>R1: Drain old actors
+ R2->>R1: Drain old actors- Note over R1: Actor 1 sleeps from inactivity
- Note over R2: Actor 1 wakes up when prompted
+ Note over R1: Actor 1 sleeps from inactivity
+ Note over R2: Actor 1 wakes up when promptedWhile Mermaid may render correctly, consistent spacing improves maintainability. 3. Typo: "built time" (Line 81)Severity: Low Should be: 4. Mermaid Diagram AccuracySeverity: Low In the "Drain Disabled" scenario, the diagram shows "Actor 1" sleeping and waking up, but it doesn't clearly show that when Actor 1 wakes up, it's being recreated on the new version. Consider adding a note to clarify: sequenceDiagram
participant R1 as Runner v1
participant R2 as Runner v2
Note over R1: Currently running
Note over R2: Deployed
Note over R1: Actor 1 sleeps from inactivity
Note over R2: Actor 1 wakes up on new version
🔍 Other Observations
✅ Recommendations
SummaryThis is a solid documentation addition that will help users understand version management. The issues found are minor and primarily editorial. Once the sentence is completed and typos are fixed, this will be ready to merge. Overall Assessment: ✅ Approve with minor revisions suggested |
9800079 to
82ade5d
Compare
More templates
@rivetkit/virtual-websocket
@rivetkit/cloudflare-workers
@rivetkit/db
@rivetkit/framework-base
@rivetkit/next-js
@rivetkit/react
rivetkit
@rivetkit/sql-loader
@rivetkit/engine-runner
@rivetkit/engine-runner-protocol
commit: |
Merge activity
|

No description provided.