fix(ts): fix type errors - #329
Conversation
There was a problem hiding this comment.
Code Review
This pull request cleans up trailing whitespaces, adds explicit types to several function parameters (such as changes, close, and progress_handler), and updates module exports to use export default in src/types/index.d.ts. The reviewer suggested introducing a generic type parameter T for userData in progress_handler to improve type safety, along with a minor formatting adjustment.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
059c125 to
374b345
Compare
|
@rhashimoto @shoestringr please take a look |
rhashimoto
left a comment
There was a problem hiding this comment.
Thanks for the PR! I rarely use Typescript and know nothing about Vite, but the changes look fine AFAICT. Just fix one format nitpick and I'll merge.
374b345 to
6e083ef
Compare
Checklist
non-exclusive, royalty-free, irrevocable copyright license to reproduce, prepare
derivative works of, publicly display, sublicense, and distribute this
Contribution and such derivative works.
Contribution contains no content requiring a license from any third party.
Fix TS errors when using PowerSync packages for build via Vite multiple errors