Skip to content

Hotfix project member dao file #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rassokhina-e merged 2 commits into from
Feb 25, 2026
Merged

Hotfix project member dao file #2423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3190264
Hotfix after getting api error notification in project-member-dao.ts …
rassokhina-e Feb 25, 2026
9a89158
Hotfix after getting api error notification in project-member-dao.ts …
rassokhina-e Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/api/src/projects/dao/project-member-dao.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { ModelRepository } from '@rfcx-bio/node-common/dao/model-repository'
import { type LocationProjectUserRole, type UserProfile } from '@rfcx-bio/node-common/dao/types'

import { getSequelize } from '~/db'
import { BioNotFoundError } from '~/errors'
import { fileUrl } from '~/format-helpers/file-url'
import { getProjectById } from './projects-dao'

Expand Down Expand Up @@ -65,7 +66,8 @@ export const update = async (data: { locationProjectId: number, userId: number,
}

export const getUserRoleForProject = async (userId: number | undefined, projectId: number): Promise<ProjectRole> => {
const projectIsPublished = await getProjectById(projectId).then(p => p?.status === 'published' ?? false)
if (projectId === undefined || Number.isNaN(projectId)) { throw BioNotFoundError() }
const projectIsPublished = (await getProjectById(projectId))?.status === 'published'

// When there is no user (no token) and project is not published, no role
// When there is no user and project is published, set as external
Expand Down