fix(complete): complete current and parent directories.#887
Open
MasahikoSawada wants to merge 1 commit intoreubeno:mainfrom
Open
fix(complete): complete current and parent directories.#887MasahikoSawada wants to merge 1 commit intoreubeno:mainfrom
MasahikoSawada wants to merge 1 commit intoreubeno:mainfrom
Conversation
f767818 to
d99396f
Compare
Performance Benchmark Report
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is Test Summary: bash-completion test suite
|
Owner
|
Thanks for posting this, @MasahikoSawada! The change looks reasonable and even seems to increase the pass rate on bash-completion tests 😄 The test failure looks like it's coming from the new assertions you've added to |
Owner
|
Hi @MasahikoSawada -- are you still interested in finishing this up? We appreciate the contribution and it would be great to get this merged. (I'm assuming it primarily needs a rebase and a look at the failing unit tests?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to complete '.' (current directory) and '..' (parent directory) correctly.