Refactor ViaVersion user version getter#1439
Open
booky10 wants to merge 1 commit intoretrooper:2.0from
Open
Conversation
ViaVersion has recently implemented API which allows us to get the UserConnection from their encoder/decoder netty handlers without using reflection (see ViaVersion/ViaVersion@16a2a3a) This implements this api (currently only for spigot as sponge doesn't implement this api yet) and falls back to using reflection if this api isn't available yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ViaVersion has recently implemented API which allows us to get the UserConnection from their encoder/decoder netty handlers without using reflection (see ViaVersion/ViaVersion@16a2a3a, ViaVersion/ViaVersion#3162)
This PR implements this api (currently only for spigot/paper as sponge doesn't implement this api yet) and falls back to using reflection if the api isn't available yet