-
Notifications
You must be signed in to change notification settings - Fork 898
feat(react-email): installation of UI without npm install
#2573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: gabriel miranda <[email protected]> Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
This reverts commit 3924ebd.
🦋 Changeset detectedLatest commit: 55b1594 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
@SocketSecurity ignore npm/[email protected] |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 issues found across 8 files
Prompt for AI agents (all 3 issues)
Understand the root cause of the following 3 issues and fix them.
<file name="packages/react-email/src/utils/get-preview-server-location.ts">
<violation number="1" location="packages/react-email/src/utils/get-preview-server-location.ts:42">
Avoid emitting the success spinner message when installation fails; the finally block currently overrides error cases with a success status.</violation>
<violation number="2" location="packages/react-email/src/utils/get-preview-server-location.ts:78">
The installation logic incorrectly assumes `@react-email/preview-server` only needs `next` as a dependency. By stripping out all other dependencies from `package.json`, it guarantees runtime crashes. The original `packages/preview-server/package.json` lists numerous required dependencies that are now omitted from installation.</violation>
<violation number="3" location="packages/react-email/src/utils/get-preview-server-location.ts:87">
The installation process is opaque and harms developer experience. It uses `execSync` with `stdio: 'ignore'`, which hides `npm` errors from the user. Furthermore, it breaks the monorepo's local development workflow by always fetching from npm, which prevents testing local changes to the preview server.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
Co-authored-by: gabriel miranda <[email protected]> Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@react-email/preview-server; the CLI downloads/packs it into~/.react-emailautomatically.@react-email/preview-serverpublished for backwards compatibility and independent versioning (step toward a singlereact-emailpackage).node_modulesinstead of reinstalling; copiesnode_modules/.binseparately to preserve npm symlinks (verbatimSymlinks).@react-email/preview-serverpath by using@manypkgs/get-packages.My plan is to release this as a canary first, try it out for a week or more and then release it as a stable version.
Summary by cubic
Run the React Email UI without adding @react-email/preview-server to your project. The CLI auto-installs the UI into $HOME/.react-email (or uses the monorepo workspace) and installs its dependencies, keeping setup fast and backward compatible.
Written for commit 55b1594. Summary will update on new commits.