Drop Python 3.8 due to the EOL#303
Merged
JWCook merged 6 commits intorequests-cache:mainfrom Jan 17, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
==========================================
+ Coverage 96.17% 96.20% +0.03%
==========================================
Files 10 10
Lines 1072 1081 +9
Branches 188 188
==========================================
+ Hits 1031 1040 +9
Misses 30 30
Partials 11 11 ☔ View full report in Codecov by Sentry. |
JWCook
approved these changes
Jan 17, 2025
Member
JWCook
left a comment
There was a problem hiding this comment.
Looks good to me, thank you! I'll make a release. I think it should be a minor version bump, though, since we're dropping a python version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the commits.
I think it is a time to publish a new patch release. Maybe you can publish it or I can create a new Pull Request.