Remove supporting of net framework target#17
Conversation
WalkthroughThe pull request updates the project's build infrastructure and framework targeting: the CI workflow switches execution platform from Windows to Linux, the main library removes net462 support retaining only netstandard2.0, and the test project changes target framework from net471/netcoreapp3.1 to net10.0. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@test/ReportPortal.ReqnrollPlugin.Tests/ReportPortal.ReqnrollPlugin.IntegrationTests.csproj`:
- Line 4: The project file sets TargetFrameworks to "net10.0;" (note the
trailing semicolon) and CI must explicitly install the .NET 10 SDK; update the
csproj to remove the trailing semicolon so TargetFrameworks reads "net10.0" and
update your GitHub Actions workflow to add a setup-dotnet step (uses:
actions/setup-dotnet@v5 with dotnet-version: '10.0.x') before any restore/build
steps so the .NET 10 SDK is available in CI.
🧹 Nitpick comments (1)
src/ReportPortal.ReqnrollPlugin/ReportPortal.ReqnrollPlugin.csproj (1)
4-4: LGTM!Dropping
net462and retainingnetstandard2.0is a sensible simplification. Sincenetstandard2.0is compatible with .NET Framework 4.6.1+, existing .NET Framework consumers can still reference this package.Minor nit: the trailing semicolon in
netstandard2.0;is unnecessary when there's only one target framework.Suggested fix
- <TargetFrameworks>netstandard2.0;</TargetFrameworks> + <TargetFramework>netstandard2.0</TargetFramework>
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>net471;netcoreapp3.1;</TargetFrameworks> | ||
| <TargetFrameworks>net10.0;</TargetFrameworks> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check for GitHub Actions workflow files
fd -e yml -e yaml .github/workflows/ 2>/dev/null | head -20Repository: reportportal/agent-dotnet-reqnroll
Length of output: 60
🏁 Script executed:
#!/bin/bash
# Check for setup-dotnet steps in workflows
rg 'setup-dotnet|dotnet-version' .github/workflows/ -A 2 2>/dev/null | head -30Repository: reportportal/agent-dotnet-reqnroll
Length of output: 60
🏁 Script executed:
#!/bin/bash
# Read the full project file to understand context
cat -n test/ReportPortal.ReqnrollPlugin.Tests/ReportPortal.ReqnrollPlugin.IntegrationTests.csproj 2>/dev/null || echo "File not found or path may differ"Repository: reportportal/agent-dotnet-reqnroll
Length of output: 1235
🌐 Web query:
.NET 10 SDK availability GitHub Actions ubuntu-latest runner 2025
💡 Result:
ubuntu-latestin 2025: GitHub began movingubuntu-latestto Ubuntu 24.04 on Dec 5, 2024, and the rollout completed Jan 17, 2025. So “ubuntu-latest(2025)” effectively meansubuntu-24.04. [1]- .NET 10 SDK “availability” on the runner in 2025: .NET 10 became a runner-image update request on Nov 11, 2025 (marked “awaiting-deployment”), which indicates it was not yet reliably present across hosted images at that time. [2] Because preinstalled SDKs can vary and change, you shouldn’t assume .NET 10 exists on
ubuntu-latestduring 2025. [3][4] - Recommended approach (works regardless of what’s preinstalled): explicitly install it in your workflow using
actions/setup-dotnet. [3]
Example:
- uses: actions/setup-dotnet@v5
with:
dotnet-version: '10.0.x'Sources: [1] [2] [3] [4]
Add `.NET 10 SDK setup to CI workflow.
Targeting net10.0 requires explicit SDK installation in CI—the ubuntu-latest runner does not include .NET 10 SDK by default. Add a setup-dotnet step to your workflow:
- uses: actions/setup-dotnet@v5
with:
dotnet-version: '10.0.x'Also, fix the trailing semicolon in TargetFrameworks:
- <TargetFrameworks>net10.0;</TargetFrameworks>
+ <TargetFramework>net10.0</TargetFramework>🤖 Prompt for AI Agents
In
`@test/ReportPortal.ReqnrollPlugin.Tests/ReportPortal.ReqnrollPlugin.IntegrationTests.csproj`
at line 4, The project file sets TargetFrameworks to "net10.0;" (note the
trailing semicolon) and CI must explicitly install the .NET 10 SDK; update the
csproj to remove the trailing semicolon so TargetFrameworks reads "net10.0" and
update your GitHub Actions workflow to add a setup-dotnet step (uses:
actions/setup-dotnet@v5 with dotnet-version: '10.0.x') before any restore/build
steps so the .NET 10 SDK is available in CI.
1 participant
Fixes #8
This pull request updates the build environment and supported target frameworks for both the main plugin and its integration tests, focusing on modernization and simplification.
Build configuration update:
ubuntu-latestinstead ofwindows-latestin.github/workflows/ci.yml, aligning the build environment with modern standards and potentially improving build speed and compatibility.Target framework changes:
net462from theReportPortal.ReqnrollPluginproject, now targeting onlynetstandard2.0for improved cross-platform compatibility and reduced maintenance overhead. (src/ReportPortal.ReqnrollPlugin/ReportPortal.ReqnrollPlugin.csproj)net10.0, dropping support fornet471andnetcoreapp3.1, which streamlines testing and leverages the latest .NET features. (test/ReportPortal.ReqnrollPlugin.Tests/ReportPortal.ReqnrollPlugin.IntegrationTests.csproj)Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.