fix: give the modal card and header icon buttons accessible names - #5763
Open
devtechedge wants to merge 3 commits into
Open
devtechedge wants to merge 3 commits into
devtechedge wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 0ef28f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@devtechedge is attempting to deploy a commit to the Reown Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
All contributors have signed the CTA ✍️ ✅ |
Author
|
I have read the CTA Document and I hereby sign the CTA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The modal card (
wui-card,role="alertdialog") had no accessible name, and the header's icon-only buttons could not be given one becausewui-icon-buttonnever forwarded a label to its inner<button>. A screen reader announced the modal as an unnamed dialog and the close/help controls as a bare "button".wui-icon-buttongains an optionallabelproperty, rendered asaria-labelon the inner button and omitted when unset.w3m-headerlabels Close, Help, Back, and Smart Sessions — the fourwui-icon-buttoncall sites in scaffold-ui.w3m-modalsetsaria-labelon the card from the current view heading.aria-labelledbycannot cross the shadow boundary intow3m-header, so the heading map is exported and the modal computes the same string on view change. Views with no heading (Account, Account Settings) fall back to a spaced view name.Connect Wallet). HTML collapsed it visually; it would have become the card's literal name.Type of change
Associated Issues
closes #5761
Showcase (Optional)
No visual change.
button -> button "Help"
button -> button "Close"
alertdialog (no name) -> alertdialog "Connect Wallet"
Checklist