Modernize for Python 3.11+, pandas 3.0, numpy 2.x, pvlib 0.15#19
Open
MaykThewessen wants to merge 1 commit intorenewables-ninja:mainfrom
Open
Modernize for Python 3.11+, pandas 3.0, numpy 2.x, pvlib 0.15#19MaykThewessen wants to merge 1 commit intorenewables-ninja:mainfrom
MaykThewessen wants to merge 1 commit intorenewables-ninja:mainfrom
Conversation
Addresses issues renewables-ninja#18, renewables-ninja#12, renewables-ninja#11 (pandas deprecations), renewables-ninja#9 (azimuth docs), and renewables-ninja#14 (installation on modern Python). Changes: - Fix fillna(inplace=True) deprecated in pandas 3.0 - Fix .date() indexing in legacy sun_angles for pandas compat - Fix freq alias "1H" -> "1h" (pandas 3.0 requires lowercase) - Fix tz-aware/naive mismatch in _daily_dtindex and sun_rise_set_times - Update deps: pandas>=2.0, pvlib>=0.11, numpy>=2.0, ephem>=4.2 - Set requires-python>=3.11, update black target versions - Clarify azimuth docstrings (180=South, auto-corrected for S. hemisphere) - Fix 2-axis tracking panel_tilt to derive from sun_alt (from PR renewables-ninja#10) - Fix wind speed unit typo (m/2 -> m/s) and docstring param name - Remove stale FIXME, commented-out code, unnecessary super().__init__() - Use f-strings and modern class syntax All 19 existing tests pass on Python 3.14, pandas 3.0.1, numpy 2.4.3, pvlib 0.15.0, ephem 4.2.1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fillna(inplace=True),.date()indexing, uppercase freq aliases"1H"→"1h")ephem==4.1.3won't build on Python 3.11+; updated toephem>=4.2panel_tiltderived fromsun_altfor consistencypandas>=2.0,pvlib>=0.11,numpy>=2.0,requires-python>=3.11super().__init__(), fixed typos (m/2→m/s), modern class syntaxTest plan
🤖 Generated with Claude Code