Merged
Conversation
Test Results 16 files 36 suites 0s ⏱️ Results for commit 31f3e56. ♻️ This comment has been updated with latest results. |
Fix issues with recent Verilator versions. - The --sv-padding option is removed. It is now always on, as this behaviour is technically required by the SystemVerilog spec and Verilator now enforces this. - Verilator is now stricter about hextoa, bintoa, and itoa. Use $sformatf directly. Add a regression test for 1555
Alasdair
force-pushed
the
fixes_verilator
branch
from
fa51d3d to
31f3e56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue where --c-no-mangle could cause name clashes
Fix issues with recent Verilator versions.
The --sv-padding option is removed. It is now always on, as this behaviour is technically required by the SystemVerilog spec and Verilator now enforces this.
Verilator is now stricter about hextoa, bintoa, and itoa. Use $sformatf directly.
Add a regression test for 1555