Change how the Rocq IdMap type is implemented#1634
Merged
Conversation
Test Results 16 files 36 suites 0s ⏱️ Results for commit 820860d. ♻️ This comment has been updated with latest results. |
Collaborator
Author
|
Hmm, I changed the extracted code to work as |
Alasdair
force-pushed
the
rocq-newmap
branch
2 times, most recently
from
6365917 to
7c45bea
Compare
This commit message does not entirely suggest just how much of an endevour this actually was. Mostly this commit just repairs the state of things before the IdMap change, but actually doing so required some fairly signficant proof effort (at least for a Rocq novice like myself). Still needs some significant cleanup before merging.
Some additional cleanup and reorganisation.
Previously we created a hacky ocamlbuild project, but ocamlbuild is long defunct at this point, and copying the require files was becoming painful. Now we create a clean dune project that just requires Libsail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit message does not entirely suggest just how much of an endevour this actually was. Mostly this commit just repairs the state of things before the IdMap change, but actually doing so required some fairly signficant proof effort (at least for a Rocq novice like myself).
Still needs some significant cleanup before merging.