[#2464] Fix picocli-codegen module-info missing provides for annotation processor - #2528
Open
arimu1 wants to merge 1 commit into
Open
[#2464] Fix picocli-codegen module-info missing provides for annotation processor#2528arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
…notation processor Register NativeImageConfigGeneratorProcessor via provides ... with so the processor is discovered when picocli-codegen is on --processor-module-path. META-INF/services remains the classpath discovery mechanism.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
picocli-codegen's JPMSmodule-infodid not declare aprovides … withfor its annotation processor. When the jar is used on--processor-module-path, the Java module system only discovers processors listed viaprovides, soNativeImageConfigGeneratorProcessorwas never loaded. Classpath discovery viaMETA-INF/servicescontinued to work.This change adds the matching
providesclause for the single processor registered inMETA-INF/services/javax.annotation.processing.Processor.Fixes #2464
Changes
picocli-codegen/src/main/java9/module-info.java: providejavax.annotation.processing.Processorwithpicocli.codegen.aot.graalvm.processor.NativeImageConfigGeneratorProcessorIssue2464Test: assert the module descriptor declares thatprovidesentry (covers jar and exploded multi-release build layouts)Verification
Processorentry exists underMETA-INF/servicespicocli-codegenjar and inspectedMETA-INF/versions/9/module-info.class(providespresent)./gradlew :picocli-codegen-tests-java9plus:test --tests picocli.annotation.processing.tests.Issue2464Test(JDK 17)