Skip to content

Conversation

@yoni-noma
Copy link

@yoni-noma yoni-noma commented Jan 30, 2026

Description

Fixes a navigation crash caused by aborted single-fetch data requests (fetchers and navigations). Some browsers throw a TypeError before the abort signal is marked, so we normalize aborts and only use a TypeError-message fallback for that race.

Changes

  • Normalize fetch aborts in fetchAndDecodeViaTurboStream and treat abort results as empty data
  • Add integration coverage for navigation during active fetcher polling
  • TypeError-only fallback for the abort race (signal/AbortError checks preferred)

Impact

Prevents abort-related errors (TypeError: Failed to Fetch, Load Failed, etc.) from reaching the error boundary during navigation while keeping non-abort failures intact.

Related: #14203

Test plan

  • not run (tests can be long; run in CI/local as needed)

Normalize fetch aborts and ignore abort results during data strategy.
Add integration coverage for navigation during fetcher polling.
@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2026

🦋 Changeset detected

Latest commit: 0fc8dba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 30, 2026

Hi @yoni-noma,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

Add changeset for abort handling fix and sign CLA.
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 30, 2026

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Prefer signal reason and AbortError types; only fall back to message
matching for fetch TypeError cases.
Note TypeError message matching is a browser fallback only.
@yoni-noma
Copy link
Author

Added a short note in code: we prefer abort signal/AbortError checks and only fall back to TypeError message matching to handle browser abort race cases. The fallback is intentionally narrow (TypeError-only) to minimize false positives. Should improve behavior for Chrome/Safari/Firefox where aborted fetches sometimes surface as TypeError.

Extract internal isAbortError helper to avoid duplication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants