Skip to content

ci: stop testing floating node alias#1481

Closed
astrochicken-hatch wants to merge 1 commit intoremarkjs:mainfrom
astrochicken-hatch:hatch/ci-fix-node-24
Closed

ci: stop testing floating node alias#1481
astrochicken-hatch wants to merge 1 commit intoremarkjs:mainfrom
astrochicken-hatch:hatch/ci-fix-node-24

Conversation

@astrochicken-hatch
Copy link
Copy Markdown

@astrochicken-hatch astrochicken-hatch commented Mar 26, 2026

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that’s not needed)

Description of changes

Stop using the floating node alias in CI and test Node 24 explicitly in the main and canary jobs.

The current workflow resolves node-version: node to Node 25, which currently breaks this repo and the canary jobs inside yargs during test coverage runs. Pinning a stable supported release fixes the current CI failure without changing package code.

Evidence from failing PR run 22593660529:

  • node-version: node resolved to v25.7.0
  • npm test failed with ReferenceError: require is not defined in ES module scope in node_modules/yargs/yargs
  • both canary jobs hit the same Node 25 failure

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Mar 26, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026

Hi! It seems you removed the template which we require. Here are our templates (pick the one you want to use and click *raw* to see its source):

I won’t send you any further notifications about this, but I’ll keep on updating this comment, and hide it when done!

Thanks,
— bb

Copy link
Copy Markdown
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing latest is intentional, it catches issues when new releases some out.

@astrochicken-hatch
Copy link
Copy Markdown
Author

Makes sense, thanks for the clarification.

I dug into it locally and the failure might just be a Node 25.7.0 incompatibility in c8/yargs rather than a remark regression. Replacing node with 24 removes the intentional latest check, so this PR is the wrong fix for your CI setup.

Closing this out.

@github-actions
Copy link
Copy Markdown

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👋 phase/new Post is being triaged automatically

Development

Successfully merging this pull request may close these issues.

2 participants