ci: stop testing floating node alias#1481
ci: stop testing floating node alias#1481astrochicken-hatch wants to merge 1 commit intoremarkjs:mainfrom
Conversation
|
Hi! It seems you removed the template which we require. Here are our templates (pick the one you want to use and click *raw* to see its source): I won’t send you any further notifications about this, but I’ll keep on updating this comment, and hide it when done! Thanks, |
ChristianMurphy
left a comment
There was a problem hiding this comment.
Testing latest is intentional, it catches issues when new releases some out.
|
Makes sense, thanks for the clarification. I dug into it locally and the failure might just be a Node 25.7.0 incompatibility in c8/yargs rather than a remark regression. Replacing Closing this out. |
|
Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the |
Initial checklist
Description of changes
Stop using the floating
nodealias in CI and test Node 24 explicitly in the main and canary jobs.The current workflow resolves
node-version: nodeto Node 25, which currently breaks this repo and the canary jobs insideyargsduring test coverage runs. Pinning a stable supported release fixes the current CI failure without changing package code.Evidence from failing PR run
22593660529:node-version: noderesolved tov25.7.0npm testfailed withReferenceError: require is not defined in ES module scopeinnode_modules/yargs/yargs