-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add support for Ruby 3.x -> 4.0, Rails 6.1 -> 8.1 #3518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Ruby 3.1.2
core: TranslationHelper, SiteBarHelper - using Ruby3 keyword args
lib/refinery/engine uses new mobility configuration
images, resources: Updated examples to pass an explicit block to 'expect' as passing an implicit block is deprecated.
images: Use errors.add to add errors to an object - had already been done for resources.
Gem versions changed:
mobility 1.2.9
rspec-rails 6.0.0.rc1
friendly_id >= 5.4.0
friendly_id-mobility ~> 1.0.3
…ms-i18n in Gemfile'
Tests failing:I have seen some of these errors during testing, but thought I was past them. Many seem to be timeouts, and then the reporting of timeouts seems to be a problem too. There are many variations of: and I saw some other reporting of timeouts on Also frequently seen (below), which seems to be an error reporting timeouts. It occurs every minute during a run. |
…e and Directory matchers.
Tidy up configuration block for Mobility 1.2.9 Revert some changes for single argument keyword args Add descriptions for Generator spec matchers (thereby avoiding a very long message when there are no descriptions).
|
Thank you for looking at this |
|
Is there any update on the status of this PR? I need to upgrade to ruby 3.2.1 and rails 6.x because I need to upgrade to the newest cflinux4 buildpack and no previous versions of ruby are supported. I currently use refinerycms with ruby 2.5.5 and rails 5.x. I think this merge will help me upgrade to the versions of ruby and rails mentioned above. Thank you. |
|
@pdornfel I'd really love to merge this but CI isn't happy. The corresponding PR for refinerycms-i18n is failing on Ruby 3.0 and 3.2, but not 3.1 🤔 refinery/refinerycms-i18n#104 Any help you or anyone else can lend with figuring out why this is happening would be greatly appreciated. Right now, I suspect the routing-filter gem we use. |
Merge refinery fixes
…isting file spec/support/capybara.rb. remove requirement for 'webdrivers/chromedriver' as this is all handled by Selenium consistent errors in Selenium chrome webdriver, temporarily switched to firefox.
…to target the part of the url which should change.
…was failing in Refinery::Admin tests, so now using Refinery::Pages(*)
…e options hash, as options[:original_options]
return ImageObjects from Refinery::Admin::ImagesController#index action unify code for grid_view and list_view into _image.html.erb add view_objects directory to engine autoload_path
change 0px to unitless 0.
…ated "process.convert"
99870b2 to
07c19b4
Compare
Try to support the older versions
9b2ce58 to
6077c43
Compare
|
Thanks so much for all your hard work on this, it's been extremely helpful. |
parndt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing that we got here.
Updates refinerycms-i18n to Ruby 3, to match refinery/refinerycms#3518. Using Mobility 1.3.x Apart from that most changes are extremely minor.
This PR and its matching PR refinery/refinerycms-i18n#104 allow
refinerycmsto run with Ruby 3 / Ruby 4.It has been tested with Ruby 3.2 through 4.0, and with Rails 6.1 through 8.1.
We've removed
coffee-railsas a dependency and converted those to JS.