aws_s3: Don't set ACL by default since ACLs are disabled by default in S3#4372
Open
ttreptow wants to merge 1 commit intoredpanda-data:mainfrom
Open
aws_s3: Don't set ACL by default since ACLs are disabled by default in S3#4372ttreptow wants to merge 1 commit intoredpanda-data:mainfrom
ttreptow wants to merge 1 commit intoredpanda-data:mainfrom
Conversation
…or buckets created since 2023 Setting an ACL throws an error when uploading to a bucket with ACLs disabled when the bucket is in another account. The former default 'private' is accepted by buckets in the same account but is a no-op
ttreptow
changed the title
ttreptow
force-pushed
the
remove-default-acl
branch
from
2569317 to
a75c1cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting an ACL throws an error when uploading to a bucket with ACLs disabled (default since 2023) when the bucket is in another account. The former default 'private' is accepted by buckets in the same account but is a no-op.
This change should not affect cases where users are writing to a bucket with ACLs enabled, since the default ACL applied by AWS is 'private', which matches the expected behavior when
object_canned_aclis not specified. If a user is writing to a bucket with ACLs enabled and is specifying a different canned ACL, that will continue to work with this change.Fixes #4371