mssqlserver: guard Connect against concurrent calls#4288
Open
mssqlserver: guard Connect against concurrent calls#4288
Conversation
The benthos framework can call Connect() concurrently or re-enter it before the background goroutine has stopped. Without a guard, two goroutines share the same publisher and checkpoint tracker, corrupting state and causing the streaming phase to hang indefinitely. Add a mutex and a HasStoppedChan check so that a second Connect() is a no-op while the previous goroutine is still running. Fixes CON-389
|
Commits Review LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benthos framework can call Connect() concurrently or re-enter it
before the background goroutine has stopped. Without a guard, two
goroutines share the same publisher and checkpoint tracker, corrupting
state and causing the streaming phase to hang indefinitely.
Add a mutex and a HasStoppedChan check so that a second Connect() is
a no-op while the previous goroutine is still running.
Fixes CON-389