Skip to content

oracledb: handle LOB_TRIM events to establish LOB locator state #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmatczuk wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −4
Open

oracledb: handle LOB_TRIM events to establish LOB locator state #4285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions internal/impl/oracledb/logminer/logminer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func NewMiner(db *sql.DB, userTables []replication.UserTable, publisher replicat
if len(userTables) > 0 {
opCodes := "6, 7, 36"
if cfg.LOBEnabled {
opCodes += ", 9, 10"
opCodes += ", 9, 10, 11"
}
buf.WriteString(" AND (OPERATION_CODE IN (" + opCodes + ")")
// DML carries the real table name — filter by configured tables.
Expand Down Expand Up @@ -274,17 +274,19 @@ func (lm *LogMiner) processRedoEvent(ctx context.Context, redoEvent *sqlredo.Red

lm.txnCache.AddEvent(redoEvent.TransactionID, redoEvent.SCN, &event)

case sqlredo.OpSelectLobLocator:
case sqlredo.OpSelectLobLocator, sqlredo.OpLobTrim:
if !lm.cfg.LOBEnabled {
return nil
}
if !redoEvent.SQLRedo.Valid || redoEvent.SQLRedo.String == "" {
lm.log.Warnf("Skipping SELECT_LOB_LOCATOR with no SQL_REDO (scn=%d, txn=%s)", redoEvent.SCN, redoEvent.TransactionID)
lm.log.Warnf("Skipping %s with no SQL_REDO (scn=%d, txn=%s)", redoEvent.Operation, redoEvent.SCN, redoEvent.TransactionID)
return nil
}
// LOB_TRIM SQL has the same SELECT "COL" INTO ... FROM "SCHEMA"."TABLE" WHERE ...
// structure as SELECT_LOB_LOCATOR, so the same parser works for both.
info, err := sqlredo.ParseSelectLobLocator(redoEvent.SQLRedo.String)
if err != nil {
lm.log.Warnf("Failed to parse SELECT_LOB_LOCATOR SQL (scn=%d, txn=%s): %v\nSQL: %.500s", redoEvent.SCN, redoEvent.TransactionID, err, redoEvent.SQLRedo.String)
lm.log.Warnf("Failed to parse %s SQL (scn=%d, txn=%s): %v\nSQL: %.500s", redoEvent.Operation, redoEvent.SCN, redoEvent.TransactionID, err, redoEvent.SQLRedo.String)
return nil
}
// Resolve LOB type from the schema cache populated at startup.
Expand Down
6 changes: 6 additions & 0 deletions internal/impl/oracledb/logminer/sqlredo/events.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ const (
OpSelectLobLocator Operation = 9
// OpLobWrite represents a LOB_WRITE operation (op 10)
OpLobWrite Operation = 10
// OpLobTrim represents a LOB_TRIM operation (op 11)
OpLobTrim Operation = 11
)

// String converts the operation type to a string equivalent.
Expand All @@ -59,6 +61,8 @@ func (op Operation) String() string {
return "select_lob_locator"
case OpLobWrite:
return "lob_write"
case OpLobTrim:
return "lob_trim"
default:
return fmt.Sprintf("unknown operation (%d)", int64(op))
}
Expand Down Expand Up @@ -104,6 +108,8 @@ func operationFromCode(code int64) Operation {
return OpSelectLobLocator
case 10:
return OpLobWrite
case 11:
return OpLobTrim
default:
return OpUnknown
}
Expand Down
Loading