mongodb: fix data race on ChangeStream between TryNext and ResumeToken#4271
Open
mongodb: fix data race on ChangeStream between TryNext and ResumeToken#4271
Conversation
The ack callback called stream.ResumeToken() from a different goroutine than the one running stream.TryNext(), racing on the ChangeStream's internal resume token field. Use the value already resolved by the checkpoint system instead, which is both race-free and semantically correct. Fixes CON-418
|
Commits Review LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ack callback called stream.ResumeToken() from a different goroutine
than the one running stream.TryNext(), racing on the ChangeStream's
internal resume token field. Use the value already resolved by the
checkpoint system instead, which is both race-free and semantically
correct.
Fixes CON-418