remove remaining imports of typing_extensions#3873
Open
dotlambda wants to merge 2 commits intoredis:masterfrom
Open
remove remaining imports of typing_extensions#3873dotlambda wants to merge 2 commits intoredis:masterfrom
dotlambda wants to merge 2 commits intoredis:masterfrom
Conversation
Collaborator
|
Hi @dotlambda, thank you for your contribution! We will review your change soon. |
petyaslavova
requested changes
Dec 10, 2025
| from typing_extensions import Optional | ||
|
|
||
| try: | ||
| from typing import Optional # Py 3.11+ |
Collaborator
There was a problem hiding this comment.
You can directly import it from typing and completely remove the typing_extensions import. The typing.Optional is available in our min supported version, which is 3.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
It's not a dependency anymore:
redis-py/pyproject.toml
Line 31 in fb30954
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.