Skip to content

Resolve LINQ expression translation for ==/!= null #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slorello89 merged 3 commits into from
Jun 26, 2025
Merged

Resolve LINQ expression translation for ==/!= null #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3059154
Fixes an issue with Linq expression translation where negation of the…
mfaulcon-mynexus Jun 18, 2025
e323718
rolling back some formatting changes, adding a test
slorello89 Jun 26, 2025
3ec7fd0
small formatting reversions
slorello89 Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Redis.OM/Common/ExpressionParserUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,6 +1038,11 @@ private static string TranslateAnyForEmbeddedObjects(MethodCallExpression exp, L

private static string ValueToString(object value)
{
if (value is null)
{
return "null";
}

Type valueType = value.GetType();

if (valueType == typeof(double) || Nullable.GetUnderlyingType(valueType) == typeof(double))
Expand Down
7 changes: 6 additions & 1 deletion src/Redis.OM/Common/ExpressionTranslator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,12 @@ internal static string TranslateBinaryExpression(BinaryExpression binExpression,
if (rightResolvesToNull)
{
dialectNeeded |= 1 << 1;
return $"(ismissing({leftContent}))";
return binExpression.NodeType switch
{
ExpressionType.Equal => $"(ismissing({leftContent}))",
ExpressionType.NotEqual => $"-(ismissing({leftContent}))",
_ => throw new ArgumentException($"The expression node type {binExpression.NodeType} is not supported"),
};
}

var rightContent = ExpressionParserUtilities.GetOperandStringForQueryArgs(binExpression.Right, parameters, ref dialectNeeded, treatBooleanMemberAsUnary: true);
Expand Down
17 changes: 17 additions & 0 deletions test/Redis.OM.Unit.Tests/RediSearchTests/SearchTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4156,5 +4156,22 @@ await _substitute.Received().ExecuteAsync("FT.SEARCH",
"0",
"100");
}

[Fact]
public async Task TestIsNotNull()
{
_substitute.ClearSubstitute();
_substitute.ExecuteAsync(Arg.Any<string>(), Arg.Any<object[]>()).Returns(_mockReply);
var collection = new RedisCollection<ObjectWithNullableStrings>(_substitute);
await collection.Where(x => x.String1 != null).ToListAsync();
await _substitute.Received().ExecuteAsync("FT.SEARCH",
$"{nameof(ObjectWithNullableStrings).ToLower()}-idx",
"-(ismissing(@String1))",
"DIALECT",
2,
"LIMIT",
"0",
"100");
}
}
}