docs: fix enterprise maintenance comment typo#3255
Open
Rohan5commit wants to merge 1 commit intoredis:masterfrom
Open
docs: fix enterprise maintenance comment typo#3255Rohan5commit wants to merge 1 commit intoredis:masterfrom
Rohan5commit wants to merge 1 commit intoredis:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a minor typo in an inline comment within the enterprise maintenance manager to improve readability without changing behavior.
Changes:
- Corrects
doesnttodoesn'tin a source comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| #onMigrated = () => { | ||
| //ensure that #isMaintenance doesnt go under 0 | ||
| //ensure that #isMaintenance doesn't go under 0 |
There was a problem hiding this comment.
Comment formatting is inconsistent with nearby comments in this file (most use // with a space). Since you touched this line, consider updating it to // Ensure that #isMaintenance doesn't go under 0 for consistency/readability.
Suggested change
| //ensure that #isMaintenance doesn't go under 0 | |
| // Ensure that #isMaintenance doesn't go under 0 |
Collaborator
|
Hi @Rohan5commit, thanks for the PR! I see you are making a lot of very small grammar oriented PRs. Can you please try to consolidate them into one single PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
doesntin the enterprise maintenance manager commentChecklist
npm testpass with this change (including linting)?Tests not run; this is a comment-only source fix.