DEV: update TS cmds etc. with NaN support #2650
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
andy-stark-redis
left a comment
andy-stark-redis
left a comment
There was a problem hiding this comment.
One tiny (ignorable) suggestion, but otherwise LGTM.
Co-authored-by: andy-stark-redis <[email protected]>
| - clients | ||
| complexity: O(1) | ||
| description: Create a compaction rule | ||
| description: Create a compaction rule. Starting from Redis 8.6, aggregation functions ignore NaN values when computing compacted results. |
There was a problem hiding this comment.
I suggest removing this addition.
It sounds like a breaking change.
Previously, NaN values were not possible, so I'm not sure if "Starting from Redis 8.6" is needed.
Also, the two new aggregators don't ignore Nan values.
In the table below, you can remove the "since Redis 8.6" for the same reason.
There was a problem hiding this comment.
It's really not clear to me if you want "...since Redis 8.6..." removed from all tables or just the one below.
| <details open><summary><code>subtrahend</code></summary> | ||
|
|
||
| is numeric value of the subtrahend (double). | ||
| is numeric value of the subtrahend (double). Starting from Redis 8.6, an error is returned if the subtrahend is NaN. |
There was a problem hiding this comment.
An error was returned before as well, simply because Nan was not supported.
No description provided.