Java 11 upgrade by carlosmunoz · Pull Request #448 · redhataccess/pantheon

carlosmunoz · 2020-10-23T20:32:40Z

No description provided.

codecov-io · 2020-10-23T20:38:25Z

Codecov Report

Merging #448 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #448      +/-   ##
============================================
- Coverage     58.97%   58.95%   -0.02%     
  Complexity      492      492              
============================================
  Files           125      125              
  Lines          3963     3964       +1     
  Branches        544      544              
============================================
  Hits           2337     2337              
- Misses         1513     1514       +1     
  Partials        113      113

Flag	Coverage Δ	Complexity Δ
#java	`58.95% <ø> (-0.02%)`	`492.00 <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
.../redhat/pantheon/servlet/ModuleListingServlet.java	`68.75% <ø> (ø)`	`14.00 <0.00> (ø)`
...heon/servlet/assembly/AssemblyIncludesServlet.java	`84.78% <0.00%> (-0.33%)`	`4.00% <0.00%> (ø%)`
...heon/servlet/DocumentCustomerPortalUrlServlet.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`
...n/asciidoctor/extension/PantheonXrefProcessor.java	`93.54% <0.00%> (ø)`	`11.00% <0.00%> (ø%)`
...at/pantheon/servlet/module/RawAsciidocServlet.java	`90.00% <0.00%> (+0.52%)`	`4.00% <0.00%> (ø%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80675c4...501f097. Read the comment docs.

This revision was also tested against a java 11 version of a GraalVM

xdavidson

8 days ago, Red Hat released openjdk11 on the ubi8 base image!
https://catalog.redhat.com/software/containers/ubi8/openjdk-11/5dd6a4b45a13461646f677f4

carlosmunoz · 2020-11-12T15:11:32Z

@xdavidson this is good news. If we want to move forward with this upgrade, we will need to update our deployment images.

aprajshekhar · 2020-11-19T09:56:12Z

@carlosmunoz I tried building and deploying this branch locally with OpenJDK 11. Build succeeds. However, I am getting the following exception when Karaf starts up -

org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : An exception occurred processing Appender PaxOsgi Ignored FQCN: org.apache.logging.log4j.spi.AbstractLogger
java.lang.NullPointerException
        at org.apache.logging.log4j.util.StackLocator9.calcLocation(StackLocator9.java:80)
        at org.apache.logging.log4j.util.StackLocatorUtil.calcLocation(StackLocatorUtil.java:94)
        at org.apache.logging.log4j.core.impl.Log4jLogEvent.getSource(Log4jLogEvent.java:693)
        at org.ops4j.pax.logging.log4j2.internal.spi.PaxLoggingEventImpl.getLocationInformation(PaxLoggingEventImpl.java:47)
        at org.ops4j.pax.logging.spi.support.PaxAppenderProxy.doAppend(PaxAppenderProxy.java:67)
        at org.ops4j.pax.logging.log4j2.internal.bridges.PaxOsgiAppender.append(PaxOsgiAppender.java:100)
        at org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:156)
        at org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:129)
        at org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:120)
        at org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:84)
        at org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:543)
        at org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:502)
        at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:485)
        at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:412)
        at org.apache.logging.log4j.core.config.AwaitCompletionReliabilityStrategy.log(AwaitCompletionReliabilityStrategy.java:63)
        at org.apache.logging.log4j.core.Logger.logMessage(Logger.java:153)
        at org.ops4j.pax.logging.log4j2.internal.PaxLoggerImpl.doLog0(PaxLoggerImpl.java:356)
        at org.ops4j.pax.logging.log4j2.internal.PaxLoggerImpl.doLog(PaxLoggerImpl.java:338)
        at org.ops4j.pax.logging.log4j2.internal.PaxLoggerImpl.error(PaxLoggerImpl.java:164)
        at org.ops4j.pax.logging.internal.TrackingLogger.error(TrackingLogger.java:130)
        at org.ops4j.pax.logging.spi.support.FrameworkHandler.doLog(FrameworkHandler.java:187)
        at org.ops4j.pax.logging.spi.support.FrameworkHandler.frameworkEvent(FrameworkHandler.java:149)
        at org.apache.felix.framework.EventDispatcher.invokeFrameworkListenerCallback(EventDispatcher.java:881)
        at org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:830)
        at org.apache.felix.framework.EventDispatcher.run(EventDispatcher.java:1147)
        at org.apache.felix.framework.EventDispatcher.access$000(EventDispatcher.java:54)
        at org.apache.felix.framework.EventDispatcher$1.run(EventDispatcher.java:102)
        at java.base/java.lang.Thread.run(Thread.java:834)

Is it happening at your end as well?

aprajshekhar · 2020-11-19T09:58:49Z

8 days ago, Red Hat released openjdk11 on the ubi8 base image!
https://catalog.redhat.com/software/containers/ubi8/openjdk-11/5dd6a4b45a13461646f677f4

This is great. I was a bit concerned about JDK-11 not being available for ubi8.

aprajshekhar

Apart from the exception mentioned earlier, all the functionality seems to be working as expected based on the smoke testing I did.

carlosmunoz · 2020-11-19T12:12:10Z

@carlosmunoz I tried building and deploying this branch locally with OpenJDK 11. Build succeeds. However, I am getting the following exception when Karaf starts up -

org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : An exception occurred processing Appender PaxOsgi Ignored FQCN: org.apache.logging.log4j.spi.AbstractLogger
java.lang.NullPointerException
        at org.apache.logging.log4j.util.StackLocator9.calcLocation(StackLocator9.java:80)
        at org.apache.logging.log4j.util.StackLocatorUtil.calcLocation(StackLocatorUtil.java:94)
        at org.apache.logging.log4j.core.impl.Log4jLogEvent.getSource(Log4jLogEvent.java:693)
        at org.ops4j.pax.logging.log4j2.internal.spi.PaxLoggingEventImpl.getLocationInformation(PaxLoggingEventImpl.java:47)
        at org.ops4j.pax.logging.spi.support.PaxAppenderProxy.doAppend(PaxAppenderProxy.java:67)
        at org.ops4j.pax.logging.log4j2.internal.bridges.PaxOsgiAppender.append(PaxOsgiAppender.java:100)
        at org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:156)
        at org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:129)
        at org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:120)
        at org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:84)
        at org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:543)
        at org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:502)
        at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:485)
        at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:412)
        at org.apache.logging.log4j.core.config.AwaitCompletionReliabilityStrategy.log(AwaitCompletionReliabilityStrategy.java:63)
        at org.apache.logging.log4j.core.Logger.logMessage(Logger.java:153)
        at org.ops4j.pax.logging.log4j2.internal.PaxLoggerImpl.doLog0(PaxLoggerImpl.java:356)
        at org.ops4j.pax.logging.log4j2.internal.PaxLoggerImpl.doLog(PaxLoggerImpl.java:338)
        at org.ops4j.pax.logging.log4j2.internal.PaxLoggerImpl.error(PaxLoggerImpl.java:164)
        at org.ops4j.pax.logging.internal.TrackingLogger.error(TrackingLogger.java:130)
        at org.ops4j.pax.logging.spi.support.FrameworkHandler.doLog(FrameworkHandler.java:187)
        at org.ops4j.pax.logging.spi.support.FrameworkHandler.frameworkEvent(FrameworkHandler.java:149)
        at org.apache.felix.framework.EventDispatcher.invokeFrameworkListenerCallback(EventDispatcher.java:881)
        at org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:830)
        at org.apache.felix.framework.EventDispatcher.run(EventDispatcher.java:1147)
        at org.apache.felix.framework.EventDispatcher.access$000(EventDispatcher.java:54)
        at org.apache.felix.framework.EventDispatcher$1.run(EventDispatcher.java:102)
        at java.base/java.lang.Thread.run(Thread.java:834)

Is it happening at your end as well?

@aprajshekhar I am not seeing this error

aprajshekhar

As I have not seen the error again and the smoke test was successful, let's go ahead with the changes.

carlosmunoz · 2020-11-30T15:09:38Z

As I have not seen the error again and the smoke test was successful, let's go ahead with the changes.

This will need a coordinated release with the pipelines, and changes in local dev environments. I will merge when/if given the go-ahead. (We also need to change Github's validations)

aprajshekhar · 2020-11-30T15:28:44Z

As I have not seen the error again and the smoke test was successful, let's go ahead with the changes.

This will need a coordinated release with the pipelines, and changes in local dev environments. I will merge when/if given the go-ahead. (We also need to change Github's validations)

I agree. What I meant to say was this PR would not need any more Java 11 related changes except github actions 👍

The Module class needs to be explicitly imported since there is now a Module class as part of the java.lang package.

codecov-commenter · 2026-04-01T11:18:38Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.82%. Comparing base (d7b40fa) to head (484ccb6).
⚠️ Report is 138 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #448      +/-   ##
============================================
- Coverage     57.83%   57.82%   -0.02%     
  Complexity      498      498              
============================================
  Files           129      129              
  Lines          4172     4173       +1     
  Branches        598      598              
============================================
  Hits           2413     2413              
- Misses         1642     1643       +1     
  Partials        117      117

Flag	Coverage Δ
java	`57.82% <ø> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Carlos Munoz added 2 commits October 23, 2020 16:25

add explicit import for class which clashes with a new JDK class

b7721d0

upgrade the java version on the github maven action

501f097

carlosmunoz added the not ready Not ready to be reviewed or merged label Oct 23, 2020

modify maven build settings to compile java 11 sources

35ae13d

This revision was also tested against a java 11 version of a GraalVM

carlosmunoz requested review from aprajshekhar and xdavidson November 10, 2020 20:02

xdavidson reviewed Nov 12, 2020

View reviewed changes

aprajshekhar reviewed Nov 19, 2020

View reviewed changes

aprajshekhar previously approved these changes Nov 27, 2020

View reviewed changes

Carlos Munoz added 2 commits December 15, 2020 10:04

Merge branch 'master' into java_11_upgrade

8c99b96

rebase against master

484ccb6

The Module class needs to be explicitly imported since there is now a Module class as part of the java.lang package.

carlosmunoz dismissed aprajshekhar’s stale review via 8c99b96 December 15, 2020 15:04

carlosmunoz removed the not ready Not ready to be reviewed or merged label Dec 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Java 11 upgrade#448

Java 11 upgrade#448
carlosmunoz wants to merge 5 commits intoredhataccess:masterfrom
carlosmunoz:java_11_upgrade

carlosmunoz commented Oct 23, 2020

Uh oh!

codecov-io commented Oct 23, 2020

Uh oh!

xdavidson left a comment

Uh oh!

carlosmunoz commented Nov 12, 2020

Uh oh!

aprajshekhar commented Nov 19, 2020

Uh oh!

aprajshekhar commented Nov 19, 2020 •

edited

Loading

Uh oh!

aprajshekhar left a comment

Uh oh!

carlosmunoz commented Nov 19, 2020

Uh oh!

aprajshekhar left a comment

Uh oh!

carlosmunoz commented Nov 30, 2020

Uh oh!

aprajshekhar commented Nov 30, 2020 •

edited

Loading

Uh oh!

codecov-commenter commented Apr 1, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

carlosmunoz commented Oct 23, 2020

Uh oh!

codecov-io commented Oct 23, 2020

Codecov Report

Uh oh!

xdavidson left a comment

Choose a reason for hiding this comment

Uh oh!

carlosmunoz commented Nov 12, 2020

Uh oh!

aprajshekhar commented Nov 19, 2020

Uh oh!

aprajshekhar commented Nov 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aprajshekhar left a comment

Choose a reason for hiding this comment

Uh oh!

carlosmunoz commented Nov 19, 2020

Uh oh!

aprajshekhar left a comment

Choose a reason for hiding this comment

Uh oh!

carlosmunoz commented Nov 30, 2020

Uh oh!

aprajshekhar commented Nov 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aprajshekhar commented Nov 19, 2020 •

edited

Loading

aprajshekhar commented Nov 30, 2020 •

edited

Loading

codecov-commenter commented Apr 1, 2026 •

edited

Loading