Skip to content

chore: fixes CVE-2025-15284 by upgrading qs version to 6.14.1#3993

Closed
alizard0 wants to merge 8 commits intoredhat-developer:mainfrom
alizard0:CVE-2025-15284
Closed

chore: fixes CVE-2025-15284 by upgrading qs version to 6.14.1#3993
alizard0 wants to merge 8 commits intoredhat-developer:mainfrom
alizard0:CVE-2025-15284

Conversation

@alizard0
Copy link
Copy Markdown
Member

Upgraded qs version to 6.14.1.
Forced resolution for request@npm:2.88.2/qs
Run yarn dedupe

@openshift-ci openshift-ci Bot requested review from albarbaro and polasudo January 13, 2026 11:31
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign albarbaro for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alizard0 alizard0 changed the title chores: fixes CVE-2025-15284 by upgrading qs version to 6.14.1 chore: fixes CVE-2025-15284 by upgrading qs version to 6.14.1 Jan 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

The image is available at:

/test e2e-ocp-helm

Comment thread dynamic-plugins/package.json Outdated
Copy link
Copy Markdown
Member

@kim-tsao kim-tsao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the pinned express versions in the static plugins need to be bumped
https://github.com/redhat-developer/rhdh/tree/main/plugins

see 1.8 PR #3974 for affected files

@github-actions
Copy link
Copy Markdown
Contributor

The image is available at:

/test e2e-ocp-helm

@alizard0
Copy link
Copy Markdown
Member Author

I think the pinned express versions in the static plugins need to be bumped https://github.com/redhat-developer/rhdh/tree/main/plugins

see 1.8 PR #3974 for affected files

@kim-tsao
I double check the PR changes, and the resolution was applied https://github.com/redhat-developer/rhdh/pull/3974/files
But in main branch there is no need for applying such resolution, after upgrading body-parser and express - the only qs@6.13.0 dependency is under packages/backend which I think it can be ignored.

@alizard0
Copy link
Copy Markdown
Member Author

/retest

@github-actions
Copy link
Copy Markdown
Contributor

The image is available at:

/test e2e-ocp-helm

@github-actions
Copy link
Copy Markdown
Contributor

The image is available at:

/test e2e-ocp-helm

@alizard0
Copy link
Copy Markdown
Member Author

/retest

@kim-tsao
Copy link
Copy Markdown
Member

I think the pinned express versions in the static plugins need to be bumped https://github.com/redhat-developer/rhdh/tree/main/plugins
see 1.8 PR #3974 for affected files

@kim-tsao I double check the PR changes, and the resolution was applied https://github.com/redhat-developer/rhdh/pull/3974/files But in main branch there is no need for applying such resolution, after upgrading body-parser and express - the only qs@6.13.0 dependency is under packages/backend which I think it can be ignored.

The resolution was added for the express dependency because it was pinned by the translations-backend. It was fixed in this PR and I'm pulling in the updated translation plugins in this PR which should update express

@github-actions
Copy link
Copy Markdown
Contributor

The image is available at:

/test e2e-ocp-helm

@github-actions
Copy link
Copy Markdown
Contributor

The image is available at:

/test e2e-ocp-helm

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

The image is available at:

/test e2e-ocp-helm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 21, 2026

@alizard0: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm b52660e link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kim-tsao
Copy link
Copy Markdown
Member

@alizard0 it looks like qs was updated via other PRs that were merged recently. We can close this as it's no longer needed

https://github.com/redhat-developer/rhdh/blob/main/yarn.lock#L32952-L32959

@kim-tsao kim-tsao closed this Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants