Skip to content

fix(#3751): remove redundant ref:// entries for bundled extensions plugins - #3755

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/3751-remove-extensions-ref-entries
Open

fix(#3751): remove redundant ref:// entries for bundled extensions plugins#3755
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/3751-remove-extensions-ref-entries

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

The extensions E2E dynamic-plugins.yaml included ref:// entries for three extensions plugins that are bundled inside the RHDH container image as local paths. In nightly mode, ref:// is resolved to {{inherit}} OCI references, but the inherit mechanism cannot match local-path entries in dynamic-plugins.default.yaml, causing the install-dynamic-plugins init container to crash.

Remove the three ref:// entries since the extensions plugins are already enabled by default via local paths. Keep only the oidc-provider auth plugin entry which uses a direct OCI reference.


Closes #3751

Post-script verification

  • Branch is not main/master (agent/3751-remove-extensions-ref-entries)
  • Secret scan passed (gitleaks — 899b60c9a39cb8e4d1b78fc23d2e2f0505a97fb3..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

…ugins

The extensions E2E dynamic-plugins.yaml included ref:// entries for
three extensions plugins that are bundled inside the RHDH container
image as local paths. In nightly mode, ref:// is resolved to
{{inherit}} OCI references, but the inherit mechanism cannot match
local-path entries in dynamic-plugins.default.yaml, causing the
install-dynamic-plugins init container to crash.

Remove the three ref:// entries since the extensions plugins are
already enabled by default via local paths. Keep only the
oidc-provider auth plugin entry which uses a direct OCI reference.

Closes #3751
@fullsend-ai-coder
fullsend-ai-coder Bot requested review from a team as code owners September 11, 2026 06:11
@fullsend-ai-coder
fullsend-ai-coder Bot requested review from ciiay and divyanshiGupta and removed request for a team September 11, 2026 06:11
@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown

Hi @fullsend-ai-coder[bot]. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sonarqubecloud

Copy link
Copy Markdown

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 11, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:12 AM UTC · Completed 6:17 AM UTC

Commit: 7d36a8c · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $0.68

@fullsend-ai-review

Copy link
Copy Markdown

Review — approve

Summary

This PR removes three redundant ref:// entries from workspaces/extensions/e2e-tests/tests/config/dynamic-plugins.yaml, fixing the nightly E2E test failure described in #3751.

Analysis

Root cause is correctly identified. The ref:// references for the three extensions plugins (catalog-backend-module-extensions, extensions-backend, extensions) are resolved via the {{inherit}} mechanism in nightly mode. This mechanism looks for a matching OCI entry in dynamic-plugins.default.yaml to inherit the version tag. However, these plugins are bundled inside the RHDH container image as local paths (./dynamic-plugins/dist/...), not as OCI references. The OCI-to-local-path mismatch causes the install-dynamic-plugins init container to crash.

Fix is correct. Since the extensions plugins are already included and enabled by default via local paths in the RHDH image, the ref:// entries are entirely redundant — they add nothing in local/PR mode and break nightly mode. Removing them is the right approach.

Remaining entry is unaffected. The oidc-provider auth plugin entry uses a direct OCI reference (oci://ghcr.io/...) rather than ref://, so it bypasses the {{inherit}} mechanism entirely and continues to work in all modes. This plugin is required for the Keycloak auth configuration used by the test spec.

Scope is appropriate. The change is confined to a single E2E test config file within the workspaces/extensions/e2e-tests/ directory, which is within the allowed modification scope for E2E nightly fixes per repo conventions. No plugin source code, CI configuration, or metadata files are modified.

No findings.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Sep 11, 2026
@github-actions github-actions Bot added mandatory-workspace PR affects a workspace with required plugins for releases workspace-update PR modifies files in an existing workspace labels Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mandatory-workspace PR affects a workspace with required plugins for releases needs-ok-to-test ready-for-merge All reviewers approved — ready to merge workspace-update PR modifies files in an existing workspace

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fullsend] E2E: extensions — inherit resolution fails for local-path plugins in nightly

0 participants