Skip to content

[DNM] Test ci import#334

Open
jkopriva wants to merge 7 commits intoredhat-appstudio:mainfrom
jkopriva:test-ci-import
Open

[DNM] Test ci import#334
jkopriva wants to merge 7 commits intoredhat-appstudio:mainfrom
jkopriva:test-ci-import

Conversation

@jkopriva
Copy link
Copy Markdown
Collaborator

@jkopriva jkopriva commented Mar 30, 2026

Summary by CodeRabbit

  • Tests
    • Expanded tested OpenShift versions to include OCP 4.18, 4.19, and 4.20.
    • Simplified the e2e test plan to a single CI/Git/registry configuration (GitLab/GitLab CI/Quay).
    • Added a GitLab/Tekton/Quay configuration for import-tests alongside the existing GitHub/Tekton/Quay entry.
    • Normalized test configuration formatting and ensured files end with a newline.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Expanded OCP support in integration test configuration from a single version to three (4.20, 4.19, 4.18). Adjusted testplan TSSC matrices: removed some tpa/acs fields and narrowed the e2e-tests entry to a single GitHub/Tekton/Quay pairing, and added a GitLab/Tekton/Quay tssc entry to import-tests.

Changes

Cohort / File(s) Summary
Version Matrix Expansion
integration-tests/config/rhads-config
Updated OCP variable from "4.20" to "4.20,4.19,4.18". Consumers that parse or iterate OCP values should be checked for CSV handling.
Test Plan Adjustments
integration-tests/config/testplan.json
Removed tpa/acs fields from one e2e-tests tssc entry; reduced e2e-tests tssc to { "git":"github", "ci":"tekton", "registry":"quay" }; added { "git":"gitlab", "ci":"tekton", "registry":"quay" } to import-tests. Verify CI matrix generation and any tooling expecting tpa/acs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • xinredhat
  • jsmid1
  • BohdanMar

Notes for reviewers (testing reliability, security, maintainability): confirm downstream parsers accept comma-separated OCP lists, ensure CI matrix generators handle the reduced e2e matrix and new import-tests GitLab entry, and verify no test selection logic relied on removed tpa/acs fields.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title '[DNM] Test ci import' is vague and generic, using non-descriptive terms that don't convey meaningful information about the changeset's actual purpose. Consider a more descriptive title that clarifies the specific changes, such as 'Expand OCP versions and update TSSC GitLab test configurations' to better reflect the configuration updates made.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@konflux-ci-qe-bot
Copy link
Copy Markdown

Scenario: pr-e2e-tests
@jkopriva: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
e2e-4.19-gwx5c Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.19-gwx5c

Test results analysis

<not enabled>

OCI Artifact Browser URL

<not enabled>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants