[WIP]verify Azure Pipelines works with Bitbucket provider#309
Open
xinredhat wants to merge 1 commit intoredhat-appstudio:mainfrom
Open
[WIP]verify Azure Pipelines works with Bitbucket provider#309xinredhat wants to merge 1 commit intoredhat-appstudio:mainfrom
xinredhat wants to merge 1 commit intoredhat-appstudio:mainfrom
Conversation
Review Summary by QodoSimplify test plan to verify Bitbucket with Azure Pipelines
WalkthroughsDescription• Simplify test plan to focus on Bitbucket with Azure Pipelines • Remove redundant test configurations for other git/CI combinations • Retain single test case for Bitbucket and Azure integration Diagramflowchart LR
A["Multiple git/CI combinations"] -- "Remove 7 configs" --> B["Single Bitbucket + Azure config"]
B -- "Keep for testing" --> C["Bitbucket + Azure Pipelines"]
File Changes1. integration-tests/config/testplan.json
|
Code Review by Qodo
1. Test matrix collapsed
|
📝 WalkthroughWalkthroughThe test plan configuration is streamlined by removing multiple tssc entries and consolidating to a single configuration targeting the Bitbucket repository with Azure CI, replacing the previous multi-entry setup that included Jenkins-based entries. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
integration-tests/config/testplan.json (1)
1-17:⚠️ Potential issue | 🟠 MajorMerging this [WIP] to
mainwill drop all non-Azure/Bitbucket test combinations.The previous configuration held multiple
tsscentries covering additional CI/Git provider combinations. This change replaces them all with a singlebitbucket + azureentry. If the goal is to verify Azure Pipelines works alongside existing coverage, the azure entry should be appended to the existing entries rather than substituting them. Landing this replacement onmainwould leave the branch testing only one combination going forward — a meaningful regression in test reliability.If the intent is purely exploratory (run only this combo in isolation), consider keeping this on the feature branch and not merging until the other combinations are restored.
✅ Suggested additive approach
"tssc": [ + { + "git": "bitbucket", + "ci": "azure", + "registry": "quay", + "tpa": "remote", + "acs": "remote" + }, { - "git": "bitbucket", - "ci": "azure", - "registry": "quay", - "tpa": "remote", - "acs": "remote" + ... /* restore previously existing entries here */ } ]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@integration-tests/config/testplan.json` around lines 1 - 17, The change replaced the existing tssc matrix with a single bitbucket+azure entry, removing other CI/git combinations; restore the previous tssc entries and append the new {"git":"bitbucket","ci":"azure","registry":"quay","tpa":"remote","acs":"remote"} object to that array instead of replacing it so all prior combinations remain covered (edit the "tssc" array in the testPlans entry that currently contains only a single object).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@integration-tests/config/testplan.json`:
- Around line 1-17: The change replaced the existing tssc matrix with a single
bitbucket+azure entry, removing other CI/git combinations; restore the previous
tssc entries and append the new
{"git":"bitbucket","ci":"azure","registry":"quay","tpa":"remote","acs":"remote"}
object to that array instead of replacing it so all prior combinations remain
covered (edit the "tssc" array in the testPlans entry that currently contains
only a single object).
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
6
to
11
| "tssc": [{ | ||
| "git": "github", | ||
| "ci": "tekton", | ||
| "registry": "quay", | ||
| "tpa": "remote", | ||
| "acs": "remote" | ||
| }, | ||
| { | ||
| "git": "gitlab", | ||
| "ci": "tekton", | ||
| "registry": "nexus", | ||
| "tpa": "remote", | ||
| "acs": "remote" | ||
| }, | ||
| { | ||
| "git": "gitlab", | ||
| "ci": "gitlabci", | ||
| "registry": "quay", | ||
| "tpa": "remote", | ||
| "acs": "remote" | ||
| }, | ||
| { | ||
| "git": "github", | ||
| "ci": "githubactions", | ||
| "registry": "artifactory", | ||
| "tpa": "remote", | ||
| "acs": "remote" | ||
| }, | ||
| { | ||
| "git": "github", | ||
| "ci": "azure", | ||
| "registry": "quay", | ||
| "tpa": "remote", | ||
| "acs": "remote" | ||
| }, | ||
| { | ||
| "git": "github", | ||
| "ci": "jenkins", | ||
| "registry": "quay", | ||
| "tpa": "remote", | ||
| "acs": "remote" | ||
| }, | ||
| { | ||
| "git": "gitlab", | ||
| "ci": "jenkins", | ||
| "registry": "quay", | ||
| "tpa": "remote", | ||
| "acs": "remote" | ||
| }, | ||
| { | ||
| "git": "bitbucket", | ||
| "ci": "jenkins", | ||
| "ci": "azure", | ||
| "registry": "quay", | ||
| "tpa": "remote", | ||
| "acs": "remote" |
There was a problem hiding this comment.
1. Test matrix collapsed 🐞 Bug ⛯ Reliability
The default integration test plan now generates only 1 template×TSSC combination (go × bitbucket+azure), which significantly reduces CI coverage for other supported Git/CI/registry combinations and increases regression risk.
Agent Prompt
## Issue description
`integration-tests/config/testplan.json` currently defines only one `tssc` configuration (bitbucket+azure) and one template (go). Because the Tekton `tssc-e2e` task uses this file by default, CI will only generate and run a single project configuration, reducing coverage for other supported provider combinations.
## Issue Context
- The CI task downloads this file when no `testplan` param is provided.
- `TestPlan` expands `templates × tssc` into the Playwright project matrix.
## Fix Focus Areas
- integration-tests/config/testplan.json[1-16]
- integration-tests/tasks/tssc-e2e.yaml[58-73]
- src/playwright/testplan.ts[64-93]
## Suggested fix approach
- Option A (simplest): Re-add the previously covered `tssc` combinations into the existing `backend-tests` plan and keep the new `bitbucket+azure` entry alongside them.
- Option B: Add a new dedicated plan (e.g., `bitbucket-azure-tests`) for the focused verification, while keeping `backend-tests` as the broad matrix used by default.
- If you choose Option B and want Tekton to run the new plan, ensure the execution path can select it (e.g., by passing a custom testplan content via the Tekton `testplan` param, or adjusting the command used in the task/scripts to allow overriding the plan name).
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
@xinredhat: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.20-mwskcTest results analysis<not enabled> OCI Artifact Browser URL<not enabled> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores