RHTAP-6103: Core Installer Framework #1600
Conversation
- Moved `pkg/subcmd/interface.go` to `pkg/api/subcommand.go` - Renamed Interface to SubCommand for clarity - Merged Runner and NewRunner into `pkg/api/subcommand.go` - Updated all subcommand implementations to use the new `api` package - Deleted `pkg/subcmd/runner.go` Assisted-by: Gemini
Decoupling the installer from hardcoded paths and enabling support for generic filesystems. - Add `pkg/framework/tarfs.go` with `NewTarFS` to create an `fs.FS` from embedded tarball bytes. - Introduce `pkg/chartfs/overlay.go` with `OverlayFS` to support prioritized file lookups between "Embedded" and "Local" layers. - Refactor `ChartFS` in `pkg/chartfs/chartfs.go` to wrap a single `fs.FS`, removing former constructors and hardcoded installer directory constants. - Update `pkg/config`, `pkg/mcptools`, and `pkg/subcmd` to use dependency injection for `ChartFS`. - Align all unit tests with the new API using `os.DirFS` for test fixtures. Assisted-by: Gemini
Migrating `.golangci.yaml` to support v3 schema.
It decouples the core logic from hardcoded directory structures by
establishing the provided `fs.FS` as the installer root and centralizing
asset filename conventions.
- Established a Framework Contract by moving key assets to the installer
root:
- Moved 'values.yaml.tpl' to 'installer/values.yaml.tpl'.
- Moved 'instructions.md' to 'installer/instructions.md'.
- Introduced 'pkg/api/types.go' to hold centralized constants
- Refactored the codebase to eliminate hardcoded filename strings.
- Decoupled MCP Server from 'go:embed'.
Implements the core framework entrypoint in `pkg/framework` including the `App` structure. It introduces `NewTarFS` to handle embedded assets and refactors ChartFS to accept any generic filesystem. The `main` application is updated to bootstrap via the new framework using an `OverlayFS` to merge embedded and local files. Assisted-by: Gemini
Decouple integration logic from the core installer framework by introducing a registry-based management system. - Move integration lifecycle management to `pkg/framework/app.go`. - Introduce `api.IntegrationModule` for pluggable integrations. - Refactor `integrations.Manager` to be a generic registry, removing hardcoded integration instances. - Use dependency injection to provide the Manager to Deploy and Integration subcommands. Assisted-by: Gemini
Refactor MCP tools and server to use a dynamic application name instead of `constants.AppName`. Assisted-by: Gemini
Relocate MCP server implementation to framework package to: - Avoid naming collision with mark3labs/mcp-go/mcp - Establish as part of public framework API - Align with installer framework architecture plan File history preserved via git mv.
Introduces `MCPToolsBuilder` and `MCPToolsContext` to decouple tool instantiation from the `mcpserver` subcommand. This allows injecting custom tool sets and simplifies the main server logic. - Move standard tool creation to `pkg/subcmd/mcptools.go`. - Update `framework.App` to support custom tool builders and MCP image config. - Ensure `MCPToolsContext` enforces `io.Discard` for logging to protect the MCP STDIO protocol. Assisted-by: Gemini
|
@otaviof: This pull request references RHTAP-6067 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@otaviof: This pull request references RHTAP-6067 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
📝 Walkthrough📝 WalkthroughWalkthroughReplaces root/cmd wiring with a framework App driven by AppContext; introduces AppContext and SubCommand API; layers filesystems via OverlayFS/ChartFS; centralizes annotations/constants; rewires MCP tools, integrations, and subcommands to use the new app/integration/module model; updates linter/formatter config and Helm annotation keys. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Main
participant TarFS
participant App
participant ChartFS
participant IntegrManager as Integrations.Manager
participant MCPBuilder as MCPToolsBuilder
participant MCPServer
User->>Main: run CLI
Main->>TarFS: NewTarFS(embedded tarball)
TarFS-->>Main: fs.FS
Main->>ChartFS: New(overlay fs)
Main->>App: NewApp(AppContext, ChartFS, options...)
App->>IntegrManager: LoadModules(...)
IntegrManager-->>App: modules registered
App->>MCPBuilder: StandardMCPToolsBuilder()
MCPBuilder-->>App: []mcptools.Interface
App->>MCPServer: NewMCPServer(appCtx, builder, image)
App->>MCPServer: Start / Run()
MCPServer-->>User: expose MCP API / tools
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@otaviof: This pull request references RHTAP-6067 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Fix all issues with AI Agents 🤖
In @.golangci.yaml:
- Around line 69-79: The golangci-lint config incorrectly uses a top-level
"formatters" section; remove that "formatters" block entirely and add the
formatters as linters under the existing "linters.enable" list (add gofmt,
gofumpt, goimports to linters.enable). Also move or merge any relevant exclusion
rules (generated/paths) into the appropriate golangci-lint "exclude" or
"linters-settings" sections if needed, ensuring only supported top-level keys
remain and that gofmt/gofumpt/goimports are enabled via "linters.enable".
- Around line 51-65: The current "exclusions" block is not valid golangci-lint
syntax; replace it with standard keys: move conditional rules under
"issues.exclude-rules" (translate your revive file-pattern rule into an
exclude-rule matching path: (.+)_test.go and linter: revive), move path globs
into "run.skip-dirs" or "run.skip-files" (e.g., third_party$, builtin$,
examples$), and put linter-specific options under "linters-settings" if needed;
ensure you remove the invalid "exclusions" top-level key and validate the YAML
with golangci-lint config parser.
In @cmd/tssc/main.go:
- Around line 31-35: The call to cfs.WithBaseDir("installer") silently ignores
errors (bcfs, err := cfs.WithBaseDir("installer"); err == nil { cfs = bcfs })
which can hide misconfiguration; change this to explicitly handle the error by
checking if err != nil and then return or exit with a clear error message that
includes err (or use process logger / fmt.Errorf) so the program fails fast
instead of continuing with the wrong cfs; update the block around WithBaseDir,
bcfs, and err to log/return the wrapped error (or call log.Fatalf/os.Exit(1))
rather than swallowing it.
In @pkg/framework/tarfs.go:
- Around line 10-13: NewTarFS currently returns the raw error from tarfs.New
with no context; change it to call tarfs.New(bytes.NewReader(tarball)), check
the returned err, and if non-nil wrap it with contextual text (e.g. "creating
tar fs" or "NewTarFS: failed to create tar fs") using fmt.Errorf("%s: %w", ...)
before returning; keep the function signature the same and return the wrapped
error and the fs on success.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pkg/subcmd/integration_github.go (1)
78-90:panicfor unimplemented--updatecould crash production usage.Using
panicfor an unimplemented code path is risky if users accidentally invoke it. Consider returning an error instead:🔎 Proposed fix
func (g *IntegrationGitHub) Run() error { if g.create { return g.integration.Create(g.cmd.Context(), g.cfg) } if g.update { - // TODO: implement update. - panic(fmt.Sprintf( - "TODO: '%s integration github --update'", constants.AppName, - )) + return fmt.Errorf("'%s integration github --update' is not yet implemented", constants.AppName) } return nil }
🧹 Nitpick comments (8)
pkg/integrations/manager.go (2)
93-109:LoadModulesalways returnsnil- consider removing error return or using it.The function signature returns an error but always returns
nil. If error handling is planned for future validation (e.g., duplicate module names), that's fine. Otherwise, simplify the signature:🔎 Option 1: Add duplicate detection
func (m *Manager) LoadModules( appName string, logger *slog.Logger, kube *k8s.Kube, modules []api.IntegrationModule, ) error { for _, mod := range modules { + if _, exists := m.modules[IntegrationName(mod.Name)]; exists { + return fmt.Errorf("duplicate integration module: %q", mod.Name) + } impl := mod.Init(logger, kube) secretName := fmt.Sprintf("%s-%s-integration", appName, mod.Name) wrapper := integration.NewSecret(logger, kube, secretName, impl) m.Register(mod, wrapper) } return nil }
57-64: Non-deterministic iteration order forGetModules.Map iteration order in Go is randomized. If consumers depend on consistent ordering (e.g., for CLI help output or deterministic testing), consider sorting or using a slice to preserve insertion order.
pkg/subcmd/integration_jenkins.go (1)
3-12: Import ordering: standard library imports should precede third-party imports.The
apipackage import appears beforelog/slog. Go convention and most linters expect standard library imports first:🔎 Suggested import ordering
import ( + "log/slog" + "github.com/redhat-appstudio/tssc-cli/pkg/api" - "log/slog" "github.com/redhat-appstudio/tssc-cli/pkg/config" "github.com/redhat-appstudio/tssc-cli/pkg/integration" "github.com/redhat-appstudio/tssc-cli/pkg/k8s" "github.com/spf13/cobra" )pkg/subcmd/integration_github.go (1)
3-14: Import ordering: standard library imports should precede third-party imports.Same issue as other files -
apiappears beforefmtandlog/slog:🔎 Suggested import ordering
import ( - "github.com/redhat-appstudio/tssc-cli/pkg/api" "fmt" "log/slog" + "github.com/redhat-appstudio/tssc-cli/pkg/api" "github.com/redhat-appstudio/tssc-cli/pkg/config" "github.com/redhat-appstudio/tssc-cli/pkg/constants" "github.com/redhat-appstudio/tssc-cli/pkg/integration" "github.com/redhat-appstudio/tssc-cli/pkg/k8s" "github.com/spf13/cobra" )pkg/subcmd/integration_artifactory.go (1)
3-12: Import ordering: standard library imports should precede third-party imports.The
apipackage import appears beforelog/slog:🔎 Suggested import ordering
import ( - "github.com/redhat-appstudio/tssc-cli/pkg/api" "log/slog" + "github.com/redhat-appstudio/tssc-cli/pkg/api" "github.com/redhat-appstudio/tssc-cli/pkg/config" "github.com/redhat-appstudio/tssc-cli/pkg/integration" "github.com/redhat-appstudio/tssc-cli/pkg/k8s" "github.com/spf13/cobra" )pkg/chartfs/overlay.go (1)
17-25: Consider adding nil safety checks for robustness.The
Openmethod assumes bothEmbeddedandLocalare non-nil. If either is nil, this will cause a panic at runtime.🔎 Proposed defensive check
func (o *OverlayFS) Open(name string) (fs.File, error) { + if o.Embedded == nil && o.Local == nil { + return nil, fs.ErrNotExist + } + if o.Embedded == nil { + return o.Local.Open(name) + } f, err := o.Embedded.Open(name) if err == nil { return f, nil } if !errors.Is(err, fs.ErrNotExist) { return nil, err } + if o.Local == nil { + return nil, err + } return o.Local.Open(name) }pkg/subcmd/deploy.go (1)
115-127: Consider using dynamic appName in error messages.The error message on lines 117-123 uses
constants.AppNamethree times, while other parts of this PR (MCP tools, framework) use dynamicappName. This creates an inconsistency where the integration hint will always show the hardcoded app name regardless of how the framework is configured.If dynamic naming should be fully consistent, consider passing
appNametoNewDeployand storing it for use in these messages.pkg/chartfs/chartfs.go (1)
19-27: LGTM!The
ReadFileandOpenmethods correctly delegate to the underlyingfs.FS, implementing thefs.FSinterface properly. The comment on line 24 has a trailing backtick that appears to be a typo.🔎 Minor typo fix in comment
-// Open opens the named file. Implements "fs.FS" interface.` +// Open opens the named file. Implements "fs.FS" interface.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (60)
.golangci.yamlREADME.mdcmd/tssc/main.gohack/deploy.shinstaller/instructions.mdinstaller/values.yaml.tplintegration-tests/scripts/install.shpkg/api/subcommand.gopkg/api/types.gopkg/chartfs/chartfs.gopkg/chartfs/chartfs_test.gopkg/chartfs/overlay.gopkg/cmd/root.gopkg/config/config.gopkg/config/config_test.gopkg/config/manager.gopkg/constants/constants.gopkg/engine/engine.gopkg/engine/engine_test.gopkg/flags/installer.gopkg/framework/app.gopkg/framework/mcpserver/mcpserver.gopkg/framework/options.gopkg/framework/tarfs.gopkg/hooks/hooks_test.gopkg/integrations/manager.gopkg/mcptools/configtools.gopkg/mcptools/context.gopkg/mcptools/deploytools.gopkg/mcptools/integrationtools.gopkg/mcptools/notestool.gopkg/mcptools/statustool.gopkg/mcptools/topology.gopkg/mcptools/utils.gopkg/resolver/collection_test.gopkg/resolver/dependency_test.gopkg/resolver/resolver_test.gopkg/resolver/topology_test.gopkg/subcmd/config.gopkg/subcmd/deploy.gopkg/subcmd/installer.gopkg/subcmd/integration.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_artifactory.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_github.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_jenkins.gopkg/subcmd/integration_nexus.gopkg/subcmd/integration_quay.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/integration_trustification.gopkg/subcmd/interface.gopkg/subcmd/mcpserver.gopkg/subcmd/mcptools.gopkg/subcmd/modules.gopkg/subcmd/runner.gopkg/subcmd/template.gopkg/subcmd/topology.go
💤 Files with no reviewable changes (3)
- pkg/subcmd/runner.go
- pkg/cmd/root.go
- pkg/subcmd/interface.go
🧰 Additional context used
📓 Path-based instructions (7)
**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Never hardcode Gemini API keys in source code; use environment variables or secure configuration management
Files:
hack/deploy.shpkg/engine/engine.gopkg/mcptools/utils.gopkg/subcmd/integration_github.gopkg/framework/mcpserver/mcpserver.gopkg/flags/installer.gopkg/subcmd/integration_nexus.gopkg/subcmd/integration_jenkins.goREADME.mdpkg/subcmd/installer.gopkg/subcmd/topology.gopkg/subcmd/config.gopkg/engine/engine_test.gopkg/subcmd/template.gopkg/subcmd/integration_acs.gopkg/mcptools/statustool.gopkg/mcptools/context.gocmd/tssc/main.gopkg/config/manager.gopkg/api/types.gopkg/subcmd/integration_quay.gopkg/subcmd/modules.gointegration-tests/scripts/install.shpkg/api/subcommand.gopkg/resolver/topology_test.gopkg/constants/constants.gopkg/framework/tarfs.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/mcptools.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/integration.gopkg/config/config.gopkg/chartfs/chartfs_test.gopkg/mcptools/topology.gopkg/subcmd/deploy.gopkg/subcmd/integration_trustification.gopkg/chartfs/chartfs.gopkg/resolver/resolver_test.gopkg/integrations/manager.gopkg/mcptools/notestool.gopkg/subcmd/integration_azure.gopkg/mcptools/deploytools.gopkg/config/config_test.gopkg/mcptools/configtools.gopkg/subcmd/integration_artifactory.gopkg/hooks/hooks_test.gopkg/resolver/collection_test.gopkg/chartfs/overlay.gopkg/framework/app.gopkg/mcptools/integrationtools.gopkg/framework/options.gopkg/subcmd/mcpserver.gopkg/resolver/dependency_test.go
**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Use
go:embeddirective to embedinstallerdirectory resources (Helm charts, configurations, values.yaml.tpl) in the executable
Files:
pkg/engine/engine.gopkg/mcptools/utils.gopkg/subcmd/integration_github.gopkg/framework/mcpserver/mcpserver.gopkg/flags/installer.gopkg/subcmd/integration_nexus.gopkg/subcmd/integration_jenkins.gopkg/subcmd/installer.gopkg/subcmd/topology.gopkg/subcmd/config.gopkg/engine/engine_test.gopkg/subcmd/template.gopkg/subcmd/integration_acs.gopkg/mcptools/statustool.gopkg/mcptools/context.gocmd/tssc/main.gopkg/config/manager.gopkg/api/types.gopkg/subcmd/integration_quay.gopkg/subcmd/modules.gopkg/api/subcommand.gopkg/resolver/topology_test.gopkg/constants/constants.gopkg/framework/tarfs.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/mcptools.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/integration.gopkg/config/config.gopkg/chartfs/chartfs_test.gopkg/mcptools/topology.gopkg/subcmd/deploy.gopkg/subcmd/integration_trustification.gopkg/chartfs/chartfs.gopkg/resolver/resolver_test.gopkg/integrations/manager.gopkg/mcptools/notestool.gopkg/subcmd/integration_azure.gopkg/mcptools/deploytools.gopkg/config/config_test.gopkg/mcptools/configtools.gopkg/subcmd/integration_artifactory.gopkg/hooks/hooks_test.gopkg/resolver/collection_test.gopkg/chartfs/overlay.gopkg/framework/app.gopkg/mcptools/integrationtools.gopkg/framework/options.gopkg/subcmd/mcpserver.gopkg/resolver/dependency_test.go
pkg/engine/**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Use Helm SDK in
pkg/enginefor Helm engine implementation, chart installation, templating functions, and installation lifecycle management
Files:
pkg/engine/engine.gopkg/engine/engine_test.go
pkg/subcmd/**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
pkg/subcmd/**/*.go: Usecobralibrary for CLI command structure in the tssc-cli project
Define commands as structs inpkg/subcmdthat implement a common interface
Use specificvalidateFlags()methods for flag logic (e.g., mutual exclusion) rather than relying only on Cobra's built-in validators
Inject dependencies likek8s.Kubeandchartfs.ChartFSvia constructors in command structs
Files:
pkg/subcmd/integration_github.gopkg/subcmd/integration_nexus.gopkg/subcmd/integration_jenkins.gopkg/subcmd/installer.gopkg/subcmd/topology.gopkg/subcmd/config.gopkg/subcmd/template.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_quay.gopkg/subcmd/modules.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/mcptools.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/integration.gopkg/subcmd/deploy.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_artifactory.gopkg/subcmd/mcpserver.go
**/*_test.go
📄 CodeRabbit inference engine (GEMINI.md)
Use the standard
testingpackage withgithub.com/onsi/gomegaassertion library for tests
Files:
pkg/engine/engine_test.gopkg/resolver/topology_test.gopkg/chartfs/chartfs_test.gopkg/resolver/resolver_test.gopkg/config/config_test.gopkg/hooks/hooks_test.gopkg/resolver/collection_test.gopkg/resolver/dependency_test.go
pkg/resolver/**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Use
pkg/resolverto define the dependency topology, including the sequence of Helm Charts and relationships between them and required integrations
Files:
pkg/resolver/topology_test.gopkg/resolver/resolver_test.gopkg/resolver/collection_test.gopkg/resolver/dependency_test.go
pkg/chartfs/**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Implement
io.FScompatible abstraction inpkg/chartfsto provide access to embedded installer directory resources
Files:
pkg/chartfs/chartfs_test.gopkg/chartfs/chartfs.gopkg/chartfs/overlay.go
🧠 Learnings (25)
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/engine/**/*.go : Use Helm SDK in `pkg/engine` for Helm engine implementation, chart installation, templating functions, and installation lifecycle management
Applied to files:
pkg/engine/engine.gopkg/subcmd/installer.gopkg/subcmd/topology.gopkg/subcmd/config.gopkg/engine/engine_test.gopkg/subcmd/template.gocmd/tssc/main.gopkg/subcmd/integration.gopkg/config/config.gopkg/mcptools/topology.gopkg/subcmd/deploy.gopkg/mcptools/notestool.gopkg/mcptools/configtools.gopkg/hooks/hooks_test.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Use `cobra` library for CLI command structure in the tssc-cli project
Applied to files:
pkg/engine/engine.gopkg/mcptools/utils.gopkg/subcmd/integration_github.gopkg/flags/installer.gopkg/subcmd/integration_nexus.gopkg/subcmd/integration_jenkins.gopkg/subcmd/installer.gopkg/subcmd/topology.gopkg/subcmd/config.gopkg/subcmd/template.gopkg/subcmd/integration_acs.gopkg/mcptools/statustool.gocmd/tssc/main.gopkg/config/manager.gopkg/subcmd/integration_quay.gopkg/subcmd/modules.gopkg/api/subcommand.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/mcptools.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/integration.gopkg/config/config.gopkg/mcptools/topology.gopkg/subcmd/deploy.gopkg/subcmd/integration_trustification.gopkg/mcptools/notestool.gopkg/subcmd/integration_azure.gopkg/mcptools/configtools.gopkg/subcmd/integration_artifactory.gopkg/mcptools/integrationtools.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Use specific `validateFlags()` methods for flag logic (e.g., mutual exclusion) rather than relying only on Cobra's built-in validators
Applied to files:
pkg/mcptools/utils.gopkg/subcmd/integration_github.gopkg/flags/installer.gopkg/subcmd/integration_nexus.gopkg/subcmd/integration_jenkins.gopkg/subcmd/installer.gopkg/subcmd/config.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_quay.gopkg/api/subcommand.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_artifactory.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Define commands as structs in `pkg/subcmd` that implement a common interface
Applied to files:
pkg/mcptools/utils.gopkg/subcmd/integration_github.gopkg/subcmd/integration_nexus.gopkg/subcmd/integration_jenkins.gopkg/subcmd/installer.gopkg/subcmd/topology.gopkg/subcmd/config.gopkg/subcmd/template.gopkg/subcmd/integration_acs.gopkg/mcptools/statustool.gocmd/tssc/main.gopkg/api/types.gopkg/subcmd/integration_quay.gopkg/subcmd/modules.gopkg/api/subcommand.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/mcptools.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/integration.gopkg/mcptools/topology.gopkg/subcmd/deploy.gopkg/subcmd/integration_trustification.gopkg/mcptools/notestool.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_artifactory.gopkg/mcptools/integrationtools.go
📚 Learning: 2025-09-29T14:49:45.227Z
Learnt from: lingyzhuang
Repo: redhat-appstudio/tssc-cli PR: 1276
File: pkg/mcptools/configtools.go:0-0
Timestamp: 2025-09-29T14:49:45.227Z
Learning: In pkg/mcptools/configtools.go, the SettingsArg and ProductsArg constants are used for Gemini input generation, where Gemini uses these parameter names to generate input and the system reads the input content by these argument names.
Applied to files:
pkg/mcptools/utils.gopkg/mcptools/statustool.gopkg/mcptools/topology.gopkg/mcptools/configtools.gopkg/mcptools/integrationtools.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Enable and follow linters: asciicheck, dogsled, dupword, errorlint, goconst, misspell, nakedret, nolintlint, revive, staticcheck, testifylint, unconvert, usestdlibvars, whitespace
Applied to files:
pkg/mcptools/utils.gopkg/subcmd/installer.gopkg/subcmd/topology.gopkg/subcmd/config.gopkg/subcmd/template.gopkg/mcptools/statustool.gopkg/config/manager.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration.gopkg/config/config.gopkg/subcmd/deploy.gopkg/mcptools/notestool.go.golangci.yamlpkg/mcptools/integrationtools.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Inject dependencies like `k8s.Kube` and `chartfs.ChartFS` via constructors in command structs
Applied to files:
pkg/mcptools/utils.gopkg/subcmd/integration_github.gopkg/flags/installer.gopkg/subcmd/integration_nexus.gopkg/subcmd/integration_jenkins.gopkg/subcmd/installer.gopkg/subcmd/topology.gopkg/subcmd/config.gopkg/engine/engine_test.gopkg/subcmd/template.gopkg/subcmd/integration_acs.gopkg/mcptools/statustool.gopkg/mcptools/context.gocmd/tssc/main.gopkg/subcmd/integration_quay.gopkg/subcmd/modules.gopkg/api/subcommand.gopkg/resolver/topology_test.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/integration.gopkg/config/config.gopkg/chartfs/chartfs_test.gopkg/mcptools/topology.gopkg/subcmd/deploy.gopkg/subcmd/integration_trustification.gopkg/chartfs/chartfs.gopkg/resolver/resolver_test.gopkg/mcptools/notestool.gopkg/subcmd/integration_azure.gopkg/config/config_test.gopkg/mcptools/configtools.gopkg/subcmd/integration_artifactory.gopkg/hooks/hooks_test.gopkg/resolver/collection_test.gopkg/framework/app.gopkg/mcptools/integrationtools.gopkg/subcmd/mcpserver.gopkg/resolver/dependency_test.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/integration/**/*.go : Define integrations in `pkg/integration` to connect to external services like GitHub, Quay, etc.
Applied to files:
pkg/subcmd/integration_github.gopkg/subcmd/integration_nexus.gopkg/subcmd/integration_jenkins.gopkg/subcmd/topology.gopkg/subcmd/template.gopkg/subcmd/integration_acs.gopkg/mcptools/statustool.gopkg/api/types.gopkg/subcmd/integration_quay.gopkg/subcmd/modules.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/integration.gopkg/mcptools/topology.gopkg/subcmd/deploy.gopkg/subcmd/integration_trustification.gopkg/integrations/manager.gopkg/mcptools/notestool.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_artifactory.gopkg/mcptools/integrationtools.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Define interface definition at the top of service files, followed by service struct and implementation
Applied to files:
pkg/subcmd/integration_github.gopkg/subcmd/topology.gopkg/subcmd/config.gopkg/subcmd/template.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration.gopkg/subcmd/deploy.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_artifactory.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Regenerate mocks after modifying existing interfaces
Applied to files:
pkg/subcmd/integration_github.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_artifactory.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Do not use `interface{}`, use the `any` alias instead
Applied to files:
pkg/subcmd/integration_github.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_azure.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to **/*.go : Use `go:embed` directive to embed `installer` directory resources (Helm charts, configurations, values.yaml.tpl) in the executable
Applied to files:
pkg/flags/installer.goREADME.mdpkg/subcmd/installer.gopkg/mcptools/statustool.gocmd/tssc/main.gopkg/config/config.gopkg/chartfs/chartfs.gopkg/mcptools/notestool.gopkg/framework/app.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/chartfs/**/*.go : Implement `io.FS` compatible abstraction in `pkg/chartfs` to provide access to embedded installer directory resources
Applied to files:
pkg/flags/installer.gopkg/subcmd/installer.gopkg/subcmd/topology.gopkg/subcmd/config.gopkg/engine/engine_test.gopkg/subcmd/template.gopkg/mcptools/statustool.gocmd/tssc/main.gopkg/resolver/topology_test.gopkg/framework/tarfs.gopkg/subcmd/integration.gopkg/config/config.gopkg/chartfs/chartfs_test.gopkg/mcptools/topology.gopkg/subcmd/deploy.gopkg/chartfs/chartfs.gopkg/resolver/resolver_test.gopkg/config/config_test.gopkg/mcptools/configtools.gopkg/hooks/hooks_test.gopkg/resolver/collection_test.gopkg/chartfs/overlay.gopkg/framework/app.gopkg/resolver/dependency_test.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/resolver/**/*.go : Use `pkg/resolver` to define the dependency topology, including the sequence of Helm Charts and relationships between them and required integrations
Applied to files:
pkg/flags/installer.gopkg/subcmd/topology.gopkg/subcmd/template.gopkg/resolver/topology_test.gopkg/config/config.gopkg/mcptools/topology.gopkg/subcmd/deploy.gopkg/resolver/resolver_test.gopkg/mcptools/configtools.gopkg/resolver/collection_test.gopkg/resolver/dependency_test.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*_test.go : All tests must use the `testing` package with `testify/assert` library
Applied to files:
pkg/subcmd/topology.gopkg/subcmd/config.gopkg/subcmd/template.gopkg/chartfs/chartfs_test.gopkg/config/config_test.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Use the `any` type alias instead of `interface{}` for generic types
Applied to files:
pkg/subcmd/integration_gitlab.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*_service.go : Regenerate mocks after adding new service interfaces
Applied to files:
pkg/subcmd/integration_gitlab.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to **/*_test.go : Use the standard `testing` package with `github.com/onsi/gomega` assertion library for tests
Applied to files:
pkg/chartfs/chartfs_test.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/testdata/** : Store test data in `testdata/` directory
Applied to files:
pkg/chartfs/chartfs_test.go
📚 Learning: 2025-08-27T18:30:02.411Z
Learnt from: Roming22
Repo: redhat-appstudio/tssc-cli PR: 1190
File: pkg/resolver/resolver_test.go:52-67
Timestamp: 2025-08-27T18:30:02.411Z
Learning: In tssc-cli, there is a distinction between deployment namespace (where resources are deployed, referenced in values.yaml.tpl) and chart registration namespace (where Helm charts are registered, tested in resolver tests). These are different concepts and may use different namespace values.
Applied to files:
pkg/subcmd/deploy.go
📚 Learning: 2025-09-29T15:10:13.650Z
Learnt from: lingyzhuang
Repo: redhat-appstudio/tssc-cli PR: 1276
File: pkg/config/config.go:159-185
Timestamp: 2025-09-29T15:10:13.650Z
Learning: In the tssc-cli project, the UpdateMappingValue method in pkg/config/config.go should only update existing configuration keys and not create new ones. Adding new config entries is not allowed, so silent return when key is not found is the desired behavior.
Applied to files:
pkg/mcptools/configtools.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Check `.golangci.yml` for specific linter rule configurations
Applied to files:
.golangci.yaml
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Run all linters using 'make lint' with golangci-lint and custom configuration in .golangci.yml
Applied to files:
.golangci.yaml
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Format all Go files using `gofumpt` with 'make fmt'
Applied to files:
.golangci.yaml
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : All API methods should accept `options ...RequestOptionFunc` parameter
Applied to files:
pkg/framework/options.go
🧬 Code graph analysis (32)
pkg/subcmd/integration_github.go (1)
pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/flags/installer.go (1)
pkg/constants/constants.go (1)
ValuesFilename(22-22)
pkg/subcmd/integration_nexus.go (1)
pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/integration_jenkins.go (1)
pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/installer.go (2)
pkg/api/subcommand.go (1)
SubCommand(9-22)pkg/installer/installer.go (1)
Installer(24-32)
pkg/subcmd/config.go (2)
pkg/api/subcommand.go (1)
SubCommand(9-22)pkg/config/config.go (1)
Config(30-36)
pkg/engine/engine_test.go (1)
pkg/chartfs/chartfs.go (1)
New(98-100)
pkg/subcmd/template.go (1)
pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/integration_acs.go (1)
pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/mcptools/context.go (5)
pkg/constants/constants.go (1)
AppName(7-7)pkg/flags/flags.go (1)
Flags(18-25)pkg/chartfs/chartfs.go (1)
ChartFS(15-17)pkg/k8s/kube.go (1)
Kube(21-23)pkg/integrations/manager.go (1)
Manager(20-23)
cmd/tssc/main.go (8)
pkg/framework/tarfs.go (1)
NewTarFS(11-13)installer/embed.go (1)
InstallerTarball(9-9)pkg/chartfs/overlay.go (1)
OverlayFS(10-13)pkg/chartfs/chartfs.go (1)
New(98-100)pkg/framework/app.go (1)
NewApp(132-151)pkg/constants/constants.go (1)
AppName(7-7)pkg/framework/options.go (2)
WithShortDescription(19-23)WithIntegrations(33-37)pkg/subcmd/modules.go (1)
StandardModules(125-139)
pkg/config/manager.go (1)
pkg/constants/constants.go (1)
ConfigFilename(19-19)
pkg/api/types.go (3)
pkg/k8s/kube.go (1)
Kube(21-23)pkg/integration/integration.go (1)
Integration(19-26)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/resolver/topology_test.go (1)
pkg/chartfs/chartfs.go (1)
New(98-100)
pkg/framework/tarfs.go (1)
pkg/chartfs/chartfs.go (1)
New(98-100)
pkg/subcmd/integration_gitlab.go (1)
pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/integration_bitbucket.go (1)
pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/integration_trustedartifactsigner.go (1)
pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/integration.go (2)
pkg/integrations/manager.go (2)
Manager(20-23)IntegrationName(15-15)pkg/api/subcommand.go (1)
NewRunner(36-47)
pkg/config/config.go (3)
pkg/constants/constants.go (1)
ConfigFilename(19-19)pkg/chartfs/chartfs.go (1)
ChartFS(15-17)pkg/subcmd/config.go (1)
Config(21-36)
pkg/subcmd/deploy.go (3)
pkg/integrations/manager.go (1)
Manager(20-23)pkg/resolver/topologybuilder.go (1)
TopologyBuilder(14-18)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/integration_trustification.go (1)
pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/resolver/resolver_test.go (1)
pkg/chartfs/chartfs.go (1)
New(98-100)
pkg/mcptools/notestool.go (1)
pkg/installer/job.go (2)
Job(22-26)NewJob(298-304)
pkg/subcmd/integration_azure.go (1)
pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/config/config_test.go (1)
pkg/chartfs/chartfs.go (1)
New(98-100)
pkg/subcmd/integration_artifactory.go (1)
pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/hooks/hooks_test.go (1)
pkg/chartfs/chartfs.go (1)
New(98-100)
pkg/resolver/collection_test.go (1)
pkg/chartfs/chartfs.go (1)
New(98-100)
pkg/framework/app.go (13)
pkg/constants/constants.go (1)
CommitID(37-37)pkg/chartfs/chartfs.go (1)
ChartFS(15-17)pkg/api/types.go (1)
IntegrationModule(13-23)pkg/integrations/manager.go (2)
Manager(20-23)NewManager(112-117)pkg/k8s/kube.go (2)
Kube(21-23)NewKube(143-145)pkg/mcptools/context.go (1)
MCPToolsBuilder(52-52)pkg/subcmd/integration.go (1)
NewIntegration(16-83)pkg/subcmd/mcptools.go (1)
StandardMCPToolsBuilder(13-15)pkg/api/subcommand.go (2)
SubCommand(9-22)NewRunner(36-47)pkg/subcmd/config.go (1)
NewConfig(284-307)pkg/subcmd/deploy.go (1)
NewDeploy(193-216)pkg/subcmd/mcpserver.go (1)
NewMCPServer(89-115)pkg/framework/options.go (1)
Option(9-9)
pkg/framework/options.go (4)
pkg/framework/app.go (1)
App(20-35)pkg/constants/constants.go (1)
Version(33-33)pkg/api/types.go (1)
IntegrationModule(13-23)pkg/mcptools/context.go (1)
MCPToolsBuilder(52-52)
pkg/resolver/dependency_test.go (1)
pkg/chartfs/chartfs.go (1)
New(98-100)
|
/retest |
1 similar comment
|
/retest |
otaviof
changed the title
|
@otaviof: This pull request references RHTAP-6103 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@otaviof: This pull request references RHTAP-6103 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
Fixes bug where local file arguments required double "installer/" prefix when using `tssc config --create installer/config.yaml`. Also used in the `install.sh` CI script.
|
@otaviof: This pull request references RHTAP-6103 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Moves MCP image configuration and version, commit-ID, and container image from the framework to `main.go`. Assisted-by: Claude
|
@otaviof: This pull request references RHTAP-6103 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cmd/tssc/main.go (1)
37-43: Consider extracting the image registry base path as a constant.The hardcoded registry path
quay.io/redhat-user-workloads/rhtap-shared-team-tenant/tssc-cliis specific to the tssc-cli project. While this is appropriate forcmd/tssc/main.go, if other binaries will reuse the framework with different images, consider defining this as a constant or making it configurable via environment variable for easier maintenance.🔎 Optional refactor
+const mcpImageBase = "quay.io/redhat-user-workloads/rhtap-shared-team-tenant/tssc-cli" + func main() { // ... - mcpImage := "quay.io/redhat-user-workloads/rhtap-shared-team-tenant/tssc-cli" + mcpImage := mcpImageBase if commitID == "" { mcpImage = fmt.Sprintf("%s:latest", mcpImage) } else { mcpImage = fmt.Sprintf("%s:%s", mcpImage, commitID) }
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.goreleaser.yamlMakefilecmd/tssc/main.gopkg/constants/constants.gopkg/flags/flags.gopkg/framework/app.gopkg/framework/options.go
🚧 Files skipped from review as they are similar to previous changes (1)
- pkg/framework/options.go
🧰 Additional context used
📓 Path-based instructions (2)
**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Never hardcode Gemini API keys in source code; use environment variables or secure configuration management
Files:
pkg/constants/constants.gocmd/tssc/main.gopkg/flags/flags.goMakefilepkg/framework/app.go
**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Use
go:embeddirective to embedinstallerdirectory resources (Helm charts, configurations, values.yaml.tpl) in the executable
Files:
pkg/constants/constants.gocmd/tssc/main.gopkg/flags/flags.gopkg/framework/app.go
🧠 Learnings (14)
📓 Common learnings
Learnt from: Roming22
Repo: redhat-appstudio/tssc-cli PR: 1159
File: installer/charts/tssc-dh/Chart.yaml:5-6
Timestamp: 2025-08-20T15:48:01.881Z
Learning: In the tssc-cli project, chart version bumps in Chart.yaml files are handled at code freeze rather than immediately when appVersion changes, as part of their coordinated release process.
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/chartfs/**/*.go : Implement `io.FS` compatible abstraction in `pkg/chartfs` to provide access to embedded installer directory resources
Applied to files:
cmd/tssc/main.gopkg/framework/app.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Inject dependencies like `k8s.Kube` and `chartfs.ChartFS` via constructors in command structs
Applied to files:
cmd/tssc/main.gopkg/flags/flags.gopkg/framework/app.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Use `cobra` library for CLI command structure in the tssc-cli project
Applied to files:
cmd/tssc/main.gopkg/flags/flags.go
📚 Learning: 2025-08-20T15:48:01.881Z
Learnt from: Roming22
Repo: redhat-appstudio/tssc-cli PR: 1159
File: installer/charts/tssc-dh/Chart.yaml:5-6
Timestamp: 2025-08-20T15:48:01.881Z
Learning: In the tssc-cli project, chart version bumps in Chart.yaml files are handled at code freeze rather than immediately when appVersion changes, as part of their coordinated release process.
Applied to files:
cmd/tssc/main.go
📚 Learning: 2025-09-29T15:10:13.650Z
Learnt from: lingyzhuang
Repo: redhat-appstudio/tssc-cli PR: 1276
File: pkg/config/config.go:159-185
Timestamp: 2025-09-29T15:10:13.650Z
Learning: In the tssc-cli project, the UpdateMappingValue method in pkg/config/config.go should only update existing configuration keys and not create new ones. Adding new config entries is not allowed, so silent return when key is not found is the desired behavior.
Applied to files:
cmd/tssc/main.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to **/*.go : Use `go:embed` directive to embed `installer` directory resources (Helm charts, configurations, values.yaml.tpl) in the executable
Applied to files:
cmd/tssc/main.goMakefilepkg/framework/app.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Define commands as structs in `pkg/subcmd` that implement a common interface
Applied to files:
cmd/tssc/main.gopkg/flags/flags.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/engine/**/*.go : Use Helm SDK in `pkg/engine` for Helm engine implementation, chart installation, templating functions, and installation lifecycle management
Applied to files:
cmd/tssc/main.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Use specific `validateFlags()` methods for flag logic (e.g., mutual exclusion) rather than relying only on Cobra's built-in validators
Applied to files:
pkg/flags/flags.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Enable and follow linters: asciicheck, dogsled, dupword, errorlint, goconst, misspell, nakedret, nolintlint, revive, staticcheck, testifylint, unconvert, usestdlibvars, whitespace
Applied to files:
pkg/flags/flags.go
📚 Learning: 2025-09-29T14:49:45.227Z
Learnt from: lingyzhuang
Repo: redhat-appstudio/tssc-cli PR: 1276
File: pkg/mcptools/configtools.go:0-0
Timestamp: 2025-09-29T14:49:45.227Z
Learning: In pkg/mcptools/configtools.go, the SettingsArg and ProductsArg constants are used for Gemini input generation, where Gemini uses these parameter names to generate input and the system reads the input content by these argument names.
Applied to files:
pkg/flags/flags.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Use `make build` or `make` (default target) to build the application executable, rather than running plain `go build` manually
Applied to files:
Makefile
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Do not run plain `go build` or `go test` manually as you might miss build-time injections or prerequisites
Applied to files:
Makefile
🧬 Code graph analysis (1)
cmd/tssc/main.go (8)
pkg/framework/tarfs.go (1)
NewTarFS(11-13)installer/embed.go (1)
InstallerTarball(9-9)pkg/chartfs/overlay.go (1)
NewOverlayFS(17-22)pkg/chartfs/chartfs.go (1)
New(98-100)pkg/framework/app.go (1)
NewApp(126-145)pkg/constants/constants.go (1)
AppName(7-7)pkg/framework/options.go (5)
WithVersion(12-16)WithCommitID(19-23)WithShortDescription(26-30)WithIntegrations(40-44)WithMCPImage(47-51)pkg/subcmd/modules.go (1)
StandardModules(125-139)
🔇 Additional comments (11)
pkg/flags/flags.go (1)
66-69: LGTM! Clean parameterization of version display.The signature change from using internal constants to accepting explicit parameters supports the framework's dynamic branding goals and improves testability.
Makefile (1)
80-80: LGTM! Linker flags correctly updated to target main package variables.The ldflags now inject
versionandcommitIDinto themainpackage, consistent with the new build-time variable declarations incmd/tssc/main.go..goreleaser.yaml (1)
21-22: LGTM! GoReleaser ldflags aligned with Makefile and main.go.The ldflags correctly inject version and commit metadata into the
mainpackage using GoReleaser's template variables.pkg/constants/constants.go (1)
17-25: LGTM! Well-organized centralized filename constants.Adding
ConfigFilename,ValuesFilename, andInstructionsFilenameconstants eliminates hardcoded strings across the codebase and improves maintainability. The removal ofVersionandCommitIDcorrectly aligns with relocating build-time metadata to themainpackage.cmd/tssc/main.go (3)
14-18: LGTM! Build-time variables with sensible defaults.The package-level variables with
"v0.0.0-SNAPSHOT"and""defaults ensure the application works during development even without linker injection, while being overridden during release builds.
21-35: LGTM! Clean overlay filesystem initialization.The approach of creating an overlay filesystem with the embedded tarball as the base layer and the current working directory as the local overlay is well-structured. Error handling is properly implemented for both
NewTarFSandos.Getwd().
47-63: LGTM! Well-structured application initialization.The framework.NewApp call with functional options provides clean dependency injection. The use of
constants.AppName,subcmd.StandardModules(), and explicit version/commit configuration aligns with the framework's design goals.pkg/framework/app.go (4)
18-35: LGTM! Well-designed App struct with clear separation of concerns.The struct cleanly separates public metadata fields (
Name,Version,CommitID,Short,Long,ChartFS) from private implementation details. This design supports the framework's goal of exposing a public API while encapsulating internals.
96-99: Good defensive validation for required MCP image configuration.The explicit error message clearly guides users to use
WithMCPImage()when configuring the app, preventing cryptic failures downstream.
124-145: LGTM! Clean constructor with functional options pattern.The
NewAppconstructor properly applies options before initializing dependencies that require them (Kube client, root command setup). The error propagation fromsetupRootCmdensures configuration failures are surfaced to the caller.
74-74: The logger implementation already respects user-specified log levels correctly. TheLogLevelfield is passed as a pointer (*slog.Level) toslog.HandlerOptions, and the slog handler evaluates this level dynamically for each log statement. When command-line flags are parsed duringExecute(), the pointer is updated viaLogLevelValue.Set(), and subsequent logging operations will respect the user-specified log level. If module loading during initialization needs to respect user-specified levels, the logger will reflect those changes for any logging that occurs after flag parsing.Likely an incorrect or invalid review comment.
|
@otaviof: This pull request references RHTAP-6103 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In @pkg/resolver/dependency.go:
- Around line 108-110: The constructors NewDependency and
NewDependencyWithNamespace currently accept appCtx without validation which can
lead to panics later; add an explicit nil check at the start of both functions
and handle it immediately (e.g., panic or call log.Fatalf) with a clear message
like "appCtx is required and must not be nil" so the failure surfaces at
construction time; update both NewDependency(hc *chart.Chart, appCtx
*api.AppContext) and NewDependencyWithNamespace(...) to include this check and
message, or alternatively document in their comments that appCtx is required and
must never be nil if you prefer not to change runtime behavior.
In @pkg/subcmd/mcpserver.go:
- Around line 89-117: The constructor NewMCPServer fails to initialize the
MCPServer.appName field, so Run() ends up passing an empty appName to
mcpserver.NewMCPServer; update NewMCPServer to set the appName field on the
returned MCPServer by reading it from the provided app context (e.g.,
appCtx.AppName or the appropriate getter on api.AppContext) so that
MCPServer.appName is populated before PersistentFlags and return.
🧹 Nitpick comments (9)
pkg/framework/constants.go (1)
3-15: Duplicate constant definitions across packages.These three constants (
ConfigFilename,ValuesFilename,InstructionsFilename) are identically defined in:
pkg/framework/constants.go(this file)pkg/api/constants.gopkg/constants/constants.goThis duplication violates DRY and risks divergence during maintenance. Consider consolidating to a single source of truth (likely
pkg/api/constants.gosince it's the shared API package) and having other packages import from there.pkg/api/constants.go (1)
1-15: Consider making this the single source of truth.Since
pkg/apiis the shared API package for external consumers, this is the appropriate location for these framework contract constants. However, identical definitions exist inpkg/framework/constants.goandpkg/constants/constants.go.Recommend keeping this file and having the other packages import from here, or removing duplicates entirely if they're not needed.
pkg/resolver/annotations.go (1)
21-23: Nil pointer dereference risk: Consider adding validation ifappCtxis passed directly to annotation functions outside this resolver package.The annotation helper functions call
appCtx.RepoURI()without nil-checking. While the current usage pattern (within Dependency methods) ensuresappCtxis always non-nil, consider adding a defensive guard if these functions are or will be part of a public API:♻️ Suggested defensive check
func AnnotationProductName(appCtx *api.AppContext) string { + if appCtx == nil { + return "" + } return fmt.Sprintf("%s/%s", appCtx.RepoURI(), suffixProductName) }Alternatively, document the precondition that
appCtxmust not be nil.pkg/subcmd/installer.go (1)
217-225: Consider whether unusedappCtxparameter should be stored.The
appCtxparameter is accepted byNewInstallerbut is not stored in the struct or used anywhere. While this maintains a consistent constructor signature across subcommands, consider whetherInstallermight benefit from accessing app metadata (e.g., for display in--listoutput).If intentionally unused for consistency, this is acceptable. If it should be used, add an
appCtxfield to the struct.cmd/tssc/main.go (1)
45-51: Consider using a constant for the MCP image base URL.The MCP image base URL is hardcoded as a string. Consider extracting it to a constant for maintainability and to avoid typos in future modifications.
♻️ Suggested refactor
+const mcpImageBase = "quay.io/redhat-user-workloads/rhtap-shared-team-tenant/tssc-cli" + // TSSC-specific MCP server image based on build-time commit ID. -mcpImage := "quay.io/redhat-user-workloads/rhtap-shared-team-tenant/tssc-cli" if commitID == "" { - mcpImage = fmt.Sprintf("%s:latest", mcpImage) + mcpImage := fmt.Sprintf("%s:latest", mcpImageBase) } else { - mcpImage = fmt.Sprintf("%s:%s", mcpImage, commitID) + mcpImage := fmt.Sprintf("%s:%s", mcpImageBase, commitID) }pkg/subcmd/integration_gitlab.go (1)
6-7: Minor: Blank line in import block.There's a blank line between the
apiimport and subsequent imports. While not incorrect, Go convention typically groups standard library imports separately from third-party imports without extra blank lines within groups.♻️ Suggested import grouping
import ( "log/slog" "github.com/redhat-appstudio/tssc-cli/pkg/api" - "github.com/redhat-appstudio/tssc-cli/pkg/config" "github.com/redhat-appstudio/tssc-cli/pkg/integration" "github.com/redhat-appstudio/tssc-cli/pkg/k8s"pkg/subcmd/integration_azure.go (1)
6-7: Minor: Same import formatting as GitLab integration.Same observation as
integration_gitlab.go— the blank line between imports is inconsistent with typical Go style.pkg/subcmd/mcptools.go (1)
83-91: Tool ordering in return slice.The tools are returned in a specific order. If this ordering has semantic meaning (e.g., initialization order), consider documenting it.
pkg/framework/app.go (1)
95-98: Consider validating required MCP image earlier in initialization.The MCP image is validated late in
setupRootCmd(), which meansNewApp()could successfully return anAppinstance that will fail whensetupRootCmd()is called internally. Since the error message states the image is required viaWithMCPImage(), consider either:
- Validating immediately after applying functional options in
NewApp()(line 169)- Documenting in the
NewApp()godoc thatWithMCPImage()is mandatoryThis would fail faster and provide clearer error messages to framework consumers.
♻️ Option 1: Validate after applying options in NewApp
for _, opt := range opts { opt(app) } + + // Validate MCP image is configured. + if app.mcpImage == "" { + return nil, fmt.Errorf( + "MCP server image not configured: use WithMCPImage() option") + } // Initialize Kube client with flags app.kube = k8s.NewKube(app.flags)Then remove the validation from
setupRootCmd()(lines 95-98).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (43)
cmd/tssc/main.gopkg/api/appcontext.gopkg/api/constants.gopkg/api/types.gopkg/chartfs/chartfs_test.gopkg/constants/constants.gopkg/framework/app.gopkg/framework/constants.gopkg/framework/options.gopkg/hooks/hooks_test.gopkg/installer/job.gopkg/mcptools/configtools.gopkg/mcptools/context.gopkg/mcptools/notestool.gopkg/resolver/annotations.gopkg/resolver/collection.gopkg/resolver/collection_test.gopkg/resolver/dependency.gopkg/resolver/dependency_test.gopkg/resolver/resolver_test.gopkg/resolver/topology_test.gopkg/resolver/topologybuilder.gopkg/subcmd/config.gopkg/subcmd/config_helper.gopkg/subcmd/deploy.gopkg/subcmd/installer.gopkg/subcmd/integration.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_artifactory.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_github.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_jenkins.gopkg/subcmd/integration_nexus.gopkg/subcmd/integration_quay.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/integration_trustification.gopkg/subcmd/mcpserver.gopkg/subcmd/mcptools.gopkg/subcmd/modules.gopkg/subcmd/template.gopkg/subcmd/topology.go
🚧 Files skipped from review as they are similar to previous changes (7)
- pkg/subcmd/integration_bitbucket.go
- pkg/framework/options.go
- pkg/subcmd/integration_trustedartifactsigner.go
- pkg/subcmd/integration_jenkins.go
- pkg/subcmd/modules.go
- pkg/resolver/resolver_test.go
- pkg/hooks/hooks_test.go
🧰 Additional context used
📓 Path-based instructions (6)
**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Never hardcode Gemini API keys in source code; use environment variables or secure configuration management
Files:
pkg/framework/constants.gopkg/resolver/annotations.gopkg/api/constants.gopkg/constants/constants.gopkg/subcmd/integration_nexus.gopkg/subcmd/template.gopkg/subcmd/integration_gitlab.gopkg/subcmd/config_helper.gopkg/resolver/collection.gopkg/subcmd/integration_artifactory.gocmd/tssc/main.gopkg/subcmd/integration_trustification.gopkg/subcmd/installer.gopkg/api/appcontext.gopkg/subcmd/integration_github.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/chartfs/chartfs_test.gopkg/framework/app.gopkg/subcmd/integration_acs.gopkg/mcptools/context.gopkg/subcmd/integration_azure.gopkg/subcmd/config.gopkg/subcmd/mcptools.gopkg/resolver/dependency.gopkg/subcmd/mcpserver.gopkg/resolver/topology_test.gopkg/resolver/collection_test.gopkg/resolver/dependency_test.gopkg/mcptools/configtools.gopkg/api/types.gopkg/resolver/topologybuilder.gopkg/installer/job.gopkg/mcptools/notestool.gopkg/subcmd/topology.gopkg/subcmd/integration_quay.go
**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Use
go:embeddirective to embedinstallerdirectory resources (Helm charts, configurations, values.yaml.tpl) in the executable
Files:
pkg/framework/constants.gopkg/resolver/annotations.gopkg/api/constants.gopkg/constants/constants.gopkg/subcmd/integration_nexus.gopkg/subcmd/template.gopkg/subcmd/integration_gitlab.gopkg/subcmd/config_helper.gopkg/resolver/collection.gopkg/subcmd/integration_artifactory.gocmd/tssc/main.gopkg/subcmd/integration_trustification.gopkg/subcmd/installer.gopkg/api/appcontext.gopkg/subcmd/integration_github.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/chartfs/chartfs_test.gopkg/framework/app.gopkg/subcmd/integration_acs.gopkg/mcptools/context.gopkg/subcmd/integration_azure.gopkg/subcmd/config.gopkg/subcmd/mcptools.gopkg/resolver/dependency.gopkg/subcmd/mcpserver.gopkg/resolver/topology_test.gopkg/resolver/collection_test.gopkg/resolver/dependency_test.gopkg/mcptools/configtools.gopkg/api/types.gopkg/resolver/topologybuilder.gopkg/installer/job.gopkg/mcptools/notestool.gopkg/subcmd/topology.gopkg/subcmd/integration_quay.go
pkg/resolver/**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Use
pkg/resolverto define the dependency topology, including the sequence of Helm Charts and relationships between them and required integrations
Files:
pkg/resolver/annotations.gopkg/resolver/collection.gopkg/resolver/dependency.gopkg/resolver/topology_test.gopkg/resolver/collection_test.gopkg/resolver/dependency_test.gopkg/resolver/topologybuilder.go
pkg/subcmd/**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
pkg/subcmd/**/*.go: Usecobralibrary for CLI command structure in the tssc-cli project
Define commands as structs inpkg/subcmdthat implement a common interface
Use specificvalidateFlags()methods for flag logic (e.g., mutual exclusion) rather than relying only on Cobra's built-in validators
Inject dependencies likek8s.Kubeandchartfs.ChartFSvia constructors in command structs
Files:
pkg/subcmd/integration_nexus.gopkg/subcmd/template.gopkg/subcmd/integration_gitlab.gopkg/subcmd/config_helper.gopkg/subcmd/integration_artifactory.gopkg/subcmd/integration_trustification.gopkg/subcmd/installer.gopkg/subcmd/integration_github.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_azure.gopkg/subcmd/config.gopkg/subcmd/mcptools.gopkg/subcmd/mcpserver.gopkg/subcmd/topology.gopkg/subcmd/integration_quay.go
**/*_test.go
📄 CodeRabbit inference engine (GEMINI.md)
Use the standard
testingpackage withgithub.com/onsi/gomegaassertion library for tests
Files:
pkg/chartfs/chartfs_test.gopkg/resolver/topology_test.gopkg/resolver/collection_test.gopkg/resolver/dependency_test.go
pkg/chartfs/**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Implement
io.FScompatible abstraction inpkg/chartfsto provide access to embedded installer directory resources
Files:
pkg/chartfs/chartfs_test.go
🧠 Learnings (23)
📓 Common learnings
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Inject dependencies like `k8s.Kube` and `chartfs.ChartFS` via constructors in command structs
Learnt from: Roming22
Repo: redhat-appstudio/tssc-cli PR: 1159
File: installer/charts/tssc-dh/Chart.yaml:5-6
Timestamp: 2025-08-20T15:48:01.881Z
Learning: In the tssc-cli project, chart version bumps in Chart.yaml files are handled at code freeze rather than immediately when appVersion changes, as part of their coordinated release process.
📚 Learning: 2025-09-29T14:49:45.227Z
Learnt from: lingyzhuang
Repo: redhat-appstudio/tssc-cli PR: 1276
File: pkg/mcptools/configtools.go:0-0
Timestamp: 2025-09-29T14:49:45.227Z
Learning: In pkg/mcptools/configtools.go, the SettingsArg and ProductsArg constants are used for Gemini input generation, where Gemini uses these parameter names to generate input and the system reads the input content by these argument names.
Applied to files:
pkg/api/constants.gopkg/constants/constants.gopkg/mcptools/configtools.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/integration/**/*.go : Define integrations in `pkg/integration` to connect to external services like GitHub, Quay, etc.
Applied to files:
pkg/subcmd/integration_nexus.gopkg/subcmd/template.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_artifactory.gopkg/subcmd/integration_trustification.gopkg/api/appcontext.gopkg/subcmd/integration_github.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_azure.gopkg/subcmd/config.gopkg/api/types.gopkg/resolver/topologybuilder.gopkg/mcptools/notestool.gopkg/subcmd/topology.gopkg/subcmd/integration_quay.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Inject dependencies like `k8s.Kube` and `chartfs.ChartFS` via constructors in command structs
Applied to files:
pkg/subcmd/integration_nexus.gopkg/subcmd/template.gopkg/subcmd/integration_gitlab.gopkg/subcmd/config_helper.gopkg/resolver/collection.gopkg/subcmd/integration_artifactory.gocmd/tssc/main.gopkg/subcmd/integration_trustification.gopkg/subcmd/installer.gopkg/subcmd/integration_github.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/chartfs/chartfs_test.gopkg/framework/app.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_azure.gopkg/subcmd/config.gopkg/subcmd/mcptools.gopkg/resolver/dependency.gopkg/subcmd/mcpserver.gopkg/resolver/topology_test.gopkg/resolver/collection_test.gopkg/resolver/dependency_test.gopkg/resolver/topologybuilder.gopkg/installer/job.gopkg/mcptools/notestool.gopkg/subcmd/topology.gopkg/subcmd/integration_quay.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Define commands as structs in `pkg/subcmd` that implement a common interface
Applied to files:
pkg/subcmd/integration_nexus.gopkg/subcmd/template.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_artifactory.gocmd/tssc/main.gopkg/subcmd/integration_trustification.gopkg/subcmd/installer.gopkg/subcmd/integration_github.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_azure.gopkg/subcmd/config.gopkg/subcmd/mcptools.gopkg/subcmd/mcpserver.gopkg/api/types.gopkg/mcptools/notestool.gopkg/subcmd/integration_quay.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Use `cobra` library for CLI command structure in the tssc-cli project
Applied to files:
pkg/subcmd/integration_nexus.gopkg/subcmd/template.gopkg/subcmd/integration_gitlab.gopkg/subcmd/config_helper.gopkg/resolver/collection.gopkg/subcmd/integration_artifactory.gocmd/tssc/main.gopkg/subcmd/integration_trustification.gopkg/subcmd/installer.gopkg/subcmd/integration_github.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_azure.gopkg/subcmd/config.gopkg/subcmd/mcptools.gopkg/resolver/topologybuilder.gopkg/installer/job.gopkg/mcptools/notestool.gopkg/subcmd/topology.gopkg/subcmd/integration_quay.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Define interface definition at the top of service files, followed by service struct and implementation
Applied to files:
pkg/subcmd/integration_nexus.gopkg/subcmd/template.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_artifactory.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_github.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_azure.gopkg/subcmd/config.gopkg/resolver/topologybuilder.gopkg/installer/job.gopkg/subcmd/topology.gopkg/subcmd/integration_quay.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Enable and follow linters: asciicheck, dogsled, dupword, errorlint, goconst, misspell, nakedret, nolintlint, revive, staticcheck, testifylint, unconvert, usestdlibvars, whitespace
Applied to files:
pkg/subcmd/integration_nexus.gopkg/subcmd/template.gopkg/subcmd/integration_gitlab.gopkg/resolver/collection.gopkg/subcmd/integration_artifactory.gopkg/subcmd/integration_trustification.gopkg/subcmd/installer.gopkg/subcmd/integration_github.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_azure.gopkg/subcmd/config.gopkg/resolver/topologybuilder.gopkg/installer/job.gopkg/mcptools/notestool.gopkg/subcmd/topology.gopkg/subcmd/integration_quay.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/engine/**/*.go : Use Helm SDK in `pkg/engine` for Helm engine implementation, chart installation, templating functions, and installation lifecycle management
Applied to files:
pkg/subcmd/template.gopkg/resolver/collection.gocmd/tssc/main.gopkg/subcmd/installer.gopkg/subcmd/integration_github.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/framework/app.gopkg/subcmd/config.gopkg/resolver/dependency_test.gopkg/resolver/topologybuilder.gopkg/mcptools/notestool.gopkg/subcmd/topology.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/chartfs/**/*.go : Implement `io.FS` compatible abstraction in `pkg/chartfs` to provide access to embedded installer directory resources
Applied to files:
pkg/subcmd/template.gopkg/resolver/collection.gocmd/tssc/main.gopkg/subcmd/installer.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/chartfs/chartfs_test.gopkg/framework/app.gopkg/subcmd/config.gopkg/resolver/topology_test.gopkg/resolver/collection_test.gopkg/resolver/dependency_test.gopkg/resolver/topologybuilder.gopkg/subcmd/topology.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*_test.go : All tests must use the `testing` package with `testify/assert` library
Applied to files:
pkg/subcmd/template.gopkg/subcmd/integration_github.gopkg/chartfs/chartfs_test.gopkg/subcmd/config.gopkg/resolver/topology_test.gopkg/resolver/collection_test.gopkg/resolver/dependency_test.gopkg/resolver/topologybuilder.gopkg/subcmd/topology.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/resolver/**/*.go : Use `pkg/resolver` to define the dependency topology, including the sequence of Helm Charts and relationships between them and required integrations
Applied to files:
pkg/subcmd/template.gopkg/resolver/collection.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/subcmd/config.gopkg/resolver/dependency.gopkg/resolver/topology_test.gopkg/resolver/collection_test.gopkg/resolver/dependency_test.gopkg/resolver/topologybuilder.gopkg/subcmd/topology.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Regenerate mocks after modifying existing interfaces
Applied to files:
pkg/subcmd/integration_gitlab.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Struct fields and methods should be ordered to match the GitLab API documentation
Applied to files:
pkg/subcmd/integration_gitlab.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Do not use `interface{}`, use the `any` alias instead
Applied to files:
pkg/subcmd/integration_gitlab.gopkg/subcmd/integration_github.gopkg/installer/job.go
📚 Learning: 2025-08-20T15:48:01.881Z
Learnt from: Roming22
Repo: redhat-appstudio/tssc-cli PR: 1159
File: installer/charts/tssc-dh/Chart.yaml:5-6
Timestamp: 2025-08-20T15:48:01.881Z
Learning: In the tssc-cli project, chart version bumps in Chart.yaml files are handled at code freeze rather than immediately when appVersion changes, as part of their coordinated release process.
Applied to files:
cmd/tssc/main.go
📚 Learning: 2025-09-29T15:10:13.650Z
Learnt from: lingyzhuang
Repo: redhat-appstudio/tssc-cli PR: 1276
File: pkg/config/config.go:159-185
Timestamp: 2025-09-29T15:10:13.650Z
Learning: In the tssc-cli project, the UpdateMappingValue method in pkg/config/config.go should only update existing configuration keys and not create new ones. Adding new config entries is not allowed, so silent return when key is not found is the desired behavior.
Applied to files:
cmd/tssc/main.gopkg/mcptools/configtools.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to **/*.go : Use `go:embed` directive to embed `installer` directory resources (Helm charts, configurations, values.yaml.tpl) in the executable
Applied to files:
cmd/tssc/main.gopkg/subcmd/installer.gopkg/subcmd/deploy.gopkg/framework/app.gopkg/mcptools/notestool.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Use specific `validateFlags()` methods for flag logic (e.g., mutual exclusion) rather than relying only on Cobra's built-in validators
Applied to files:
pkg/subcmd/installer.go
📚 Learning: 2025-08-27T18:30:02.411Z
Learnt from: Roming22
Repo: redhat-appstudio/tssc-cli PR: 1190
File: pkg/resolver/resolver_test.go:52-67
Timestamp: 2025-08-27T18:30:02.411Z
Learning: In tssc-cli, there is a distinction between deployment namespace (where resources are deployed, referenced in values.yaml.tpl) and chart registration namespace (where Helm charts are registered, tested in resolver tests). These are different concepts and may use different namespace values.
Applied to files:
pkg/subcmd/deploy.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to **/*_test.go : Use the standard `testing` package with `github.com/onsi/gomega` assertion library for tests
Applied to files:
pkg/chartfs/chartfs_test.gopkg/resolver/topology_test.gopkg/resolver/collection_test.gopkg/resolver/dependency_test.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*_test.go : When fixing bugs or creating new features, ensure new test scenarios are added to cover the new logic
Applied to files:
pkg/resolver/collection_test.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Do not use `int`, use `int64` instead (applies to both slices and maps)
Applied to files:
pkg/installer/job.go
🧬 Code graph analysis (22)
pkg/resolver/annotations.go (1)
pkg/api/appcontext.go (1)
AppContext(13-22)
pkg/subcmd/integration_nexus.go (2)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/template.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/api/subcommand.go (1)
SubCommand(9-22)pkg/resolver/dependency.go (1)
NewDependencyWithNamespace(114-118)
pkg/subcmd/config_helper.go (1)
pkg/api/appcontext.go (1)
AppContext(13-22)
pkg/subcmd/integration_artifactory.go (2)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/integration_trustification.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/subcmd/config.go (1)
Config(20-36)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/deploy.go (6)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/subcmd/config.go (1)
Config(20-36)pkg/chartfs/chartfs.go (1)
ChartFS(15-17)pkg/integrations/manager.go (1)
Manager(20-23)pkg/resolver/topologybuilder.go (1)
TopologyBuilder(15-19)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/integration.go (4)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/integrations/manager.go (2)
Manager(20-23)IntegrationName(15-15)pkg/resolver/collection.go (1)
NewCollection(100-130)pkg/api/subcommand.go (1)
NewRunner(36-47)
pkg/chartfs/chartfs_test.go (1)
pkg/chartfs/chartfs.go (1)
New(98-100)
pkg/subcmd/integration_acs.go (2)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/mcptools/context.go (5)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/flags/flags.go (1)
Flags(17-24)pkg/chartfs/chartfs.go (1)
ChartFS(15-17)pkg/k8s/kube.go (1)
Kube(21-23)pkg/integrations/manager.go (1)
Manager(20-23)
pkg/subcmd/integration_azure.go (5)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/subcmd/config.go (1)
Config(20-36)pkg/k8s/kube.go (1)
Kube(21-23)pkg/integration/integration.go (1)
Integration(19-26)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/config.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/api/subcommand.go (1)
SubCommand(9-22)pkg/resolver/collection.go (1)
NewCollection(100-130)
pkg/subcmd/mcpserver.go (5)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/mcptools/context.go (2)
MCPToolsBuilder(53-53)NewMCPToolsContext(31-49)pkg/api/subcommand.go (1)
SubCommand(9-22)pkg/framework/mcpserver/mcpserver.go (2)
MCPServer(9-11)NewMCPServer(23-32)pkg/constants/constants.go (1)
InstructionsFilename(14-14)
pkg/resolver/collection_test.go (3)
pkg/chartfs/chartfs.go (1)
New(98-100)pkg/api/appcontext.go (1)
NewAppContext(84-99)pkg/resolver/collection.go (1)
NewCollection(100-130)
pkg/resolver/dependency_test.go (3)
pkg/chartfs/chartfs.go (1)
New(98-100)pkg/api/appcontext.go (1)
NewAppContext(84-99)pkg/resolver/dependency.go (1)
NewDependency(108-110)
pkg/mcptools/configtools.go (6)
pkg/chartfs/chartfs.go (1)
ChartFS(15-17)pkg/config/manager.go (2)
ConfigMapManager(17-19)Name(25-25)pkg/k8s/kube.go (1)
Kube(21-23)pkg/subcmd/config.go (1)
Config(20-36)pkg/config/config.go (2)
Config(30-36)NewConfigDefault(305-307)pkg/api/appcontext.go (1)
AppContext(13-22)
pkg/api/types.go (4)
pkg/k8s/kube.go (1)
Kube(21-23)pkg/api/appcontext.go (1)
AppContext(13-22)pkg/integration/integration.go (1)
Integration(19-26)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/resolver/topologybuilder.go (2)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/resolver/collection.go (1)
NewCollection(100-130)
pkg/mcptools/notestool.go (5)
pkg/flags/flags.go (1)
Flags(17-24)pkg/k8s/kube.go (1)
Kube(21-23)pkg/config/manager.go (1)
ConfigMapManager(17-19)pkg/resolver/topologybuilder.go (1)
TopologyBuilder(15-19)pkg/installer/job.go (1)
Job(22-27)
pkg/subcmd/topology.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/resolver/collection.go (2)
Collection(14-16)NewCollection(100-130)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/integration_quay.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/subcmd/config.go (1)
Config(20-36)pkg/api/subcommand.go (1)
SubCommand(9-22)
🔇 Additional comments (59)
pkg/resolver/annotations.go (1)
9-17: LGTM on suffix constants.The unexported suffix constants provide good encapsulation while enabling consistent annotation key construction.
pkg/subcmd/config_helper.go (1)
14-30: LGTM on AppContext integration.The signature update properly injects
appCtxas a dependency, and the dynamicappCtx.Nameusage in error messages enables proper branding for different installer consumers. This aligns with the coding guidelines for dependency injection inpkg/subcmd.Note: Consider adding a nil-check for
appCtxto prevent panics if called incorrectly, consistent with defensive patterns elsewhere.pkg/subcmd/integration_nexus.go (2)
17-26: LGTM on struct and interface update.The struct correctly adds
appCtxfield and implementsapi.SubCommand. Dependencies (appCtx,logger,kube,integration) are properly injected via the constructor, following the coding guidelines forpkg/subcmd.
60-81: LGTM on constructor.The constructor properly accepts and wires
appCtxthrough to the struct instance. The pattern aligns with the broader refactoring to AppContext-driven architecture and follows dependency injection guidelines.pkg/resolver/collection.go (1)
100-106: LGTM on AppContext propagation.The signature change correctly threads
appCtxthrough toNewDependencyfor annotation key construction. Since the Collection doesn't need to retainappCtxafter construction, not storing it is appropriate.One consideration: if
appCtxisnil, it will propagate toNewDependencyand eventually cause panics in the annotation functions. Ensure callers always provide a validAppContext.pkg/subcmd/config.go (4)
20-26: LGTM! AppContext integration follows the dependency injection pattern.The
Configstruct correctly addsappCtxfield and the interface assertion is updated toapi.SubCommand. This aligns with the coding guidelines for injecting dependencies via constructors.Also applies to: 38-38
84-86: Good use of AppContext for namespace default.Using
c.appCtx.Namespaceas the default value for the namespace flag properly centralizes configuration, replacing the previous hardcoded constant.
178-182: Correct propagation of appCtx to resolver.NewCollection.The
appCtxis properly passed through toresolver.NewCollection, maintaining the context-aware architecture throughout the dependency resolution flow.
284-308: Constructor properly injects all dependencies including appCtx.The
NewConfigfunction follows the established pattern of dependency injection via constructors and correctly returnsapi.SubCommand. As per coding guidelines, dependencies likek8s.Kubeandchartfs.ChartFSare injected via the constructor.pkg/mcptools/context.go (3)
14-27: Well-designed context struct with clear documentation.The
MCPToolsContextstruct properly encapsulates all dependencies needed for MCP tool creation. The documentation clearly explains the critical constraint about STDIO protocol compatibility.
29-49: Constructor correctly enforces MCP STDIO protocol safety.The use of
f.GetLogger(io.Discard)ensures logs don't corrupt MCP protocol messages. The inline comment on line 41 reinforces this critical requirement for future maintainers.
51-53: Clean builder pattern type definition.The
MCPToolsBuilderfunction type enables consumers to provide custom tool builders while maintaining a consistent interface.pkg/resolver/dependency_test.go (1)
16-22: Test correctly updated for new API signatures.The test properly adapts to:
- The new
chartfs.New(fs.FS)constructor that returns*ChartFSdirectly- The
api.NewAppContextconstructor for creating app context- The updated
NewDependencysignature requiringappCtxAs per coding guidelines, the test uses the standard
testingpackage withgomegaassertion library.pkg/subcmd/installer.go (1)
29-29: Interface implementation updated correctly.The
Installerstruct now properly implementsapi.SubCommandwith the correct method signatures.Also applies to: 60-63
pkg/chartfs/chartfs_test.go (2)
13-14: Test correctly updated for new ChartFS API.The test properly uses the new
New(fs.FS)constructor. The direct return of*ChartFS(without error) simplifies test setup.
16-20: Path correctly adjusted for new filesystem root.The path change from
"installer/values.yaml.tpl"to"values.yaml.tpl"is correct sinceos.DirFS("../../installer")already roots the filesystem at the installer directory. As per coding guidelines, this implements anio.FScompatible abstraction.pkg/resolver/collection_test.go (1)
16-24: Test correctly updated for new API signatures.The test properly adapts to:
- The new
chartfs.New(fs.FS)constructor- The
api.NewAppContextconstructor- The updated
NewCollection(appCtx, charts)signatureAs per coding guidelines, this test correctly uses
pkg/resolverfor dependency topology and the standardtestingpackage withgomega.cmd/tssc/main.go (3)
21-35: Proper error handling for filesystem initialization.Good error handling for both
NewTarFSandos.Getwd()operations. The overlay filesystem creation cleanly combines embedded tarball contents with the local filesystem for customization support.
37-43: AppContext properly configured with build-time metadata.The
api.NewAppContextusage correctly injects build-time variables (version,commitID) and provides a meaningful short description for CLI help text.
53-67: Clean application lifecycle with proper error handling.The
framework.NewAppcall properly injects all dependencies and the error handling paths are explicit. The application runs cleanly with appropriate exit codes on failure.pkg/subcmd/integration_artifactory.go (1)
6-7: LGTM! Consistent migration to AppContext-driven architecture.The changes correctly:
- Add the
apipackage import andappCtxfield- Update the interface assertion to
api.SubCommand- Wire
appCtxthrough the constructor and intobootstrapConfigThis aligns with the PR's goal of centralizing application metadata in
AppContext. Based on learnings, the dependency injection pattern via constructor is correctly followed.Also applies to: 19-19, 29-29, 47-47, 64-64, 77-77
pkg/resolver/topology_test.go (1)
16-19: LGTM! Test correctly updated for new API signatures.The test properly:
- Uses
os.DirFSwith thechartfs.Newconstructor- Creates an
AppContextviaapi.NewAppContext("tssc")- Passes
appCtxto allNewDependencyWithNamespacecallsAs per coding guidelines, the test uses the standard
testingpackage withgithub.com/onsi/gomegaassertion library.pkg/resolver/topologybuilder.go (1)
56-76: LGTM! AppContext correctly propagated to collection creation.The
TopologyBuilderconstructor correctly:
- Accepts
appCtxas a parameter- Passes it through to
NewCollection(appCtx, charts)during initializationThe design choice to not store
appCtxin the struct is appropriate since it's only needed during collection creation. As per coding guidelines, this file correctly defines the dependency topology.pkg/subcmd/integration_acs.go (1)
6-7: LGTM! Consistent with other integration subcommand migrations.The changes mirror the pattern established in
integration_artifactory.goand other integration commands:
- Import
apipackage and addappCtxfield- Assert
api.SubCommandinterface compliance- Wire
appCtxthrough constructor andbootstrapConfigBased on learnings, dependencies are correctly injected via the constructor.
Also applies to: 19-19, 26-26, 44-44, 61-61, 74-74
pkg/subcmd/template.go (1)
7-7: LGTM! AppContext correctly integrated into template subcommand.The
Templatesubcommand properly:
- Adds
appCtxfield and imports theapipackage- Updates interface assertion to
api.SubCommand- Propagates
appCtxto bothresolver.NewDependencyWithNamespaceandbootstrapConfig- Accepts
appCtxin the constructor and wires it to the structBased on learnings, dependencies like
chartfs.ChartFSand the newAppContextare correctly injected via the constructor.Also applies to: 23-23, 38-38, 87-87, 89-89, 151-151, 166-166
pkg/subcmd/integration_quay.go (1)
6-7: LGTM! Consistent migration pattern for Quay integration.The changes follow the same pattern as other integration subcommands, correctly implementing the
api.SubCommandinterface and wiringappCtxthrough the constructor andbootstrapConfig.Also applies to: 19-19, 26-26, 56-56, 73-73, 86-86
pkg/subcmd/integration_trustification.go (1)
6-7: LGTM! Completes the consistent migration across integration subcommands.The Trustification integration follows the same pattern as all other integration subcommands in this PR. The
api.SubCommandinterface is correctly implemented, andappCtxis properly wired through the constructor andbootstrapConfig.Also applies to: 19-19, 26-26, 44-44, 62-62, 75-75
pkg/resolver/dependency.go (1)
15-19: AppContext integration looks correct.The struct now properly carries the application context for dynamic annotation key resolution. The field ordering is logical with related Helm chart data grouped together.
pkg/subcmd/topology.go (3)
18-27: Struct changes align with framework architecture.The addition of
appCtxand compliance withapi.SubCommandis consistent with the broader refactoring. Dependencies (cfs,kube) are properly injected via the constructor as per coding guidelines.
50-65: AppContext propagation is correctly implemented.The
Completemethod properly passesappCtxto bothresolver.NewCollectionandbootstrapConfig, aligning with the new signatures defined in the relevant code snippets.
86-105: Constructor follows dependency injection pattern.The constructor correctly accepts all dependencies including the new
appCtxparameter and initializes all struct fields. This aligns with the coding guidelines forpkg/subcmd/**/*.go. Based on learnings, dependencies likek8s.Kubeandchartfs.ChartFSare injected via constructors.pkg/subcmd/integration.go (3)
16-22: Dynamic module-based integration registration.The function now accepts a
managerparameter enabling dynamic registration of integration modules. This is a cleaner architecture than hardcoded integration lists.
26-40: AppContext propagation in PersistentPostRunE.The
bootstrapConfigandresolver.NewCollectioncalls correctly receiveappCtx, ensuring consistent application context throughout the post-run configuration update flow.
76-80: No action needed. Themod.Command()function returns onlySubCommand(not an error tuple), as defined inpkg/api/types.go. The code correctly handles the single return value.Likely an incorrect or invalid review comment.
pkg/subcmd/integration_gitlab.go (2)
17-26: Struct and interface changes are consistent.The
IntegrationGitLabstruct now includesappCtxand implementsapi.SubCommand. This aligns with the centralized SubCommand interface pattern established in the PR.
60-81: Constructor follows the established pattern.Dependencies are properly injected via constructor parameters, and
appCtxis correctly assigned to the struct field. This matches the coding guidelines forpkg/subcmd/**/*.go.pkg/subcmd/integration_azure.go (1)
17-26: Changes are consistent with the integration pattern.The Azure integration follows the same pattern as GitLab and other integration subcommands. The
appCtxis properly stored and passed tobootstrapConfig. Constructor injects dependencies correctly per coding guidelines.Also applies to: 40-45, 59-80
pkg/subcmd/mcptools.go (3)
10-15: Clean builder pattern for MCP tools.The
StandardMCPToolsBuilderfunction returns the internal builder, providing a nice separation between the public API and implementation.
18-44: Shared dependencies created efficiently.The builder creates shared dependencies (
cm,tb) once and reuses them across multiple tools, avoiding redundant instantiations. Error handling forNewConfigToolsandNewTopologyBuilderis correctly implemented.
52-62: Integration tools construction.The
NewIntegrationcall creates a cobra.Command for metadata introspection. This pattern works, though it's creating a command primarily to extract metadata rather than execute it.pkg/installer/job.go (3)
22-27: Repository-aware labeling improves isolation.Adding
repoURIenables per-repository job isolation, which is essential when multiple installations might coexist in a cluster.
56-58: Consistent use of LabelSelector throughout.All label usages now consistently call
j.LabelSelector(), ensuring label consistency across job creation, lookup, and log following. This is a good refactoring that centralizes the label logic.Also applies to: 224-224, 229-229, 260-260
301-308: Constructor properly extracts values from AppContext.The constructor correctly sources
appNameandrepoURIfromappCtx, aligning with the centralized metadata approach of this PR.pkg/subcmd/integration_github.go (1)
7-7: LGTM! AppContext integration is clean and consistent.The refactoring properly threads
AppContextthrough the struct, constructor, and methods. The interface change fromInterfacetoapi.SubCommandaligns with the broader API refactoring, andbootstrapConfignow correctly receivesappCtxfor context-aware configuration loading.Based on learnings, dependencies are properly injected via the constructor.
Also applies to: 20-20, 30-30, 53-53, 87-87, 96-110
pkg/api/types.go (1)
10-28: Well-designed integration module contract.The
IntegrationModuletype cleanly separates business logic initialization (Init) from CLI command creation (Command), enabling the pluggable integration pattern described in the PR objectives. The function-field approach provides flexibility for dynamic module registration while maintaining type safety.pkg/subcmd/deploy.go (1)
9-9: LGTM! Refactoring to AppContext and integration manager is consistent.The changes properly integrate
AppContextand the newintegrations.Managerthroughout the deploy command. Dependencies are correctly injected via the constructor, and the topology builder and config bootstrap now receiveappCtxfor context-aware operation. Error messages dynamically useappCtx.Namefor better branding flexibility.Based on learnings, dependencies like
k8s.Kubeandchartfs.ChartFSare properly injected via the constructor.Also applies to: 27-27, 32-32, 38-38, 79-79, 84-84, 124-124, 195-214
pkg/api/appcontext.go (1)
7-22: Excellent use of functional options pattern for immutable context.The
AppContextdesign follows best practices:
- Immutable metadata holder separates "what the app is" from "how it runs"
- Functional options enable flexible configuration with sensible defaults
- The
RepoURI()method provides a consistent repository identifier format- Default values align with the Red Hat AppStudio project context
The centralization of application metadata enables the dynamic branding and framework reusability goals outlined in the PR objectives.
Also applies to: 24-27, 81-99
pkg/mcptools/notestool.go (1)
22-22: LGTM! Parameterization enables framework reusability.The refactoring properly introduces per-instance
appNameinstead of hardcoded constants, enabling the MCP tool to be rebranded for different applications. The suffix-based naming convention (appName + notesSuffix) is clean and the constructor properly injects dependencies including thejobparameter.pkg/framework/app.go (4)
18-33: LGTM! Clean encapsulation with appropriate field visibility.The struct design correctly exposes AppCtx and ChartFS as public fields for external access while keeping implementation details (integrations, rootCmd, flags, kube, mcpToolsBuilder, mcpImage) private. The comments clearly document the purpose of each field.
35-43: LGTM! Clean public API surface.These methods provide a clean interface for external callers to access the Cobra command and execute the application without exposing internal details.
100-148: LGTM! Consistent subcommand registration pattern.All subcommands are correctly instantiated with AppCtx as the first parameter, promoting consistent application metadata propagation. The use of the
api.SubCommandinterface andapi.NewRunnerwrapper creates a uniform command registration pattern across the framework.
150-179: LGTM! Well-structured constructor with functional options pattern.The constructor properly applies functional options before initializing dependencies and calls
setupRootCmd()with appropriate error handling. The godoc clearly documents the parameters and usage pattern.pkg/subcmd/mcpserver.go (3)
18-32: LGTM! Updated struct definition aligns with framework refactor.The struct correctly implements
api.SubCommandand includes all necessary fields for the builder pattern (appCtx, manager, mcpToolsBuilder, image). The appName field enables dynamic branding across the MCP server.
38-57: LGTM! Standard api.SubCommand implementation.The implementation correctly satisfies the
api.SubCommandinterface with appropriate flag handling and stub implementations forComplete()andValidate().
59-87: LGTM! Clean builder-based tool initialization flow.The Run method correctly uses the
MCPToolsBuilderpattern withNewMCPToolsContextconstructor, ensuring the logger usesio.Discardfor MCP STDIO protocol compatibility (as noted in the comment on line 61). The flow is clear: build tools → read instructions → create server → add tools → start server.pkg/mcptools/configtools.go (4)
19-47: LGTM! Struct and constants updated for dynamic naming.The addition of
appNameandcfsfields, along with the refactoring of tool name constants to suffix-based identifiers (e.g.,configGetSuffix), correctly enables dynamic branding where each tool name is prefixed with the application name. This aligns with the broader framework refactor.
62-167: LGTM! Handlers correctly use appName for dynamic messaging.The
getHandlerandinitHandlermethods properly interpolatec.appNameinto user-facing messages and tool references (e.g., line 115:c.appName+configGetSuffix), ensuring consistent dynamic branding. The use ofc.cfsfor configuration access (line 82) aligns with the new ChartFS integration.
444-569: LGTM! Consistent dynamic tool registration throughout.All six MCP tools are registered with consistent suffix-based naming (e.g.,
c.appName+configGetSuffix) and their descriptions properly interpolatec.appNameto provide context-aware help text. This ensures the tools are dynamically branded per application instance.
571-594: LGTM! Constructor correctly wires appCtx and cfs dependencies.The updated
NewConfigToolssignature properly acceptsappCtxandcfs, initializes the default configuration withconfig.NewConfigDefault(cfs, appCtx.Namespace)(line 580), and sets theappNamefield fromappCtx.Name(line 586). All new struct fields are correctly initialized.
|
@otaviof: This pull request references RHTAP-6103 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @pkg/subcmd/mcptools.go:
- Around line 17-47: MCPServer.Validate() currently returns nil without checking
required dependencies which can lead to nil dereferences later in
standardMCPTools; update MCPServer.Validate() to explicitly check that m.appCtx,
m.flags, m.cfs, m.kube, and m.manager are non-nil and return descriptive errors
(e.g., "application context is nil", "flags are nil", "chart filesystem is nil",
"kubernetes client is nil", "integrations manager is nil") when any are missing
so callers like standardMCPTools fail fast and predictably.
🧹 Nitpick comments (4)
pkg/installer/job.go (1)
301-307: Consider adding nil checks for defensive programming.If
appCtxis nil, callingappCtx.NameorappCtx.RepoURI()will panic. While the codebase pattern appears to assume valid arguments, adding a simple guard could prevent runtime panics:🛡️ Optional defensive nil check
func NewJob(appCtx *api.AppContext, kube *k8s.Kube) *Job { + if appCtx == nil || kube == nil { + panic("NewJob: appCtx and kube must not be nil") + } return &Job{ kube: kube, appName: appCtx.Name, repoURI: appCtx.RepoURI(), retries: 0, } }pkg/subcmd/integration_github.go (1)
84-91: Dynamic app name in error message supports rebranding.Using
g.appCtx.Nameinstead of a hardcoded constant aligns with the framework's goal of making the CLI reusable. The TODO for the update path is acknowledged.The
--updateflag triggers a panic. Would you like me to open an issue to track implementing the update functionality?pkg/resolver/annotations.go (1)
21-52: Consider extracting a helper to reduce repetition.All six functions follow the same pattern:
fmt.Sprintf("%s/%s", appCtx.RepoURI(), suffix). A private helper could reduce duplication while keeping the public API unchanged.♻️ Optional refactor
+// makeAnnotation builds an annotation key from the app context and suffix. +func makeAnnotation(appCtx *api.AppContext, suffix string) string { + return fmt.Sprintf("%s/%s", appCtx.RepoURI(), suffix) +} + // AnnotationProductName returns the product-name annotation key for the given app // context. func AnnotationProductName(appCtx *api.AppContext) string { - return fmt.Sprintf("%s/%s", appCtx.RepoURI(), suffixProductName) + return makeAnnotation(appCtx, suffixProductName) } // (Apply same pattern to other functions...)pkg/subcmd/mcptools.go (1)
52-62: Optional: Consider clarifying the "metadata introspection" comment.The comment states that IntegrationTools "creates its own instance for metadata introspection," but it's not immediately clear why this differs from other tools or what metadata introspection means in this context.
If metadata introspection refers to the Integration command's use of reflection or dynamic discovery of available integrations, consider elaborating:
-// Integration tools, creates its own instance for metadata introspection. +// Integration tools. NewIntegration creates a command instance that +// introspects available integrations via the IntegrationManager.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (44)
cmd/tssc/main.gopkg/api/appcontext.gopkg/api/constants.gopkg/api/types.gopkg/chartfs/chartfs_test.gopkg/constants/constants.gopkg/framework/app.gopkg/framework/constants.gopkg/framework/mcpserver/mcpserver.gopkg/framework/options.gopkg/hooks/hooks_test.gopkg/installer/job.gopkg/mcptools/configtools.gopkg/mcptools/context.gopkg/mcptools/notestool.gopkg/resolver/annotations.gopkg/resolver/collection.gopkg/resolver/collection_test.gopkg/resolver/dependency.gopkg/resolver/dependency_test.gopkg/resolver/resolver_test.gopkg/resolver/topology_test.gopkg/resolver/topologybuilder.gopkg/subcmd/config.gopkg/subcmd/config_helper.gopkg/subcmd/deploy.gopkg/subcmd/installer.gopkg/subcmd/integration.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_artifactory.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_github.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_jenkins.gopkg/subcmd/integration_nexus.gopkg/subcmd/integration_quay.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/integration_trustification.gopkg/subcmd/mcpserver.gopkg/subcmd/mcptools.gopkg/subcmd/modules.gopkg/subcmd/template.gopkg/subcmd/topology.go
🚧 Files skipped from review as they are similar to previous changes (11)
- pkg/resolver/dependency.go
- pkg/framework/constants.go
- pkg/subcmd/installer.go
- pkg/framework/options.go
- pkg/api/appcontext.go
- pkg/subcmd/topology.go
- pkg/resolver/topology_test.go
- pkg/resolver/topologybuilder.go
- pkg/resolver/resolver_test.go
- pkg/api/types.go
- pkg/mcptools/configtools.go
🧰 Additional context used
📓 Path-based instructions (6)
**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Never hardcode Gemini API keys in source code; use environment variables or secure configuration management
Files:
pkg/chartfs/chartfs_test.gopkg/constants/constants.gocmd/tssc/main.gopkg/subcmd/config_helper.gopkg/subcmd/integration_jenkins.gopkg/subcmd/integration_gitlab.gopkg/subcmd/template.gopkg/resolver/collection_test.gopkg/subcmd/modules.gopkg/subcmd/integration_artifactory.gopkg/resolver/collection.gopkg/resolver/dependency_test.gopkg/framework/mcpserver/mcpserver.gopkg/subcmd/integration_acs.gopkg/framework/app.gopkg/mcptools/context.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_nexus.gopkg/mcptools/notestool.gopkg/subcmd/integration_trustedartifactsigner.gopkg/installer/job.gopkg/subcmd/deploy.gopkg/subcmd/mcptools.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_github.gopkg/subcmd/integration_quay.gopkg/subcmd/mcpserver.gopkg/resolver/annotations.gopkg/hooks/hooks_test.gopkg/api/constants.gopkg/subcmd/config.gopkg/subcmd/integration.go
**/*_test.go
📄 CodeRabbit inference engine (GEMINI.md)
Use the standard
testingpackage withgithub.com/onsi/gomegaassertion library for tests
Files:
pkg/chartfs/chartfs_test.gopkg/resolver/collection_test.gopkg/resolver/dependency_test.gopkg/hooks/hooks_test.go
**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Use
go:embeddirective to embedinstallerdirectory resources (Helm charts, configurations, values.yaml.tpl) in the executable
Files:
pkg/chartfs/chartfs_test.gopkg/constants/constants.gocmd/tssc/main.gopkg/subcmd/config_helper.gopkg/subcmd/integration_jenkins.gopkg/subcmd/integration_gitlab.gopkg/subcmd/template.gopkg/resolver/collection_test.gopkg/subcmd/modules.gopkg/subcmd/integration_artifactory.gopkg/resolver/collection.gopkg/resolver/dependency_test.gopkg/framework/mcpserver/mcpserver.gopkg/subcmd/integration_acs.gopkg/framework/app.gopkg/mcptools/context.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_nexus.gopkg/mcptools/notestool.gopkg/subcmd/integration_trustedartifactsigner.gopkg/installer/job.gopkg/subcmd/deploy.gopkg/subcmd/mcptools.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_github.gopkg/subcmd/integration_quay.gopkg/subcmd/mcpserver.gopkg/resolver/annotations.gopkg/hooks/hooks_test.gopkg/api/constants.gopkg/subcmd/config.gopkg/subcmd/integration.go
pkg/chartfs/**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Implement
io.FScompatible abstraction inpkg/chartfsto provide access to embedded installer directory resources
Files:
pkg/chartfs/chartfs_test.go
pkg/subcmd/**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
pkg/subcmd/**/*.go: Usecobralibrary for CLI command structure in the tssc-cli project
Define commands as structs inpkg/subcmdthat implement a common interface
Use specificvalidateFlags()methods for flag logic (e.g., mutual exclusion) rather than relying only on Cobra's built-in validators
Inject dependencies likek8s.Kubeandchartfs.ChartFSvia constructors in command structs
Files:
pkg/subcmd/config_helper.gopkg/subcmd/integration_jenkins.gopkg/subcmd/integration_gitlab.gopkg/subcmd/template.gopkg/subcmd/modules.gopkg/subcmd/integration_artifactory.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_nexus.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/deploy.gopkg/subcmd/mcptools.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_github.gopkg/subcmd/integration_quay.gopkg/subcmd/mcpserver.gopkg/subcmd/config.gopkg/subcmd/integration.go
pkg/resolver/**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Use
pkg/resolverto define the dependency topology, including the sequence of Helm Charts and relationships between them and required integrations
Files:
pkg/resolver/collection_test.gopkg/resolver/collection.gopkg/resolver/dependency_test.gopkg/resolver/annotations.go
🧠 Learnings (22)
📓 Common learnings
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Inject dependencies like `k8s.Kube` and `chartfs.ChartFS` via constructors in command structs
Learnt from: Roming22
Repo: redhat-appstudio/tssc-cli PR: 1159
File: installer/charts/tssc-dh/Chart.yaml:5-6
Timestamp: 2025-08-20T15:48:01.881Z
Learning: In the tssc-cli project, chart version bumps in Chart.yaml files are handled at code freeze rather than immediately when appVersion changes, as part of their coordinated release process.
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/chartfs/**/*.go : Implement `io.FS` compatible abstraction in `pkg/chartfs` to provide access to embedded installer directory resources
Applied to files:
pkg/chartfs/chartfs_test.gocmd/tssc/main.gopkg/subcmd/template.gopkg/resolver/collection_test.gopkg/resolver/collection.gopkg/resolver/dependency_test.gopkg/framework/app.gopkg/subcmd/deploy.gopkg/hooks/hooks_test.gopkg/subcmd/config.gopkg/subcmd/integration.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Inject dependencies like `k8s.Kube` and `chartfs.ChartFS` via constructors in command structs
Applied to files:
pkg/chartfs/chartfs_test.gocmd/tssc/main.gopkg/subcmd/config_helper.gopkg/subcmd/integration_jenkins.gopkg/subcmd/integration_gitlab.gopkg/subcmd/template.gopkg/resolver/collection_test.gopkg/subcmd/modules.gopkg/subcmd/integration_artifactory.gopkg/resolver/collection.gopkg/resolver/dependency_test.gopkg/subcmd/integration_acs.gopkg/framework/app.gopkg/mcptools/context.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_nexus.gopkg/mcptools/notestool.gopkg/subcmd/integration_trustedartifactsigner.gopkg/installer/job.gopkg/subcmd/deploy.gopkg/subcmd/mcptools.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_github.gopkg/subcmd/integration_quay.gopkg/subcmd/mcpserver.gopkg/hooks/hooks_test.gopkg/subcmd/config.gopkg/subcmd/integration.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to **/*_test.go : Use the standard `testing` package with `github.com/onsi/gomega` assertion library for tests
Applied to files:
pkg/chartfs/chartfs_test.gopkg/resolver/collection_test.gopkg/resolver/dependency_test.gopkg/hooks/hooks_test.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*_test.go : All tests must use the `testing` package with `testify/assert` library
Applied to files:
pkg/chartfs/chartfs_test.gopkg/subcmd/template.gopkg/resolver/collection_test.gopkg/resolver/dependency_test.gopkg/subcmd/integration_github.gopkg/hooks/hooks_test.gopkg/subcmd/config.go
📚 Learning: 2025-08-13T14:29:50.296Z
Learnt from: dperaza4dustbit
Repo: redhat-appstudio/tssc-cli PR: 1133
File: installer/charts/tssc-infrastructure/values.yaml:26-26
Timestamp: 2025-08-13T14:29:50.296Z
Learning: The tssc-cli team uses "__OVERWRITE_ME__" as a placeholder convention in Helm chart values.yaml files, even when the field will be used in templates with range operations. This is their established team convention and should not be flagged as an issue.
Applied to files:
pkg/constants/constants.go
📚 Learning: 2025-09-29T14:49:45.227Z
Learnt from: lingyzhuang
Repo: redhat-appstudio/tssc-cli PR: 1276
File: pkg/mcptools/configtools.go:0-0
Timestamp: 2025-09-29T14:49:45.227Z
Learning: In pkg/mcptools/configtools.go, the SettingsArg and ProductsArg constants are used for Gemini input generation, where Gemini uses these parameter names to generate input and the system reads the input content by these argument names.
Applied to files:
pkg/constants/constants.gopkg/subcmd/mcptools.gopkg/api/constants.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Use `cobra` library for CLI command structure in the tssc-cli project
Applied to files:
cmd/tssc/main.gopkg/subcmd/config_helper.gopkg/subcmd/integration_jenkins.gopkg/subcmd/integration_gitlab.gopkg/subcmd/template.gopkg/subcmd/modules.gopkg/subcmd/integration_artifactory.gopkg/resolver/collection.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_nexus.gopkg/mcptools/notestool.gopkg/subcmd/integration_trustedartifactsigner.gopkg/installer/job.gopkg/subcmd/deploy.gopkg/subcmd/mcptools.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_github.gopkg/subcmd/integration_quay.gopkg/subcmd/config.gopkg/subcmd/integration.go
📚 Learning: 2025-09-29T15:10:13.650Z
Learnt from: lingyzhuang
Repo: redhat-appstudio/tssc-cli PR: 1276
File: pkg/config/config.go:159-185
Timestamp: 2025-09-29T15:10:13.650Z
Learning: In the tssc-cli project, the UpdateMappingValue method in pkg/config/config.go should only update existing configuration keys and not create new ones. Adding new config entries is not allowed, so silent return when key is not found is the desired behavior.
Applied to files:
cmd/tssc/main.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Define commands as structs in `pkg/subcmd` that implement a common interface
Applied to files:
cmd/tssc/main.gopkg/subcmd/integration_jenkins.gopkg/subcmd/integration_gitlab.gopkg/subcmd/template.gopkg/subcmd/modules.gopkg/subcmd/integration_artifactory.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_nexus.gopkg/mcptools/notestool.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/deploy.gopkg/subcmd/mcptools.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_github.gopkg/subcmd/integration_quay.gopkg/subcmd/config.gopkg/subcmd/integration.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to **/*.go : Use `go:embed` directive to embed `installer` directory resources (Helm charts, configurations, values.yaml.tpl) in the executable
Applied to files:
cmd/tssc/main.gopkg/framework/app.gopkg/mcptools/notestool.gopkg/subcmd/deploy.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/engine/**/*.go : Use Helm SDK in `pkg/engine` for Helm engine implementation, chart installation, templating functions, and installation lifecycle management
Applied to files:
cmd/tssc/main.gopkg/subcmd/template.gopkg/resolver/collection.gopkg/resolver/dependency_test.gopkg/framework/app.gopkg/mcptools/notestool.gopkg/subcmd/deploy.gopkg/subcmd/integration_github.gopkg/hooks/hooks_test.gopkg/subcmd/config.gopkg/subcmd/integration.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/integration/**/*.go : Define integrations in `pkg/integration` to connect to external services like GitHub, Quay, etc.
Applied to files:
pkg/subcmd/integration_jenkins.gopkg/subcmd/integration_gitlab.gopkg/subcmd/template.gopkg/subcmd/modules.gopkg/subcmd/integration_artifactory.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_nexus.gopkg/mcptools/notestool.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/deploy.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_github.gopkg/subcmd/integration_quay.gopkg/subcmd/config.gopkg/subcmd/integration.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Define interface definition at the top of service files, followed by service struct and implementation
Applied to files:
pkg/subcmd/integration_jenkins.gopkg/subcmd/integration_gitlab.gopkg/subcmd/template.gopkg/subcmd/integration_artifactory.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_nexus.gopkg/subcmd/integration_trustedartifactsigner.gopkg/installer/job.gopkg/subcmd/deploy.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_github.gopkg/subcmd/integration_quay.gopkg/subcmd/config.gopkg/subcmd/integration.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Enable and follow linters: asciicheck, dogsled, dupword, errorlint, goconst, misspell, nakedret, nolintlint, revive, staticcheck, testifylint, unconvert, usestdlibvars, whitespace
Applied to files:
pkg/subcmd/integration_jenkins.gopkg/subcmd/integration_gitlab.gopkg/subcmd/template.gopkg/subcmd/integration_artifactory.gopkg/resolver/collection.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_nexus.gopkg/mcptools/notestool.gopkg/subcmd/integration_trustedartifactsigner.gopkg/installer/job.gopkg/subcmd/deploy.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_github.gopkg/subcmd/integration_quay.gopkg/subcmd/config.gopkg/subcmd/integration.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Regenerate mocks after modifying existing interfaces
Applied to files:
pkg/subcmd/integration_gitlab.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/resolver/**/*.go : Use `pkg/resolver` to define the dependency topology, including the sequence of Helm Charts and relationships between them and required integrations
Applied to files:
pkg/subcmd/template.gopkg/resolver/collection_test.gopkg/resolver/collection.gopkg/resolver/dependency_test.gopkg/subcmd/deploy.gopkg/resolver/annotations.gopkg/hooks/hooks_test.gopkg/subcmd/config.gopkg/subcmd/integration.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*_test.go : When fixing bugs or creating new features, ensure new test scenarios are added to cover the new logic
Applied to files:
pkg/resolver/collection_test.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Do not use `int`, use `int64` instead (applies to both slices and maps)
Applied to files:
pkg/installer/job.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Do not use `interface{}`, use the `any` alias instead
Applied to files:
pkg/installer/job.go
📚 Learning: 2025-08-27T18:30:02.411Z
Learnt from: Roming22
Repo: redhat-appstudio/tssc-cli PR: 1190
File: pkg/resolver/resolver_test.go:52-67
Timestamp: 2025-08-27T18:30:02.411Z
Learning: In tssc-cli, there is a distinction between deployment namespace (where resources are deployed, referenced in values.yaml.tpl) and chart registration namespace (where Helm charts are registered, tested in resolver tests). These are different concepts and may use different namespace values.
Applied to files:
pkg/subcmd/deploy.gopkg/hooks/hooks_test.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*_test.go : Tests must be parallelized using `t.Parallel()`
Applied to files:
pkg/hooks/hooks_test.go
🧬 Code graph analysis (24)
pkg/chartfs/chartfs_test.go (1)
pkg/chartfs/chartfs.go (1)
New(98-100)
pkg/subcmd/config_helper.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/subcmd/config.go (1)
Config(20-36)pkg/config/manager.go (2)
NewConfigMapManager(176-180)Name(25-25)
pkg/subcmd/integration_jenkins.go (5)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/subcmd/config.go (1)
Config(20-36)pkg/config/config.go (1)
Config(30-36)pkg/integration/integration.go (1)
Integration(19-26)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/integration_gitlab.go (5)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/subcmd/config.go (1)
Config(20-36)pkg/config/config.go (1)
Config(30-36)pkg/integration/integration.go (1)
Integration(19-26)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/modules.go (3)
pkg/api/types.go (1)
IntegrationModule(13-28)pkg/integrations/manager.go (11)
ACS(26-26)Artifactory(27-27)Azure(28-28)BitBucket(29-29)GitHub(30-30)GitLab(31-31)Jenkins(32-32)Nexus(33-33)Quay(34-34)TrustedArtifactSigner(35-35)Trustification(36-36)pkg/integration/imageregistry.go (2)
NewContainerRegistry(105-107)QuayURL(27-27)
pkg/resolver/collection.go (2)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/resolver/dependency.go (2)
Dependency(15-19)NewDependency(108-110)
pkg/resolver/dependency_test.go (3)
pkg/chartfs/chartfs.go (1)
New(98-100)pkg/api/appcontext.go (1)
NewAppContext(84-99)pkg/resolver/dependency.go (1)
NewDependency(108-110)
pkg/framework/mcpserver/mcpserver.go (1)
pkg/api/appcontext.go (1)
AppContext(13-22)
pkg/subcmd/integration_acs.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/subcmd/config.go (1)
Config(20-36)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/mcptools/context.go (5)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/flags/flags.go (1)
Flags(17-24)pkg/chartfs/chartfs.go (1)
ChartFS(15-17)pkg/k8s/kube.go (1)
Kube(21-23)pkg/integrations/manager.go (1)
Manager(20-23)
pkg/subcmd/integration_trustification.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/subcmd/config.go (1)
Config(20-36)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/integration_nexus.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/subcmd/config.go (1)
Config(20-36)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/mcptools/notestool.go (5)
pkg/flags/flags.go (1)
Flags(17-24)pkg/k8s/kube.go (1)
Kube(21-23)pkg/config/manager.go (1)
ConfigMapManager(17-19)pkg/resolver/topologybuilder.go (1)
TopologyBuilder(15-19)pkg/installer/job.go (1)
Job(22-27)
pkg/subcmd/integration_trustedartifactsigner.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/subcmd/config.go (1)
Config(20-36)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/installer/job.go (2)
pkg/subcmd/template.go (1)
Template(19-36)pkg/api/appcontext.go (1)
AppContext(13-22)
pkg/subcmd/deploy.go (4)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/integrations/manager.go (1)
Manager(20-23)pkg/resolver/topologybuilder.go (1)
TopologyBuilder(15-19)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/integration_azure.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/subcmd/config.go (1)
Config(20-36)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/integration_github.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/api/subcommand.go (1)
SubCommand(9-22)pkg/config/manager.go (1)
Name(25-25)
pkg/subcmd/integration_quay.go (2)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/mcpserver.go (6)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/chartfs/chartfs.go (1)
ChartFS(15-17)pkg/k8s/kube.go (1)
Kube(21-23)pkg/mcptools/context.go (2)
MCPToolsBuilder(53-53)NewMCPToolsContext(31-49)pkg/api/subcommand.go (1)
SubCommand(9-22)pkg/framework/mcpserver/mcpserver.go (2)
MCPServer(10-12)NewMCPServer(24-33)
pkg/resolver/annotations.go (1)
pkg/api/appcontext.go (1)
AppContext(13-22)
pkg/hooks/hooks_test.go (4)
pkg/chartfs/chartfs.go (1)
New(98-100)pkg/api/appcontext.go (1)
NewAppContext(84-99)pkg/hooks/hooks.go (1)
NewHooks(89-99)pkg/resolver/dependency.go (1)
NewDependencyWithNamespace(114-118)
pkg/subcmd/config.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/api/subcommand.go (1)
SubCommand(9-22)pkg/resolver/collection.go (1)
NewCollection(100-130)
pkg/subcmd/integration.go (4)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/integrations/manager.go (2)
Manager(20-23)IntegrationName(15-15)pkg/resolver/collection.go (1)
NewCollection(100-130)pkg/api/subcommand.go (1)
NewRunner(36-47)
🔇 Additional comments (66)
pkg/hooks/hooks_test.go (3)
5-5: LGTM: Import changes align with new API surface.The addition of
osforos.DirFSand the switch fromconstantstoapiforNewAppContextare necessary and correct for the framework refactor.Also applies to: 8-8
20-20: LGTM: Filesystem creation correctly updated for new API.The change from
chartfs.NewChartFStochartfs.New(os.DirFS(...))correctly reflects the new API signature wherechartfs.Newno longer returns an error. The test will still fail appropriately if the path is invalid whenGetChartFilesis called.
25-27: LGTM: AppContext integration correctly implemented.The introduction of
api.NewAppContext("tssc")and passing bothappCtx.NamespaceandappCtxtoNewDependencyWithNamespacecorrectly implements the centralized application metadata pattern described in the PR objectives.pkg/installer/job.go (2)
8-8: LGTM: Import and field changes support the AppContext refactoring.The switch from constants to the
apipackage and the addition of therepoURIfield align with the framework's goal of dynamic, per-instance labeling based on application context.Also applies to: 25-25
57-57: LGTM: Consistent use of instance-based label selector.All call sites correctly use
j.LabelSelector()for queries, resource labels, and command generation, replacing the previous constant-based approach with dynamic, per-instance labeling.Also applies to: 224-224, 229-229, 260-260
pkg/subcmd/integration_artifactory.go (2)
6-7: LGTM – AppContext integration follows the established pattern.The import, field addition, and interface assertion update align with the broader refactor to centralize application metadata via
AppContext. Dependencies are correctly injected via the constructor as per coding guidelines.Also applies to: 17-27, 29-29
44-48: Constructor and Complete method correctly propagate appCtx.The constructor signature and initialization properly wire
appCtx, andCompletecorrectly passes it tobootstrapConfig. This follows the consistent pattern across integration subcommands.Also applies to: 63-81
pkg/subcmd/integration_quay.go (2)
6-7: LGTM – Consistent AppContext refactor pattern.The changes mirror the established pattern across integration subcommands: import addition, field inclusion, and interface assertion update to
api.SubCommand.Also applies to: 17-24, 26-26
54-57: Constructor and Complete wiring is correct.The
appCtxis properly injected via the constructor and propagated tobootstrapConfigin theCompletemethod, maintaining consistency with other integration subcommands.Also applies to: 72-93
pkg/subcmd/integration_nexus.go (2)
6-7: LGTM – Follows established refactor pattern.Import, struct field, and interface assertion changes are consistent with the broader
AppContextmigration across integration subcommands.Also applies to: 17-24, 26-26
42-46: Constructor and Complete correctly wired.The
appCtxpropagation through the constructor and intobootstrapConfigis correctly implemented.Also applies to: 60-81
pkg/subcmd/integration_jenkins.go (2)
6-7: LGTM – Consistent with the integration subcommand refactor.The
apiimport,appCtxfield addition, andapi.SubCommandinterface assertion follow the established pattern.Also applies to: 17-24, 26-26
42-46: Constructor and Complete method correctly implemented.
appCtxis properly accepted, stored, and forwarded tobootstrapConfig, consistent with sibling integration subcommands.Also applies to: 60-81
pkg/subcmd/integration_trustification.go (2)
6-7: LGTM – Follows established integration subcommand pattern.The
apiimport,appCtxfield, andapi.SubCommandinterface assertion are correctly added, maintaining consistency across integration subcommands.Also applies to: 17-24, 26-26
42-46: Constructor and Complete wiring is correct.
appCtxis properly injected and propagated tobootstrapConfig, completing the refactor pattern.Also applies to: 61-82
pkg/api/constants.go (1)
3-15: Duplicate constant definitions detected.These constants (
ConfigFilename,ValuesFilename,InstructionsFilename) are identically defined inpkg/constants/constants.go. This violates DRY principles. Consider consolidating to a single source of truth—either here inpkg/api(if it's the public API surface) or inpkg/constants, then import where needed.Likely an incorrect or invalid review comment.
pkg/constants/constants.go (1)
3-15: Duplicate constants – consolidation needed.As noted in a previous review, these constants are duplicated in
pkg/api/constants.go. The AI summary states this file should be "the singular source," but identical definitions exist elsewhere. Consider having one package own these constants and having others import from it.Likely an incorrect or invalid review comment.
pkg/subcmd/integration_bitbucket.go (2)
17-26: LGTM! Clean integration of AppContext into the subcommand struct.The addition of
appCtxfield and the interface assertion change toapi.SubCommandalign well with the broader framework refactoring. The pattern follows project conventions for dependency injection via constructors.
60-78: Constructor signature change is consistent with other integration modules.The updated
NewIntegrationBitBucketproperly accepts and storesappCtx, and theCompletemethod correctly propagates it tobootstrapConfig. This follows the established pattern across other integration subcommands.pkg/subcmd/config.go (4)
20-38: LGTM! AppContext integration follows the established pattern.The struct field addition and interface assertion change to
api.SubCommandare consistent with the broader refactoring. Dependencies continue to be injected via the constructor as per project guidelines.
81-87: Good use of appCtx.Namespace for dynamic default value.Using
c.appCtx.Namespaceinstead of a hardcoded constant enables the framework to support different applications with their own default namespaces.
176-182: Correctly updated resolver.NewCollection call with appCtx.The call signature now matches the updated
NewCollectionfunction that requiresappCtxfor dependency construction, as shown in the relevant code snippets.
283-308: Constructor properly wires AppContext and returns the interface type.The updated signature accepting
appCtxand returningapi.SubCommandaligns with the framework's plugin architecture. TheappCtxis correctly stored and used in flag defaults.pkg/chartfs/chartfs_test.go (1)
10-20: LGTM! Test updated to use the new fs.FS-based constructor.The change from
NewChartFStoNew(os.DirFS("../../installer"))correctly aligns with the refactored ChartFS API that accepts anyfs.FS. The path adjustment forReadFileto"values.yaml.tpl"is appropriate since the filesystem is now rooted at the installer directory. This follows the coding guidelines for implementing anio.FScompatible abstraction inpkg/chartfs.pkg/framework/mcpserver/mcpserver.go (1)
24-32: LGTM! Constructor now supports dynamic app metadata and instructions.The refactored
NewMCPServerproperly usesappCtx.NameandappCtx.Versionfor server identification, enabling the framework to support different applications with their own branding. Passing instructions as a parameter instead of embedding them improves flexibility for reuse.pkg/subcmd/config_helper.go (1)
13-30: LGTM! Dynamic application naming in error messages.The updated
bootstrapConfigfunction properly usesappCtx.Nameto generate contextual error messages. This enables the framework to display appropriate subcommand paths (e.g.,tssc config) for different applications built on this framework.pkg/resolver/collection.go (1)
98-106: LGTM! AppContext propagation to dependencies enables dynamic annotation keys.The updated
NewCollectionproperly passesappCtxto eachNewDependencycall, allowing dependencies to use application-specific annotation keys. This aligns with theDependencystruct that storesappCtxfor annotation key resolution, as shown in the relevant code snippets frompkg/resolver/dependency.go.cmd/tssc/main.go (3)
20-35: LGTM! Clean initialization flow with proper error handling.The initialization sequence properly creates a tarball-based filesystem, overlays it with the local working directory, and wraps it with ChartFS. Error handling is explicit, addressing the concern from previous reviews about silent error handling. The overlay pattern cleanly combines embedded resources with local overrides.
53-67: LGTM! Unified app lifecycle with framework.NewApp.The application creation and execution flow is clean. Dependencies are wired through functional options (
WithIntegrations,WithMCPImage), and error handling properly exits with status code 1 on failures.
37-51: Application context and MCP image configuration look correct.The TSSC-specific context is properly initialized with build-time metadata. The MCP image tagging logic using
commitIDprovides a reasonable strategy:latestfor development builds (empty commitID) and specific commit tags for release builds. Thego:embeddirective is correctly implemented ininstaller/embed.gofor embedding installer resources, and no hardcoded API keys or sensitive credentials are present in the file.pkg/resolver/collection_test.go (1)
4-22: LGTM! Clean test adaptation to new API.The test correctly adapts to the refactored APIs:
- Uses
os.DirFSwithchartfs.New(fs.FS)instead ofNewChartFS(path string)- Creates
AppContextviaapi.NewAppContext("tssc")and passes it toNewCollection- Maintains existing test assertions while adapting to new constructor signatures
These changes align with the PR's goal of making the framework more generic and reusable.
pkg/resolver/dependency_test.go (1)
4-22: LGTM! Consistent test migration.The test adapts to the new API surface consistently with other resolver tests:
- Replaces
NewChartFSwithchartfs.New(os.DirFS(...))- Threads
AppContextthrough toNewDependency- Preserves all existing test assertions
The changes align with the dependency injection pattern established across the PR.
pkg/subcmd/integration_acs.go (2)
6-26: LGTM! Proper AppContext integration.The struct correctly:
- Adds
appCtx *api.AppContextfield for application context- Migrates from local
Interfacetoapi.SubCommand(enabling external framework use)- Follows the established pattern across integration subcommands
44-74: LGTM! AppContext properly threaded through.The changes correctly:
- Pass
appCtxtobootstrapConfigin theCompletemethod- Extend the constructor to accept
appCtxparameter- Assign
appCtxduring struct initializationThe dependency injection pattern is consistent with coding guidelines and other subcommands in this PR.
pkg/subcmd/template.go (2)
7-38: LGTM! Consistent struct refactoring.The struct changes follow the established pattern:
- Adds
appCtx *api.AppContextfor application context- Migrates to
api.SubCommandinterface- Maintains proper field ordering and documentation
87-166: LGTM! AppContext properly propagated.The changes correctly thread
AppContextthrough the template workflow:
- Passes
appCtxtoNewDependencyWithNamespacefor dependency initialization- Passes
appCtxtobootstrapConfigfor configuration loading- Extends constructor to accept and assign
appCtxThe dependency injection follows the established pattern per coding guidelines.
pkg/subcmd/integration_gitlab.go (1)
6-74: LGTM! Consistent integration command refactoring.The changes mirror the pattern established in
integration_acs.go:
- Adds
appCtx *api.AppContextfield to the struct- Migrates from local
Interfacetoapi.SubCommand- Threads
appCtxthroughbootstrapConfiginComplete- Extends constructor to accept and assign
appCtxAll changes align with the framework refactoring objectives and maintain consistency across integration subcommands.
pkg/subcmd/integration_trustedartifactsigner.go (2)
17-27: Consistent AppContext wiring aligns with the framework refactor.The struct correctly holds
appCtxand implementsapi.SubCommand. Dependencies are properly injected via the constructor, following the project's established patterns. Based on learnings, this follows the guideline to inject dependencies likek8s.Kubevia constructors in command structs.
59-80: Constructor properly wires AppContext and dependencies.The constructor follows the established pattern of accepting all dependencies as parameters and initializing the struct fields correctly.
pkg/subcmd/integration_azure.go (1)
17-27: Consistent with the AppContext refactor pattern.The changes mirror the pattern used in other integration subcommands, properly implementing
api.SubCommandand injecting dependencies via the constructor.pkg/mcptools/context.go (2)
14-27: Well-designed context struct with clear documentation.The
MCPToolsContextstruct properly encapsulates all dependencies needed for MCP tools. The documentation clearly explains theio.Discardrequirement for the logger to protect MCP STDIO protocol integrity.
29-53: Builder pattern enables flexible tool registration.The
NewMCPToolsContextconstructor andMCPToolsBuildertype provide a clean API for consumers to customize MCP tool creation. The critical comment at line 41 appropriately warns about the logger requirement.pkg/subcmd/integration.go (2)
16-22: Constructor signature properly updated for modular integration loading.The function now accepts
appCtxandmanagerparameters, enabling dynamic integration wiring via the manager's module registry.
76-80: Dynamic module registration enables extensibility.The loop iterates over registered modules from the manager, creates subcommands via the module's
Commandfactory, and wires them throughapi.NewRunner. This pattern enables consumers to customize which integrations are included.pkg/subcmd/integration_github.go (1)
18-31: Consistent AppContext integration with dynamic naming.The struct properly holds
appCtxand implementsapi.SubCommand. The interface assertion is correctly updated.pkg/subcmd/deploy.go (4)
23-38: Struct properly extended with AppContext and integration manager.The
Deploystruct now holdsappCtxandmanageras fields, with the interface assertion correctly updated toapi.SubCommand. Dependencies are injected via the constructor as per project guidelines.
76-92: Complete method properly initializes topology with AppContext.The
TopologyBuilderandbootstrapConfigcalls correctly receiveappCtx, centralizing application metadata throughout the command lifecycle.
116-128: Dynamic app name in user-facing error messages.Using
d.appCtx.Nameinstead of hardcoded strings enables the CLI to be rebranded while maintaining helpful error messages that guide users to the correct subcommands.
193-218: Constructor signature and return type properly updated.The
NewDeployfunction now acceptsappCtxandmanager, returningapi.SubCommandfor consistent interface compliance across subcommands.pkg/subcmd/modules.go (2)
12-122: Well-structured module definitions following the IntegrationModule contract.Each module correctly implements the
api.IntegrationModulecontract withName,Init, andCommandfields. The use ofintegrations.XXXconstants for names ensures consistency with the manager's integration registry.
124-139: StandardModules provides sensible defaults for common use cases.The function returns all standard integration modules in a defined order. As confirmed in past review comments, consumers can customize which modules to include via the
WithIntegrationsfunctional option, making this a sensible default rather than a mandatory set.pkg/mcptools/notestool.go (3)
21-29: LGTM! Clean struct with proper field documentation and dependency injection.The struct fields are well-documented, and the refactoring to accept
appNameandjobvia the constructor aligns with the dependency injection pattern. Based on learnings, injecting dependencies likek8s.Kubeand related components via constructors is the recommended approach.
116-133: Dynamic tool naming correctly implemented.The
Initmethod properly uses the per-instance namen.appName+notesSuffixfor MCP tool registration, enabling dynamic branding as intended by the PR objectives.
135-153: Constructor properly initializes all fields.The constructor signature correctly accepts all dependencies including the new
appNameandjobparameters, and initializes all struct fields. This follows the dependency injection pattern recommended for this codebase.pkg/subcmd/mcpserver.go (3)
19-31: Struct properly refactored with api.SubCommand compliance.The struct now correctly includes
appCtxwhich resolves the previous issue whereappNamewas not initialized. The interface assertionvar _ api.SubCommand = &MCPServer{}ensures compile-time verification of interface compliance.
59-86: Well-structured Run method with proper error handling.The method correctly:
- Creates
MCPToolsContextusing the constructor (ensuring logger usesio.Discardfor MCP STDIO protocol compatibility as noted in the context)- Uses the builder pattern to create tools
- Reads instructions from the embedded filesystem using standardized constants
- Properly wraps errors with context using
fmt.Errorf
98-116: Constructor properly initializes all fields includingappCtx.The previous review issue about missing
appNameinitialization is resolved. The constructor now correctly setsappCtxat line 105, which is used inRun()to create the MCP server with proper application metadata.pkg/framework/app.go (5)
21-33: Well-documented App struct with clear field organization.The struct separates public fields (
AppCtx,ChartFS) from internal runtime state. The comment clearly states thatAppCtxis the single source of truth for application metadata, aligning with the PR objective to centralize application metadata.
47-58: Good defensive programming with fallback for empty short description.The check at lines 49-51 provides a sensible default (
appCtx.Name + " installer") whenShortis not provided, preventing empty CLI descriptions.
88-98: Appropriate validation for required MCP configuration.The validation at lines 95-98 ensures
mcpImageis configured before proceeding, providing a clear error message directing users to useWithMCPImage(). This fail-fast approach prevents cryptic runtime errors.
156-179: Constructor follows functional options pattern correctly.The constructor properly:
- Initializes core required fields first
- Applies functional options to allow customization
- Creates the Kubernetes client after options (allowing flags to be modified by options if needed)
- Calls
setupRootCmd()and propagates errorsThis follows the established pattern for configurable constructors in Go.
83-86: The pattern difference is intentional.NewIntegrationreturns*cobra.Commanddirectly because it is a parent command that groups integration-specific subcommands (github, gitlab, quay, etc.). The other subcommands (config, deploy, template, etc.) implement theSubCommandinterface and are wrapped withapi.NewRunner()to enable lifecycle management (Complete, Validate, Run). The different registration patterns correctly reflect their architectural roles:NewIntegrationis a command container, while the others are leaf commands with business logic.pkg/resolver/annotations.go (2)
9-17: Clean constant definitions for annotation suffixes.The unexported suffix constants are well-organized and follow a consistent naming pattern. This approach keeps the implementation details private while exposing only the necessary functions.
19-52:RepoURI()method is correctly defined onapi.AppContext.The
RepoURI()method exists atpkg/api/appcontext.go:25with the correct signaturefunc (a *AppContext) RepoURI() string. All annotation functions in lines 19-52 correctly call this method to build annotation keys.pkg/subcmd/mcptools.go (2)
10-15: LGTM! Clean delegation pattern.The public entry point correctly exposes the builder function while keeping the implementation private.
83-90: LGTM! All standard MCP tools properly constructed.The tools are returned in a consistent order with all necessary dependencies injected. The construction pattern follows the builder approach correctly.
Migrating from hardcoded constants to a context-driven architecture where `AppContext` serves as the single source of truth for application metadata. Assisted-by: Claude
|
@otaviof: This pull request references RHTAP-6103 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pkg/mcptools/configtools.go (1)
287-329: Critical: Product data loss when toggling enabled status.Line 318 updates
spec.Enabled, but line 320 creates a newconfig.Product{Enabled: enabled}and passes it tosetProduct, discarding the originalspec. This causes the product's namespace, properties, and other fields to be lost.🐛 Fix to preserve existing product fields
// Toggle the product status. spec.Enabled = enabled - if res = c.setProduct(ctx, cfg, name, config.Product{Enabled: enabled}); res != nil { + if res = c.setProduct(ctx, cfg, name, *spec); res != nil { return res, nil }
🧹 Nitpick comments (3)
cmd/tssc/main.go (1)
45-51: Consider documenting the MCP image tagging strategy.The logic using
commitIDto select between:latestand:<commitID>tags is sound for development/release workflows. A brief inline comment explaining the rationale (e.g., "latest for local builds, commit-specific for CI builds") would help future maintainers.pkg/framework/app.go (1)
156-179: Consider adding nil-safety checks for required parameters.The constructor accepts
appCtxandcfswithout validation. If either is nil, downstream code (e.g.,appCtx.RepoURI()in annotations,cfs.ReadFile()in deploy) will panic. Consider adding early validation:if appCtx == nil { return nil, fmt.Errorf("appCtx is required") } if cfs == nil { return nil, fmt.Errorf("chartfs is required") }pkg/subcmd/mcpserver.go (1)
53-56: Consider adding defensive validation for required dependencies.While the framework likely guarantees non-nil dependencies,
Validate()could defensively check thatmcpToolsBuilderis not nil to prevent potential panics inRun()at line 71.♻️ Suggested validation
func (m *MCPServer) Validate() error { + if m.mcpToolsBuilder == nil { + return fmt.Errorf("MCPToolsBuilder is required") + } return nil }
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (42)
cmd/tssc/main.gopkg/api/appcontext.gopkg/api/types.gopkg/chartfs/chartfs_test.gopkg/constants/constants.gopkg/framework/app.gopkg/framework/mcpserver/mcpserver.gopkg/framework/options.gopkg/hooks/hooks_test.gopkg/installer/job.gopkg/mcptools/configtools.gopkg/mcptools/context.gopkg/mcptools/notestool.gopkg/resolver/annotations.gopkg/resolver/collection.gopkg/resolver/collection_test.gopkg/resolver/dependency.gopkg/resolver/dependency_test.gopkg/resolver/resolver_test.gopkg/resolver/topology_test.gopkg/resolver/topologybuilder.gopkg/subcmd/config.gopkg/subcmd/config_helper.gopkg/subcmd/deploy.gopkg/subcmd/installer.gopkg/subcmd/integration.gopkg/subcmd/integration_acs.gopkg/subcmd/integration_artifactory.gopkg/subcmd/integration_azure.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_github.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_jenkins.gopkg/subcmd/integration_nexus.gopkg/subcmd/integration_quay.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/integration_trustification.gopkg/subcmd/mcpserver.gopkg/subcmd/mcptools.gopkg/subcmd/modules.gopkg/subcmd/template.gopkg/subcmd/topology.go
🚧 Files skipped from review as they are similar to previous changes (16)
- pkg/resolver/topologybuilder.go
- pkg/framework/options.go
- pkg/subcmd/integration_jenkins.go
- pkg/resolver/resolver_test.go
- pkg/api/types.go
- pkg/subcmd/integration_acs.go
- pkg/subcmd/mcptools.go
- pkg/constants/constants.go
- pkg/resolver/dependency_test.go
- pkg/api/appcontext.go
- pkg/hooks/hooks_test.go
- pkg/mcptools/notestool.go
- pkg/subcmd/installer.go
- pkg/subcmd/integration_azure.go
- pkg/resolver/collection_test.go
- pkg/chartfs/chartfs_test.go
🧰 Additional context used
📓 Path-based instructions (5)
**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Never hardcode Gemini API keys in source code; use environment variables or secure configuration management
Files:
pkg/resolver/collection.gopkg/subcmd/integration_nexus.gopkg/subcmd/config.gopkg/mcptools/context.gocmd/tssc/main.gopkg/subcmd/integration_github.gopkg/installer/job.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/deploy.gopkg/resolver/dependency.gopkg/subcmd/config_helper.gopkg/subcmd/integration.gopkg/subcmd/topology.gopkg/subcmd/modules.gopkg/subcmd/integration_artifactory.gopkg/framework/mcpserver/mcpserver.gopkg/resolver/annotations.gopkg/subcmd/template.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_gitlab.gopkg/resolver/topology_test.gopkg/subcmd/integration_quay.gopkg/framework/app.gopkg/mcptools/configtools.gopkg/subcmd/mcpserver.go
**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Use
go:embeddirective to embedinstallerdirectory resources (Helm charts, configurations, values.yaml.tpl) in the executable
Files:
pkg/resolver/collection.gopkg/subcmd/integration_nexus.gopkg/subcmd/config.gopkg/mcptools/context.gocmd/tssc/main.gopkg/subcmd/integration_github.gopkg/installer/job.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/deploy.gopkg/resolver/dependency.gopkg/subcmd/config_helper.gopkg/subcmd/integration.gopkg/subcmd/topology.gopkg/subcmd/modules.gopkg/subcmd/integration_artifactory.gopkg/framework/mcpserver/mcpserver.gopkg/resolver/annotations.gopkg/subcmd/template.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_gitlab.gopkg/resolver/topology_test.gopkg/subcmd/integration_quay.gopkg/framework/app.gopkg/mcptools/configtools.gopkg/subcmd/mcpserver.go
pkg/resolver/**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Use
pkg/resolverto define the dependency topology, including the sequence of Helm Charts and relationships between them and required integrations
Files:
pkg/resolver/collection.gopkg/resolver/dependency.gopkg/resolver/annotations.gopkg/resolver/topology_test.go
pkg/subcmd/**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
pkg/subcmd/**/*.go: Usecobralibrary for CLI command structure in the tssc-cli project
Define commands as structs inpkg/subcmdthat implement a common interface
Use specificvalidateFlags()methods for flag logic (e.g., mutual exclusion) rather than relying only on Cobra's built-in validators
Inject dependencies likek8s.Kubeandchartfs.ChartFSvia constructors in command structs
Files:
pkg/subcmd/integration_nexus.gopkg/subcmd/config.gopkg/subcmd/integration_github.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/deploy.gopkg/subcmd/config_helper.gopkg/subcmd/integration.gopkg/subcmd/topology.gopkg/subcmd/modules.gopkg/subcmd/integration_artifactory.gopkg/subcmd/template.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_quay.gopkg/subcmd/mcpserver.go
**/*_test.go
📄 CodeRabbit inference engine (GEMINI.md)
Use the standard
testingpackage withgithub.com/onsi/gomegaassertion library for tests
Files:
pkg/resolver/topology_test.go
🧠 Learnings (19)
📓 Common learnings
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Inject dependencies like `k8s.Kube` and `chartfs.ChartFS` via constructors in command structs
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/resolver/**/*.go : Use `pkg/resolver` to define the dependency topology, including the sequence of Helm Charts and relationships between them and required integrations
Applied to files:
pkg/resolver/collection.gopkg/subcmd/config.gopkg/subcmd/deploy.gopkg/resolver/dependency.gopkg/subcmd/integration.gopkg/subcmd/topology.gopkg/resolver/annotations.gopkg/subcmd/template.gopkg/resolver/topology_test.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Inject dependencies like `k8s.Kube` and `chartfs.ChartFS` via constructors in command structs
Applied to files:
pkg/resolver/collection.gopkg/subcmd/integration_nexus.gopkg/subcmd/config.gopkg/mcptools/context.gocmd/tssc/main.gopkg/subcmd/integration_github.gopkg/installer/job.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/deploy.gopkg/resolver/dependency.gopkg/subcmd/config_helper.gopkg/subcmd/integration.gopkg/subcmd/topology.gopkg/subcmd/modules.gopkg/subcmd/integration_artifactory.gopkg/subcmd/template.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_gitlab.gopkg/resolver/topology_test.gopkg/subcmd/integration_quay.gopkg/framework/app.gopkg/subcmd/mcpserver.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/engine/**/*.go : Use Helm SDK in `pkg/engine` for Helm engine implementation, chart installation, templating functions, and installation lifecycle management
Applied to files:
pkg/resolver/collection.gopkg/subcmd/config.gocmd/tssc/main.gopkg/subcmd/integration_github.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/subcmd/topology.gopkg/subcmd/template.gopkg/resolver/topology_test.gopkg/framework/app.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/chartfs/**/*.go : Implement `io.FS` compatible abstraction in `pkg/chartfs` to provide access to embedded installer directory resources
Applied to files:
pkg/resolver/collection.gopkg/subcmd/config.gocmd/tssc/main.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/subcmd/topology.gopkg/subcmd/template.gopkg/resolver/topology_test.gopkg/framework/app.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Use `cobra` library for CLI command structure in the tssc-cli project
Applied to files:
pkg/resolver/collection.gopkg/subcmd/integration_nexus.gopkg/subcmd/config.gocmd/tssc/main.gopkg/subcmd/integration_github.gopkg/installer/job.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/deploy.gopkg/subcmd/config_helper.gopkg/subcmd/integration.gopkg/subcmd/topology.gopkg/subcmd/modules.gopkg/subcmd/integration_artifactory.gopkg/subcmd/template.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_quay.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Enable and follow linters: asciicheck, dogsled, dupword, errorlint, goconst, misspell, nakedret, nolintlint, revive, staticcheck, testifylint, unconvert, usestdlibvars, whitespace
Applied to files:
pkg/resolver/collection.gopkg/subcmd/integration_nexus.gopkg/subcmd/config.gopkg/subcmd/integration_github.gopkg/installer/job.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/subcmd/topology.gopkg/subcmd/integration_artifactory.gopkg/subcmd/template.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_quay.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/integration/**/*.go : Define integrations in `pkg/integration` to connect to external services like GitHub, Quay, etc.
Applied to files:
pkg/subcmd/integration_nexus.gopkg/subcmd/config.gopkg/subcmd/integration_github.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/subcmd/topology.gopkg/subcmd/modules.gopkg/subcmd/integration_artifactory.gopkg/subcmd/template.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_quay.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Define commands as structs in `pkg/subcmd` that implement a common interface
Applied to files:
pkg/subcmd/integration_nexus.gopkg/subcmd/config.gocmd/tssc/main.gopkg/subcmd/integration_github.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/subcmd/modules.gopkg/subcmd/integration_artifactory.gopkg/subcmd/template.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_quay.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Define interface definition at the top of service files, followed by service struct and implementation
Applied to files:
pkg/subcmd/integration_nexus.gopkg/subcmd/config.gopkg/subcmd/integration_github.gopkg/installer/job.gopkg/subcmd/integration_trustedartifactsigner.gopkg/subcmd/deploy.gopkg/subcmd/integration.gopkg/subcmd/topology.gopkg/subcmd/integration_artifactory.gopkg/subcmd/template.gopkg/subcmd/integration_bitbucket.gopkg/subcmd/integration_trustification.gopkg/subcmd/integration_gitlab.gopkg/subcmd/integration_quay.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*_test.go : All tests must use the `testing` package with `testify/assert` library
Applied to files:
pkg/subcmd/config.gopkg/subcmd/integration_github.gopkg/subcmd/topology.gopkg/subcmd/template.gopkg/resolver/topology_test.go
📚 Learning: 2025-08-20T15:48:01.881Z
Learnt from: Roming22
Repo: redhat-appstudio/tssc-cli PR: 1159
File: installer/charts/tssc-dh/Chart.yaml:5-6
Timestamp: 2025-08-20T15:48:01.881Z
Learning: In the tssc-cli project, chart version bumps in Chart.yaml files are handled at code freeze rather than immediately when appVersion changes, as part of their coordinated release process.
Applied to files:
cmd/tssc/main.go
📚 Learning: 2025-09-29T15:10:13.650Z
Learnt from: lingyzhuang
Repo: redhat-appstudio/tssc-cli PR: 1276
File: pkg/config/config.go:159-185
Timestamp: 2025-09-29T15:10:13.650Z
Learning: In the tssc-cli project, the UpdateMappingValue method in pkg/config/config.go should only update existing configuration keys and not create new ones. Adding new config entries is not allowed, so silent return when key is not found is the desired behavior.
Applied to files:
cmd/tssc/main.gopkg/mcptools/configtools.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to **/*.go : Use `go:embed` directive to embed `installer` directory resources (Helm charts, configurations, values.yaml.tpl) in the executable
Applied to files:
cmd/tssc/main.gopkg/subcmd/deploy.gopkg/framework/app.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Do not use `interface{}`, use the `any` alias instead
Applied to files:
pkg/subcmd/integration_github.gopkg/installer/job.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Do not use `int`, use `int64` instead (applies to both slices and maps)
Applied to files:
pkg/installer/job.go
📚 Learning: 2025-08-27T18:30:02.411Z
Learnt from: Roming22
Repo: redhat-appstudio/tssc-cli PR: 1190
File: pkg/resolver/resolver_test.go:52-67
Timestamp: 2025-08-27T18:30:02.411Z
Learning: In tssc-cli, there is a distinction between deployment namespace (where resources are deployed, referenced in values.yaml.tpl) and chart registration namespace (where Helm charts are registered, tested in resolver tests). These are different concepts and may use different namespace values.
Applied to files:
pkg/subcmd/deploy.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to **/*_test.go : Use the standard `testing` package with `github.com/onsi/gomega` assertion library for tests
Applied to files:
pkg/resolver/topology_test.go
📚 Learning: 2025-09-29T14:49:45.227Z
Learnt from: lingyzhuang
Repo: redhat-appstudio/tssc-cli PR: 1276
File: pkg/mcptools/configtools.go:0-0
Timestamp: 2025-09-29T14:49:45.227Z
Learning: In pkg/mcptools/configtools.go, the SettingsArg and ProductsArg constants are used for Gemini input generation, where Gemini uses these parameter names to generate input and the system reads the input content by these argument names.
Applied to files:
pkg/mcptools/configtools.go
🧬 Code graph analysis (19)
pkg/resolver/collection.go (2)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/resolver/dependency.go (2)
Dependency(15-19)NewDependency(108-110)
pkg/mcptools/context.go (5)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/flags/flags.go (1)
Flags(17-24)pkg/chartfs/chartfs.go (1)
ChartFS(15-17)pkg/k8s/kube.go (1)
Kube(21-23)pkg/integrations/manager.go (1)
Manager(20-23)
cmd/tssc/main.go (8)
pkg/framework/tarfs.go (1)
NewTarFS(11-13)installer/embed.go (1)
InstallerTarball(9-9)pkg/chartfs/overlay.go (1)
NewOverlayFS(17-22)pkg/chartfs/chartfs.go (1)
New(98-100)pkg/api/appcontext.go (4)
NewAppContext(84-99)WithVersion(54-58)WithCommitID(61-65)WithShortDescription(68-72)pkg/framework/app.go (1)
NewApp(156-179)pkg/framework/options.go (2)
WithIntegrations(14-18)WithMCPImage(21-25)pkg/subcmd/modules.go (1)
StandardModules(125-139)
pkg/subcmd/integration_github.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/api/subcommand.go (1)
SubCommand(9-22)pkg/config/manager.go (1)
Name(25-25)
pkg/installer/job.go (1)
pkg/api/appcontext.go (1)
AppContext(13-22)
pkg/subcmd/deploy.go (4)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/integrations/manager.go (1)
Manager(20-23)pkg/resolver/topologybuilder.go (1)
TopologyBuilder(15-19)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/resolver/dependency.go (2)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/resolver/annotations.go (6)
AnnotationDependsOn(27-29)AnnotationWeight(32-34)AnnotationProductName(21-23)AnnotationUseProductNamespace(38-40)AnnotationIntegrationsProvided(44-46)AnnotationIntegrationsRequired(50-52)
pkg/subcmd/config_helper.go (4)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/k8s/kube.go (1)
Kube(21-23)pkg/subcmd/config.go (1)
Config(20-36)pkg/config/manager.go (2)
NewConfigMapManager(176-180)Name(25-25)
pkg/subcmd/integration.go (4)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/integrations/manager.go (2)
Manager(20-23)IntegrationName(15-15)pkg/resolver/collection.go (1)
NewCollection(100-130)pkg/api/subcommand.go (1)
NewRunner(36-47)
pkg/subcmd/integration_artifactory.go (2)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/framework/mcpserver/mcpserver.go (2)
pkg/subcmd/mcpserver.go (2)
NewMCPServer(89-116)MCPServer(19-29)pkg/api/appcontext.go (1)
AppContext(13-22)
pkg/resolver/annotations.go (1)
pkg/api/appcontext.go (1)
AppContext(13-22)
pkg/subcmd/template.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/api/subcommand.go (1)
SubCommand(9-22)pkg/resolver/dependency.go (1)
NewDependencyWithNamespace(114-118)
pkg/subcmd/integration_bitbucket.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/subcmd/config.go (1)
Config(20-36)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/integration_trustification.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/subcmd/config.go (1)
Config(20-36)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/subcmd/integration_gitlab.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/subcmd/config.go (1)
Config(20-36)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/resolver/topology_test.go (3)
pkg/chartfs/chartfs.go (1)
New(98-100)pkg/api/appcontext.go (1)
NewAppContext(84-99)pkg/resolver/dependency.go (1)
NewDependencyWithNamespace(114-118)
pkg/subcmd/integration_quay.go (3)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/subcmd/config.go (1)
Config(20-36)pkg/api/subcommand.go (1)
SubCommand(9-22)
pkg/framework/app.go (15)
pkg/api/appcontext.go (1)
AppContext(13-22)pkg/chartfs/chartfs.go (1)
ChartFS(15-17)pkg/api/types.go (1)
IntegrationModule(13-28)pkg/integrations/manager.go (2)
Manager(20-23)NewManager(112-117)pkg/flags/flags.go (2)
Flags(17-24)NewFlags(72-93)pkg/k8s/kube.go (2)
Kube(21-23)NewKube(143-145)pkg/subcmd/integration.go (1)
NewIntegration(16-83)pkg/subcmd/mcptools.go (1)
StandardMCPToolsBuilder(13-15)pkg/api/subcommand.go (2)
SubCommand(9-22)NewRunner(36-47)pkg/subcmd/config.go (1)
NewConfig(284-309)pkg/subcmd/deploy.go (1)
NewDeploy(194-219)pkg/subcmd/installer.go (1)
NewInstaller(217-236)pkg/subcmd/mcpserver.go (1)
NewMCPServer(89-116)pkg/subcmd/template.go (1)
NewTemplate(150-186)pkg/subcmd/topology.go (1)
NewTopology(86-105)
🔇 Additional comments (55)
pkg/mcptools/context.go (2)
14-27: LGTM! Well-designed context struct for MCP tools.The MCPToolsContext follows a clean dependency injection pattern with all necessary components for MCP tool creation. The public fields are appropriate for a context struct that serves as a parameter object.
31-49: Excellent enforcement of MCP STDIO protocol requirements.The constructor correctly forces
io.Discardfor the logger (line 42), preventing any stdout/stderr output that would corrupt the MCP protocol. The inline documentation (lines 16-18 and 41) clearly explains this critical requirement.pkg/resolver/topology_test.go (2)
16-19: LGTM! Test properly updated for new ChartFS and AppContext APIs.The migration from
chartfs.NewChartFS("../../installer")tochartfs.New(os.DirFS("../../installer"))aligns with the refactoring to usefs.FSinterface. The addition ofappCtxinitialization (line 19) correctly provides the required context for dependency construction.
23-35: Consistent AppContext propagation in test.All
NewDependencyWithNamespacecalls have been properly updated to include theappCtxparameter, maintaining consistency throughout the test.pkg/subcmd/config_helper.go (1)
14-31: Verify all callers of bootstrapConfig have been updated.The function signature changed from
bootstrapConfig(ctx context.Context, kube *k8s.Kube)tobootstrapConfig(ctx context.Context, appCtx *api.AppContext, kube *k8s.Kube). This is a breaking API change that requires the newappCtxparameter. The dynamic error messaging usingappCtx.Nameis a good improvement over hardcoded constants.pkg/resolver/collection.go (1)
100-106: All callers of NewCollection have been properly updated.Verification confirms all 6 call sites across the codebase pass the new
appCtxparameter as the first argument (topology.go, integration.go, config.go, topologybuilder.go, and both test files). No outdated calls remain.pkg/framework/mcpserver/mcpserver.go (1)
24-33: All callers properly provide required parameters.Verification confirms that the only caller of
NewMCPServer(atpkg/subcmd/mcpserver.go:82) correctly provides both theappCtxwithNameandVersionfields and theinstructionsstring. Instructions are dynamically loaded from file storage, not hardcoded, ensuring proper separation of configuration and code.cmd/tssc/main.go (2)
20-35: LGTM! Clean initialization with proper error handling.The filesystem setup correctly handles errors for both tarball reading and working directory retrieval. The overlay filesystem composition (embedded tarball + local cwd) follows the expected pattern for the framework refactor.
53-67: LGTM! Framework wiring follows the new architecture.The application is properly constructed with
AppContext,ChartFS, integrations, and MCP image. Error handling paths are appropriate. Dependencies are correctly injected via constructors as per coding guidelines.pkg/subcmd/integration_bitbucket.go (2)
17-26: LGTM! AppContext integration follows the established pattern.The struct correctly adds
appCtxfield and implementsapi.SubCommand. This aligns with the PR's goal of centralizing application metadata and follows the coding guideline to inject dependencies via constructors.
60-81: LGTM! Constructor properly injects all dependencies.The constructor signature correctly accepts
appCtxas the first parameter, consistent with other integration subcommands. Dependencies (logger,kube,integration) are properly injected as per coding guidelines.pkg/subcmd/template.go (2)
18-38: LGTM! Template struct properly extended with AppContext.The struct correctly incorporates
appCtxand implementsapi.SubCommand. The field ordering is consistent with other subcommands in the package.
74-93: LGTM! Complete method properly propagates AppContext.Both
NewDependencyWithNamespaceandbootstrapConfigcorrectly receiveappCtx, enabling app-scoped naming and configuration throughout the dependency resolution and bootstrap flows.pkg/subcmd/integration.go (2)
16-22: LGTM! Function signature properly expanded for framework wiring.The constructor now accepts
appCtxandmanager, enabling dynamic integration loading. This aligns with the PR's goal of a modular plugin system.
76-80: The concern is unfounded;manager.Integration()cannot return nil.The
Integration()method inpkg/integrations/manager.go(lines 40-45) either returns a valid*integration.Integrationor panics if the integration is not found. It explicitly checks the map and callspanic()if the integration instance doesn't exist, making it impossible for nil to be returned.pkg/subcmd/integration_artifactory.go (2)
15-29: LGTM! Consistent with the integration subcommand pattern.The struct properly adds
appCtxand implementsapi.SubCommand, matching the pattern established across other integration files.
63-84: LGTM! Constructor follows dependency injection guidelines.Dependencies are properly injected via the constructor, consistent with coding guidelines for
pkg/subcmd/**/*.go.pkg/installer/job.go (2)
300-308: LGTM! Constructor properly derives instance-specific values from AppContext.The constructor correctly extracts
appNameandrepoURIfrom the providedAppContext, enabling per-instance resource naming and labeling. This supports the framework's goal of running multiple installations.
29-32: Label value validation still missing.The
LabelSelector()returns"installer-job." + j.repoURIwhererepoURIis derived fromappCtx.RepoURI(). Kubernetes label values must not exceed 63 characters and must match^(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?$. There's no validation to ensure the combined label value conforms to these constraints.Consider adding validation in
NewJobor inAppContextconstruction to prevent runtime failures when applying labels.Likely an incorrect or invalid review comment.
pkg/subcmd/integration_gitlab.go (2)
15-26: LGTM! Consistent AppContext integration.The struct correctly adds
appCtxand implementsapi.SubCommand, following the same pattern as other integration subcommands.
60-81: LGTM! Constructor properly wired with AppContext.Dependencies are correctly injected via the constructor, and
appCtxis properly stored for use inComplete. This follows the established pattern and coding guidelines.pkg/subcmd/integration_quay.go (1)
6-7: LGTM! Clean refactoring to centralize AppContext.The changes consistently propagate
appCtxthrough the constructor, struct fields, andbootstrapConfiginvocation, aligning with the framework-wide migration toapi.SubCommand. The dependency injection pattern follows coding guidelines.Also applies to: 19-19, 26-26, 56-56, 73-73, 86-86
pkg/subcmd/integration_trustification.go (1)
6-7: LGTM! Consistent with the AppContext refactoring pattern.The changes mirror the pattern in
integration_quay.goand other subcommands, ensuring uniform propagation ofappCtxthroughout the integration commands.Also applies to: 19-19, 26-26, 44-44, 62-62, 75-75
pkg/subcmd/config.go (1)
7-7: LGTM! Excellent migration to centralized AppContext.Key improvements:
- Line 85: Replacing hardcoded
constants.Namespacewithc.appCtx.Namespaceimproves configurability- Line 178: Passing
appCtxtoresolver.NewCollectionaligns with the new collection signature- Lines 285,290: Return type changed to
api.SubCommandenables framework-level abstractionsThe refactoring is systematic and preserves the existing logic while adding the centralized context.
Also applies to: 26-26, 38-38, 85-85, 178-178, 285-285, 290-290, 302-302
pkg/subcmd/integration_trustedartifactsigner.go (1)
6-7: LGTM! Consistent AppContext integration.The refactoring follows the established pattern across all integration subcommands, maintaining consistency in how
appCtxis threaded through constructors and bootstrap flows.Also applies to: 19-19, 26-26, 42-42, 60-60, 73-73
pkg/subcmd/topology.go (1)
7-7: LGTM! Well-integrated AppContext refactoring.The changes properly thread
appCtxthrough bothresolver.NewCollection(line 57) andbootstrapConfig(line 61), ensuring the topology command has consistent access to application metadata throughout its lifecycle.Also applies to: 21-21, 29-29, 57-57, 61-61, 87-87, 100-100
pkg/resolver/dependency.go (2)
15-19: LGTM!The
Dependencystruct properly includes theappCtxfield with clear comments. The field ordering is logical and the integration with the annotation lookup methods is consistent.
62-104: LGTM!All annotation lookup methods consistently use the
appCtx-aware annotation functions. The error message inWeight()correctly references the dynamic annotation key.pkg/subcmd/integration_github.go (3)
18-28: LGTM!The struct properly includes
appCtxfield and follows the coding guideline of defining commands as structs that implement a common interface. Dependencies are correctly injected via the constructor.
51-91: LGTM!The
Completemethod properly passesappCtxtobootstrapConfig, andRuncorrectly usesg.appCtx.Namefor dynamic application branding in the panic message.
95-123: LGTM!The constructor properly injects dependencies including
appCtx,logger,kube, andintegration. This follows the coding guideline of injecting dependencies via constructors in command structs. Based on learnings, this is the expected pattern.pkg/subcmd/integration_nexus.go (2)
17-26: LGTM!The struct properly includes the
appCtxfield and implementsapi.SubCommand. Consistent with the pattern used across other integration subcommands.
60-81: LGTM!The constructor correctly injects
appCtxand other dependencies following the established pattern. TheCompletemethod properly passesappCtxtobootstrapConfig.pkg/subcmd/deploy.go (4)
22-36: LGTM!The
Deploystruct properly includesappCtxandmanagerfields with appropriate comments. The struct follows the coding guideline of defining commands that implement a common interface.
76-92: LGTM!The
Completemethod correctly passesappCtxandmanagertoNewTopologyBuilderandappCtxtobootstrapConfig. The integration with the new architecture is properly wired.
114-128: LGTM!The error message correctly uses
d.appCtx.Namefor dynamic application branding, enabling the framework to be reused across different installer applications.
193-218: LGTM!The constructor properly injects all dependencies (
appCtx,logger,flags,cfs,kube,manager) and returnsapi.SubCommand. This follows the coding guideline of injecting dependencies via constructors in command structs. Based on learnings, this is the expected pattern.pkg/subcmd/modules.go (3)
1-10: LGTM!The imports are well-organized and the file establishes a clean module registry pattern for integration modules.
12-122: LGTM!The module definitions follow a consistent pattern with
Name,Init, andCommandfields. Each module properly wires its integration logic and CLI subcommand. The varying signatures inInitfunctions (some using logger/kube, others not) appropriately reflect the different initialization requirements of each integration.
124-139: LGTM!
StandardModules()provides a clean aggregation of all standard integration modules. The fixed ordering ensures consistent behavior across the CLI.pkg/framework/app.go (3)
18-33: LGTM!The
Appstruct is well-designed as the central entry point for the installer framework. Public fields (AppCtx,ChartFS) expose necessary metadata while private fields encapsulate runtime dependencies. The comment clearly explains the struct's purpose.
35-43: LGTM!The
Command()andRun()methods provide clean access to Cobra functionality, following the established pattern in the codebase.
45-148: LGTM!The
setupRootCmdmethod is well-structured:
- Properly handles short description fallback (lines 48-51)
- Configures version and help handling (lines 64-71)
- Creates logger after flags are applied (line 73)
- Loads integrations with proper error handling (lines 76-81)
- Validates MCP image configuration (lines 95-98)
- Registers all subcommands via
api.Runner(lines 144-146)The subcommand wiring follows the coding guideline of using the cobra library for CLI structure.
pkg/resolver/annotations.go (2)
9-17: LGTM!The suffix constants are well-named and clearly document the annotation key structure. Using unexported constants keeps the implementation details encapsulated.
19-52: LGTM!The annotation functions follow a consistent pattern and properly delegate to
appCtx.RepoURI()for dynamic key generation. The documentation clearly explains each function's purpose. This refactoring enables the framework to support multiple applications with different annotation prefixes.Note: Nil-safety for
appCtxshould be enforced at construction time (inNewDependency) rather than in each annotation function to avoid redundant checks.pkg/subcmd/mcpserver.go (3)
31-31: LGTM: Compile-time interface verification.Good use of compile-time assertion to ensure
MCPServercorrectly implementsapi.SubCommand.
58-86: LGTM: Well-structured MCP server initialization.The
Run()method follows a clear, logical flow:
- Creates tools context with
io.Discardlogger (critical for MCP STDIO protocol)- Builds tools via the injected builder
- Reads embedded instructions
- Constructs and starts the server
Error handling is appropriate, and passing
appCtxtomcpserver.NewMCPServer(line 82) correctly addresses the previous critical issue about dynamic branding.
88-116: LGTM: Correct dependency injection pattern.The constructor properly injects all dependencies (
k8s.Kube,chartfs.ChartFS,integrations.Manager, builder, etc.) and initializes all struct fields. This follows the established pattern for command structs in this codebase.Based on learnings, this correctly implements the dependency injection approach for command constructors.
pkg/mcptools/configtools.go (7)
9-10: LGTM! Imports support the framework refactoring.The new imports for
api.AppContextandchartfs.ChartFScorrectly support the architectural changes to enable dynamic application naming and filesystem abstraction.
19-32: LGTM! Struct changes support framework architecture.The addition of
appNameandcfsfields enables dynamic application naming and filesystem abstraction, aligning with the PR's goal to create a reusable installer framework.Based on learnings, dependencies are properly structured for constructor injection.
34-47: LGTM! Suffix-based naming enables framework reusability.The refactoring from full tool names to suffix constants enables dynamic tool naming across different applications, which is essential for the framework architecture.
104-167: LGTM! Dynamic naming integrated correctly.The
initHandlercorrectly usesc.appNamefor dynamic messaging and tool references, supporting the framework's reusability goal.
445-569: LGTM! Tool registration properly implements dynamic naming.All MCP tools are correctly registered with dynamic names (
appName + suffix) and descriptions that reference the application name, enabling framework reusability across different applications.
571-594: LGTM! Constructor follows dependency injection pattern.The updated constructor properly accepts
appCtxandcfsparameters, extracting application metadata and storing injected dependencies. This follows the established pattern for dependency injection via constructors.Based on learnings, this approach correctly injects dependencies like
chartfs.ChartFSandk8s.Kubevia constructors in command structs.
82-84: Remove the unnecessaryconfig.NewConfigDefaultcall at line 82.The
cfgvariable is assigned but never used. The function immediately usesc.defaultCfg(initialized at line 580 with the proper namespace) instead. This assignment is redundant dead code.
|
/retest |
|
@otaviof: This pull request references RHTAP-6103 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In @installer/charts/tssc-app-namespaces/Chart.yaml:
- Around line 7-8: Update all remaining references to the old annotation
namespace to the new helmet namespace: in docs/topology.md replace occurrences
of "tssc.redhat-appstudio.github.com" with "helmet.redhat-appstudio.github.com"
to keep documentation consistent, and in Go source update constants/strings
where they reference the old annotations—change
"tssc.redhat-appstudio.github.com/config" in pkg/config/manager.go and
"tssc.redhat-appstudio.github.com/post-deploy=delete" in
pkg/k8s/delete_resources.go to use "helmet.redhat-appstudio.github.com/config"
and "helmet.redhat-appstudio.github.com/post-deploy=delete" respectively; run
tests and linting to ensure no remaining usages of the old namespace.
In @installer/charts/tssc-integrations/Chart.yaml:
- Around line 7-8: The repo was partially migrated to the new annotation
namespace but critical consumers still reference the old
tssc.redhat-appstudio.github.com; update all occurrences to
helmet.redhat-appstudio.github.com: change the label/annotation selectors in
pkg/k8s/delete_resources.go (label selector used for post-deploy deletion),
pkg/config/manager.go (label selector for config lookup), the Helm helper in
installer/charts/_common/_helpers.tpl (template generating post-deploy labels),
the selector in hack/deploy.sh, and all example annotations in docs/topology.md
to use helmet.redhat-appstudio.github.com so runtime lookups and generated
labels match the Chart.yaml annotations.
In @pkg/resolver/dependency.go:
- Line 18: Remove the unused appCtx field from the Dependency struct and drop
any constructor parameters or assignments that accept an *api.AppContext for it
(search for struct type Dependency and its constructor/new function); update any
code that constructs Dependency (e.g., NewDependency or similar factory
functions) to stop passing or storing appCtx, and remove related comments
referencing "annotation keys" from that struct to avoid stale documentation;
ensure no other references to appCtx remain in the resolver package and run
tests/build to confirm cleanup.
🧹 Nitpick comments (1)
pkg/installer/job.go (1)
29-32: Consider making this a package-level function or constant.The
LabelSelector()method doesn't access any instance fields and only uses the staticresolver.RepoURIconstant. This could be simplified to a package-level function or constant for clarity.However, if the instance method pattern is intentional for future extensibility or API consistency, the current implementation is acceptable.
♻️ Alternative implementation as package-level function
-// LabelSelector returns the label selector for installer jobs. -func (j *Job) LabelSelector() string { - return fmt.Sprintf("installer-job.%s", resolver.RepoURI) -} +// jobLabelSelector returns the label selector value for installer jobs. +func jobLabelSelector() string { + return fmt.Sprintf("installer-job.%s", resolver.RepoURI) +}Or as a package constant if the value is truly static:
+// jobLabelSelector is the label selector value for installer jobs. +const jobLabelSelector = "installer-job." + resolver.RepoURIThen update all usages from
j.LabelSelector()tojobLabelSelector()orjobLabelSelector.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
installer/charts/tssc-acs-test/Chart.yamlinstaller/charts/tssc-acs/Chart.yamlinstaller/charts/tssc-app-namespaces/Chart.yamlinstaller/charts/tssc-dh/Chart.yamlinstaller/charts/tssc-gitops/Chart.yamlinstaller/charts/tssc-iam/Chart.yamlinstaller/charts/tssc-infrastructure/Chart.yamlinstaller/charts/tssc-integrations/Chart.yamlinstaller/charts/tssc-pipelines/Chart.yamlinstaller/charts/tssc-tas/Chart.yamlinstaller/charts/tssc-tpa/Chart.yamlpkg/api/appcontext.gopkg/installer/job.gopkg/resolver/annotations.gopkg/resolver/dependency.go
🚧 Files skipped from review as they are similar to previous changes (2)
- pkg/api/appcontext.go
- pkg/resolver/annotations.go
🧰 Additional context used
📓 Path-based instructions (3)
**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Never hardcode Gemini API keys in source code; use environment variables or secure configuration management
Files:
pkg/resolver/dependency.goinstaller/charts/tssc-tas/Chart.yamlinstaller/charts/tssc-pipelines/Chart.yamlinstaller/charts/tssc-infrastructure/Chart.yamlinstaller/charts/tssc-tpa/Chart.yamlinstaller/charts/tssc-iam/Chart.yamlinstaller/charts/tssc-acs-test/Chart.yamlinstaller/charts/tssc-gitops/Chart.yamlinstaller/charts/tssc-dh/Chart.yamlpkg/installer/job.goinstaller/charts/tssc-acs/Chart.yamlinstaller/charts/tssc-app-namespaces/Chart.yamlinstaller/charts/tssc-integrations/Chart.yaml
**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Use
go:embeddirective to embedinstallerdirectory resources (Helm charts, configurations, values.yaml.tpl) in the executable
Files:
pkg/resolver/dependency.gopkg/installer/job.go
pkg/resolver/**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Use
pkg/resolverto define the dependency topology, including the sequence of Helm Charts and relationships between them and required integrations
Files:
pkg/resolver/dependency.go
🧠 Learnings (8)
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Inject dependencies like `k8s.Kube` and `chartfs.ChartFS` via constructors in command structs
Applied to files:
pkg/resolver/dependency.gopkg/installer/job.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/resolver/**/*.go : Use `pkg/resolver` to define the dependency topology, including the sequence of Helm Charts and relationships between them and required integrations
Applied to files:
pkg/resolver/dependency.gopkg/installer/job.go
📚 Learning: 2025-08-20T15:48:01.881Z
Learnt from: Roming22
Repo: redhat-appstudio/tssc-cli PR: 1159
File: installer/charts/tssc-dh/Chart.yaml:5-6
Timestamp: 2025-08-20T15:48:01.881Z
Learning: In the tssc-cli project, chart version bumps in Chart.yaml files are handled at code freeze rather than immediately when appVersion changes, as part of their coordinated release process.
Applied to files:
installer/charts/tssc-iam/Chart.yaml
📚 Learning: 2025-08-27T18:30:02.411Z
Learnt from: Roming22
Repo: redhat-appstudio/tssc-cli PR: 1190
File: pkg/resolver/resolver_test.go:52-67
Timestamp: 2025-08-27T18:30:02.411Z
Learning: In tssc-cli, there is a distinction between deployment namespace (where resources are deployed, referenced in values.yaml.tpl) and chart registration namespace (where Helm charts are registered, tested in resolver tests). These are different concepts and may use different namespace values.
Applied to files:
installer/charts/tssc-iam/Chart.yaml
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Use `cobra` library for CLI command structure in the tssc-cli project
Applied to files:
pkg/installer/job.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Define interface definition at the top of service files, followed by service struct and implementation
Applied to files:
pkg/installer/job.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Enable and follow linters: asciicheck, dogsled, dupword, errorlint, goconst, misspell, nakedret, nolintlint, revive, staticcheck, testifylint, unconvert, usestdlibvars, whitespace
Applied to files:
pkg/installer/job.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Do not use `interface{}`, use the `any` alias instead
Applied to files:
pkg/installer/job.go
🧬 Code graph analysis (1)
pkg/installer/job.go (3)
pkg/resolver/annotations.go (1)
RepoURI(5-5)pkg/subcmd/template.go (1)
Template(19-36)pkg/api/appcontext.go (1)
AppContext(9-16)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Red Hat Konflux / pr-e2e-tests / tssc-cli
🔇 Additional comments (10)
installer/charts/tssc-gitops/Chart.yaml (1)
9-10: LGTM!Annotation namespace migration from
tssc.redhat-appstudio.github.com/*tohelmet.redhat-appstudio.github.com/*is consistent with the framework rebranding. Values are preserved correctly.installer/charts/tssc-infrastructure/Chart.yaml (1)
8-8: LGTM!Annotation namespace migration is consistent with the broader refactoring effort.
installer/charts/tssc-tpa/Chart.yaml (1)
9-11: LGTM!Annotation namespace migration is consistent across all three annotation keys. Values are preserved correctly.
installer/charts/tssc-acs/Chart.yaml (1)
9-11: LGTM!Annotation namespace migration is consistent with the framework rebranding. All annotation values are preserved correctly.
installer/charts/tssc-tas/Chart.yaml (1)
9-11: LGTM!Annotation namespace migration is consistent with the other charts in this PR. Values are preserved correctly.
pkg/installer/job.go (3)
8-10: LGTM: Import additions support the refactor.The new imports for
pkg/apiandpkg/resolvercorrectly support the AppContext-based parameterization and static RepoURI usage introduced in this refactor.
57-57: LGTM: Consistent label selector usage.The
LabelSelector()method is used consistently across all relevant contexts: listing jobs, creating job metadata, pod template labels, and generating the log-follow command. This ensures uniform job identification and filtering.Also applies to: 224-224, 229-229, 260-260
301-307: NewJob signature change has been properly addressed.The signature change to accept
*api.AppContextis correctly implemented, and the one call site inpkg/subcmd/mcptools.go:47has been properly updated to pass the new parameters. No additional action is needed.pkg/resolver/dependency.go (2)
107-117: Constructor signatures properly updated to accept and propagate appCtx.The constructors correctly accept
appCtxand wire it through the dependency chain. However, the value of this change depends on whetherappCtxis actually utilized in the annotation accessor methods (see previous comment on line 18).
63-103: All annotation constants are properly defined and framework-aligned.The constants
AnnotationDependsOn,AnnotationWeight,AnnotationProductName,AnnotationUseProductNamespace,AnnotationIntegrationsProvided, andAnnotationIntegrationsRequiredare defined inpkg/resolver/annotations.go(lines 9-14) and properly exported. They all follow a consistent pattern usingRepoURI + "/annotation-name"whereRepoURI = "helmet.redhat-appstudio.github.com". The helper functioncommaSeparatedToSliceis also correctly defined inpkg/resolver/helper.go. No issues found.
Replace the dynamic `AppContext.RepoURI()` method with static constants to ensure every Helm chart will rely on framework's annotations and repository URI. Assisted-by: Claude
|
|
@otaviof: This pull request references RHTAP-6103 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
pkg/resolver/dependency_test.go (2)
12-19: Avoid cwd-sensitive../../installerin tests (can be flaky in some runners).
Consider resolving the installer directory relative to this test file instead of the process working directory.Proposed change
import ( "os" + "path/filepath" + "runtime" "testing" "github.com/redhat-appstudio/tssc-cli/pkg/chartfs" o "github.com/onsi/gomega" ) func TestNewDependency(t *testing.T) { g := o.NewWithT(t) - cfs := chartfs.New(os.DirFS("../../installer")) + _, thisFile, _, _ := runtime.Caller(0) + installerDir := filepath.Clean(filepath.Join(filepath.Dir(thisFile), "../../installer")) + cfs := chartfs.New(os.DirFS(installerDir)) developerHub, err := cfs.GetChartFiles("charts/tssc-dh") g.Expect(err).To(o.Succeed())
22-46: Optional: create a fresh Gomegagper subtest for cleaner failure attribution.
Right now assertions int.Run(...)still report through the parentt.Example pattern
t.Run("Chart", func(t *testing.T) { + g := o.NewWithT(t) g.Expect(d.Chart()).NotTo(o.BeNil()) })pkg/subcmd/mcptools.go (1)
17-91: Builder implementation follows good dependency injection pattern.The function properly injects dependencies from
toolsCtxand handles errors from constructors that can fail. This aligns with the coding guidelines for dependency injection in command structs.Optional: Consider defensive nil-checks.
The builder doesn't validate that required
toolsCtxfields (e.g.,Kube,ChartFS,IntegrationManager) are non-nil before use. If validation is the builder's responsibility rather than the caller's, consider adding checks to provide clearer error messages.Note: Coupling to Integration subcommand.
Lines 53-59 create an
Integrationsubcommand instance directly. This couples the MCP tools builder to the specific subcommand implementation, which may be intentional for the framework's design but reduces modularity if other consumers want different integration tooling.Based on learnings, the dependency injection pattern is correctly applied.
pkg/api/appcontext.go (1)
9-16: Consider validating theNameparameter.The
Namefield is foundational for application identity (used for namespace defaults, ConfigMap naming, etc.), butNewAppContextaccepts an empty string without validation. An empty name could propagate downstream issues.💡 Optional validation in NewAppContext
func NewAppContext(name string, opts ...ContextOption) *AppContext { + if name == "" { + panic("appcontext: name is required") + } appCtx := &AppContext{ Name: name, Namespace: name,
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (30)
docs/topology.mdhack/deploy.shinstaller/charts/_common/_helpers.tplinstaller/charts/tssc-acs-test/Chart.yamlinstaller/charts/tssc-acs/Chart.yamlinstaller/charts/tssc-app-namespaces/Chart.yamlinstaller/charts/tssc-dh/Chart.yamlinstaller/charts/tssc-gitops/Chart.yamlinstaller/charts/tssc-iam/Chart.yamlinstaller/charts/tssc-infrastructure/Chart.yamlinstaller/charts/tssc-integrations/Chart.yamlinstaller/charts/tssc-pipelines/Chart.yamlinstaller/charts/tssc-tas/Chart.yamlinstaller/charts/tssc-tpa/Chart.yamlpkg/annotations/annotations.gopkg/api/appcontext.gopkg/config/manager.gopkg/hooks/hooks_test.gopkg/installer/job.gopkg/k8s/delete_resources.gopkg/resolver/annotations.gopkg/resolver/collection.gopkg/resolver/dependency.gopkg/resolver/dependency_test.gopkg/resolver/topology_test.gopkg/subcmd/config.gopkg/subcmd/config_helper.gopkg/subcmd/integration.gopkg/subcmd/mcptools.gopkg/subcmd/template.go
💤 Files with no reviewable changes (1)
- pkg/resolver/annotations.go
🚧 Files skipped from review as they are similar to previous changes (11)
- installer/charts/tssc-acs-test/Chart.yaml
- hack/deploy.sh
- pkg/resolver/dependency.go
- installer/charts/tssc-integrations/Chart.yaml
- pkg/resolver/collection.go
- installer/charts/tssc-dh/Chart.yaml
- pkg/resolver/topology_test.go
- installer/charts/tssc-gitops/Chart.yaml
- pkg/installer/job.go
- installer/charts/tssc-tpa/Chart.yaml
- installer/charts/tssc-app-namespaces/Chart.yaml
🧰 Additional context used
📓 Path-based instructions (5)
**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Never hardcode Gemini API keys in source code; use environment variables or secure configuration management
Files:
pkg/subcmd/mcptools.gopkg/k8s/delete_resources.gopkg/subcmd/integration.gopkg/api/appcontext.gopkg/config/manager.gopkg/resolver/dependency_test.gopkg/subcmd/config_helper.goinstaller/charts/tssc-iam/Chart.yamldocs/topology.mdinstaller/charts/tssc-pipelines/Chart.yamlpkg/subcmd/config.goinstaller/charts/tssc-infrastructure/Chart.yamlinstaller/charts/_common/_helpers.tplinstaller/charts/tssc-tas/Chart.yamlinstaller/charts/tssc-acs/Chart.yamlpkg/subcmd/template.gopkg/hooks/hooks_test.gopkg/annotations/annotations.go
pkg/subcmd/**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
pkg/subcmd/**/*.go: Usecobralibrary for CLI command structure in the tssc-cli project
Define commands as structs inpkg/subcmdthat implement a common interface
Use specificvalidateFlags()methods for flag logic (e.g., mutual exclusion) rather than relying only on Cobra's built-in validators
Inject dependencies likek8s.Kubeandchartfs.ChartFSvia constructors in command structs
Files:
pkg/subcmd/mcptools.gopkg/subcmd/integration.gopkg/subcmd/config_helper.gopkg/subcmd/config.gopkg/subcmd/template.go
**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Use
go:embeddirective to embedinstallerdirectory resources (Helm charts, configurations, values.yaml.tpl) in the executable
Files:
pkg/subcmd/mcptools.gopkg/k8s/delete_resources.gopkg/subcmd/integration.gopkg/api/appcontext.gopkg/config/manager.gopkg/resolver/dependency_test.gopkg/subcmd/config_helper.gopkg/subcmd/config.gopkg/subcmd/template.gopkg/hooks/hooks_test.gopkg/annotations/annotations.go
**/*_test.go
📄 CodeRabbit inference engine (GEMINI.md)
Use the standard
testingpackage withgithub.com/onsi/gomegaassertion library for tests
Files:
pkg/resolver/dependency_test.gopkg/hooks/hooks_test.go
pkg/resolver/**/*.go
📄 CodeRabbit inference engine (GEMINI.md)
Use
pkg/resolverto define the dependency topology, including the sequence of Helm Charts and relationships between them and required integrations
Files:
pkg/resolver/dependency_test.go
🧠 Learnings (20)
📓 Common learnings
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Inject dependencies like `k8s.Kube` and `chartfs.ChartFS` via constructors in command structs
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Inject dependencies like `k8s.Kube` and `chartfs.ChartFS` via constructors in command structs
Applied to files:
pkg/subcmd/mcptools.gopkg/subcmd/integration.gopkg/config/manager.gopkg/resolver/dependency_test.gopkg/subcmd/config_helper.gopkg/subcmd/config.gopkg/subcmd/template.gopkg/hooks/hooks_test.gopkg/annotations/annotations.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Define commands as structs in `pkg/subcmd` that implement a common interface
Applied to files:
pkg/subcmd/mcptools.gopkg/subcmd/integration.gopkg/subcmd/config_helper.gopkg/subcmd/config.gopkg/subcmd/template.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Use `cobra` library for CLI command structure in the tssc-cli project
Applied to files:
pkg/subcmd/mcptools.gopkg/subcmd/integration.gopkg/config/manager.gopkg/subcmd/config_helper.gopkg/subcmd/config.gopkg/subcmd/template.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/subcmd/**/*.go : Use specific `validateFlags()` methods for flag logic (e.g., mutual exclusion) rather than relying only on Cobra's built-in validators
Applied to files:
pkg/subcmd/mcptools.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Validate required parameters before making API calls
Applied to files:
pkg/subcmd/mcptools.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/integration/**/*.go : Define integrations in `pkg/integration` to connect to external services like GitHub, Quay, etc.
Applied to files:
pkg/subcmd/integration.gopkg/subcmd/config.gopkg/subcmd/template.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/resolver/**/*.go : Use `pkg/resolver` to define the dependency topology, including the sequence of Helm Charts and relationships between them and required integrations
Applied to files:
pkg/subcmd/integration.gopkg/resolver/dependency_test.godocs/topology.mdpkg/subcmd/config.gopkg/subcmd/template.gopkg/hooks/hooks_test.gopkg/annotations/annotations.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/chartfs/**/*.go : Implement `io.FS` compatible abstraction in `pkg/chartfs` to provide access to embedded installer directory resources
Applied to files:
pkg/subcmd/integration.gopkg/resolver/dependency_test.gopkg/subcmd/config.gopkg/subcmd/template.gopkg/hooks/hooks_test.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to pkg/engine/**/*.go : Use Helm SDK in `pkg/engine` for Helm engine implementation, chart installation, templating functions, and installation lifecycle management
Applied to files:
pkg/subcmd/integration.gopkg/subcmd/config.gopkg/subcmd/template.gopkg/hooks/hooks_test.gopkg/annotations/annotations.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Enable and follow linters: asciicheck, dogsled, dupword, errorlint, goconst, misspell, nakedret, nolintlint, revive, staticcheck, testifylint, unconvert, usestdlibvars, whitespace
Applied to files:
pkg/subcmd/integration.gopkg/config/manager.gopkg/subcmd/config.gopkg/subcmd/template.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*.go : Define interface definition at the top of service files, followed by service struct and implementation
Applied to files:
pkg/subcmd/integration.gopkg/config/manager.gopkg/subcmd/config.gopkg/subcmd/template.go
📚 Learning: 2025-08-20T15:48:01.881Z
Learnt from: Roming22
Repo: redhat-appstudio/tssc-cli PR: 1159
File: installer/charts/tssc-dh/Chart.yaml:5-6
Timestamp: 2025-08-20T15:48:01.881Z
Learning: In the tssc-cli project, chart version bumps in Chart.yaml files are handled at code freeze rather than immediately when appVersion changes, as part of their coordinated release process.
Applied to files:
installer/charts/tssc-iam/Chart.yamlinstaller/charts/tssc-pipelines/Chart.yamlinstaller/charts/tssc-infrastructure/Chart.yamlinstaller/charts/tssc-tas/Chart.yamlinstaller/charts/tssc-acs/Chart.yaml
📚 Learning: 2025-08-27T18:30:02.411Z
Learnt from: Roming22
Repo: redhat-appstudio/tssc-cli PR: 1190
File: pkg/resolver/resolver_test.go:52-67
Timestamp: 2025-08-27T18:30:02.411Z
Learning: In tssc-cli, there is a distinction between deployment namespace (where resources are deployed, referenced in values.yaml.tpl) and chart registration namespace (where Helm charts are registered, tested in resolver tests). These are different concepts and may use different namespace values.
Applied to files:
installer/charts/tssc-iam/Chart.yamldocs/topology.mdinstaller/charts/tssc-pipelines/Chart.yamlinstaller/charts/tssc-infrastructure/Chart.yamlinstaller/charts/tssc-tas/Chart.yamlinstaller/charts/tssc-acs/Chart.yaml
📚 Learning: 2025-09-29T21:21:23.787Z
Learnt from: Roming22
Repo: redhat-appstudio/tssc-cli PR: 1297
File: installer/charts/tssc-pipelines/templates/NOTES.txt:1-14
Timestamp: 2025-09-29T21:21:23.787Z
Learning: In the tssc-cli project's Helm NOTES templates, displaying sensitive values like webhook secrets in plain text is intentional behavior to help users with their configuration, as confirmed by the maintainer Roming22.
Applied to files:
installer/charts/tssc-iam/Chart.yamlinstaller/charts/tssc-pipelines/Chart.yamlinstaller/charts/tssc-tas/Chart.yamlinstaller/charts/tssc-acs/Chart.yaml
📚 Learning: 2025-08-13T14:29:50.296Z
Learnt from: dperaza4dustbit
Repo: redhat-appstudio/tssc-cli PR: 1133
File: installer/charts/tssc-infrastructure/values.yaml:26-26
Timestamp: 2025-08-13T14:29:50.296Z
Learning: The tssc-cli team uses "__OVERWRITE_ME__" as a placeholder convention in Helm chart values.yaml files, even when the field will be used in templates with range operations. This is their established team convention and should not be flagged as an issue.
Applied to files:
installer/charts/tssc-pipelines/Chart.yamlinstaller/charts/tssc-tas/Chart.yamlinstaller/charts/tssc-acs/Chart.yaml
📚 Learning: 2025-08-11T16:40:25.369Z
Learnt from: dperaza4dustbit
Repo: redhat-appstudio/tssc-cli PR: 1129
File: installer/charts/tssc-infrastructure/values.yaml:11-15
Timestamp: 2025-08-11T16:40:25.369Z
Learning: The team prefers using specific version tags instead of "latest" for container images to ensure stability and reproducibility in production environments.
Applied to files:
installer/charts/tssc-pipelines/Chart.yamlinstaller/charts/tssc-tas/Chart.yaml
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*_test.go : All tests must use the `testing` package with `testify/assert` library
Applied to files:
pkg/subcmd/config.gopkg/subcmd/template.gopkg/hooks/hooks_test.go
📚 Learning: 2025-12-10T16:04:55.706Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-10T16:04:55.706Z
Learning: Applies to **/*_test.go : Use the standard `testing` package with `github.com/onsi/gomega` assertion library for tests
Applied to files:
pkg/hooks/hooks_test.go
📚 Learning: 2025-11-24T19:55:52.646Z
Learnt from: CR
Repo: redhat-appstudio/tssc-cli PR: 0
File: vendor/gitlab.com/gitlab-org/api/client-go/AGENTS.md:0-0
Timestamp: 2025-11-24T19:55:52.646Z
Learning: Applies to vendor/gitlab.com/gitlab-org/api/client-go/**/*_test.go : Tests must be parallelized using `t.Parallel()`
Applied to files:
pkg/hooks/hooks_test.go
🧬 Code graph analysis (5)
pkg/subcmd/integration.go (5)
pkg/api/appcontext.go (1)
AppContext(9-16)pkg/integrations/manager.go (2)
Manager(20-23)IntegrationName(15-15)pkg/resolver/collection.go (1)
NewCollection(100-130)pkg/config/manager.go (1)
NewConfigMapManager(175-180)pkg/api/subcommand.go (1)
NewRunner(36-47)
pkg/config/manager.go (2)
pkg/annotations/annotations.go (1)
Config(16-16)pkg/constants/constants.go (1)
ConfigFilename(6-6)
pkg/resolver/dependency_test.go (1)
pkg/chartfs/chartfs.go (1)
New(98-100)
pkg/subcmd/config_helper.go (2)
pkg/api/appcontext.go (1)
AppContext(9-16)pkg/config/manager.go (1)
NewConfigMapManager(175-180)
pkg/subcmd/template.go (2)
pkg/api/appcontext.go (1)
AppContext(9-16)pkg/api/subcommand.go (1)
SubCommand(9-22)
🪛 LanguageTool
docs/topology.md
[uncategorized] ~76-~76: The official name of this software platform is spelled with a capital “H”.
Context: ...Example*: If the chart requires both github and trustification integrations: ``...
(GITHUB)
🪛 markdownlint-cli2 (0.18.1)
docs/topology.md
18-18: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
28-28: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
39-39: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
50-50: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
61-61: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
72-72: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Red Hat Konflux / tssc-cli-on-pull-request
🔇 Additional comments (38)
pkg/resolver/dependency_test.go (1)
3-10: Import change is fine.
No concerns with addingosforos.DirFS.pkg/subcmd/mcptools.go (2)
10-15: LGTM!Clean factory function with clear documentation. The separation between public entry point and internal implementation follows good Go practices.
47-47: No action needed.installer.NewJobis explicitly designed to return only*Jobwithout an error return type, unlikeNewConfigToolsandNewTopologyBuilderwhich return errors. This design difference is intentional; NewJob does not require error handling.Likely an incorrect or invalid review comment.
pkg/subcmd/integration.go (3)
16-22: LGTM!The updated signature correctly follows the dependency injection pattern, accepting
appCtxfor application context andmanagerfor the integration registry. This aligns with the framework refactor objectives.Based on coding guidelines, dependencies are properly injected via constructor parameters.
69-70: LGTM!The ConfigMapManager instantiation correctly uses
appCtx.Nameto derive the ConfigMap name dynamically, aligning with the refactored signature inpkg/config/manager.go(lines 174-179).
77-81: Type conversion is correct and necessary.The explicit conversion
integrations.IntegrationName(mod.Name)on line 78 is required by Go's type system. AlthoughIntegrationNameis a type alias forstring, Go treats named types distinctly from their underlying types. Themanager.Integration()method expects anIntegrationNameparameter, so the conversion is necessary and follows the pattern already established in the codebase (e.g., inManager.Register()).pkg/config/manager.go (6)
26-29: LGTM!The
Name()getter provides external access to the dynamically derived ConfigMap name, supporting the framework's parameterization goals.
108-123: LGTM!The refactored
configMapForConfigmethod correctly uses:
m.namefor dynamic ConfigMap naming (line 113)annotations.Configfor standardized labels (line 116)constants.ConfigFilenamefor the data key (line 120)This eliminates hardcoded values and aligns with the framework parameterization objectives.
174-179: LGTM!The updated signature parameterizes the ConfigMap name based on
appName, enabling framework reusability. The clear documentation on line 174 explains the naming convention.
88-105: LGTM!The
GetConfigmethod correctly usesconstants.ConfigFilenamefor both data lookup (line 93) and error reporting (line 98), ensuring consistency throughout the codebase.
43-85: LGTM!The
GetConfigMapmethod correctly uses the newSelectorconstant (lines 53, 64) for label-based queries, centralizing the selector logic and improving maintainability.
23-24: The annotations.Config constant is correctly configured.The
Selectorconstant resolves to"helmet.redhat-appstudio.github.com/config=true", which matches the expected label key. No compatibility issues were found with existing ConfigMaps, and the file contains no hardcoded API keys.pkg/k8s/delete_resources.go (1)
13-13: LGTM!The label selector correctly uses
annotations.PostDeployto maintain consistency with the Helm template update ininstaller/charts/_common/_helpers.tpl(line 49). This ensures post-deployment cleanup targets the right resources.installer/charts/_common/_helpers.tpl (1)
49-49: Helm label is consistent with Go constant annotation.The
helmet.redhat-appstudio.github.com/post-deploylabel correctly matches theannotations.PostDeployconstant defined asRepoURI + "/post-deploy"whereRepoURI = "helmet.redhat-appstudio.github.com". Post-deployment resource cleanup will function as intended.installer/charts/tssc-iam/Chart.yaml (1)
8-8: Dependency resolver correctly handles the updated annotation.The annotation namespace update is properly configured. The
DependsOnconstant inpkg/annotations/annotations.gois already defined ashelmet.redhat-appstudio.github.com/depends-on, andpkg/resolver/dependency.gouses this constant to read the annotation value, avoiding hardcoded keys. All charts are consistently updated with the new namespace.installer/charts/tssc-pipelines/Chart.yaml (1)
9-11: LGTM! Annotation namespace updated consistently.The annotation keys have been correctly updated from
tssc.redhat-appstudio.github.com/*tohelmet.redhat-appstudio.github.com/*as part of the framework refactor. The annotation values remain unchanged, ensuring continuity of the chart's metadata.pkg/hooks/hooks_test.go (3)
5-5: LGTM! Import additions support the refactored test.The
osandapiimports are correctly added to support the newos.DirFSusage andapi.NewAppContextinstantiation.Also applies to: 8-8
20-20: LGTM! ChartFS updated to use standard fs.FS interface.The refactor to
chartfs.New(os.DirFS("../../test"))correctly adopts the standardfs.FSinterface, making the ChartFS abstraction more generic and reusable.
25-27: LGTM! Test updated to use AppContext pattern.The test now correctly instantiates an
AppContextand uses itsNamespaceproperty instead of a global constant. This aligns with the framework refactor's goal of making the codebase more modular and testable.docs/topology.md (2)
18-80: LGTM! Documentation updated consistently with code changes.All annotation key references have been correctly updated from
tssc.redhat-appstudio.github.com/*tohelmet.redhat-appstudio.github.com/*, maintaining consistency with the Chart.yaml changes across the codebase.
94-95: LGTM! Namespace determination logic documentation updated.The documentation correctly reflects the updated annotation key prefix while maintaining the clarity of the namespace determination logic.
installer/charts/tssc-tas/Chart.yaml (1)
9-11: LGTM! Annotation namespace updated consistently.The annotation keys have been correctly updated from
tssc.redhat-appstudio.github.com/*tohelmet.redhat-appstudio.github.com/*, consistent with the framework-wide refactor.pkg/subcmd/config_helper.go (4)
8-8: LGTM! Import added to support AppContext parameter.The
apiimport is correctly added to support the new*api.AppContextparameter.
19-19: LGTM! ConfigMapManager initialization uses dynamic application name.The change from a hardcoded constant to
appCtx.Nameenables the config manager to work with different application contexts, supporting the framework refactor's goals.
22-29: LGTM! Error messages now use dynamic application name.The error messages have been correctly updated to use
appCtx.Name, making them contextually appropriate for different application instances while maintaining clarity for users.
14-18: Function signature supports dependency injection pattern.The addition of the
appCtx *api.AppContextparameter enables the function to work with different application contexts, and all callers have been properly updated to pass this parameter. The function usesappCtx.Nameto configure the ConfigMap manager, making this dependency necessary.installer/charts/tssc-infrastructure/Chart.yaml (1)
8-8: Annotation namespace migration looks correct.The annotation key update from
tssc.redhat-appstudio.github.com/depends-ontohelmet.redhat-appstudio.github.com/depends-onaligns with the centralizedannotations.DependsOnconstant defined inpkg/annotations/annotations.go.installer/charts/tssc-acs/Chart.yaml (1)
9-11: Annotation namespace migration is consistent.All three annotation keys (
product-name,depends-on,integrations-provided) correctly use the newhelmet.redhat-appstudio.github.comprefix, matching the corresponding constants inpkg/annotations/annotations.go.pkg/api/appcontext.go (1)
56-72: Well-structured factory with functional options pattern.The
NewAppContextfactory provides sensible defaults and follows idiomatic Go functional options pattern. The defaults forVersion("v0.0.0-SNAPSHOT") andCommitID("unknown") are appropriate for development builds.pkg/subcmd/template.go (3)
7-7: Correctly integratesAppContextinto Template subcommand.The changes properly:
- Import the
apipackage- Add
appCtxfield to theTemplatestruct- Update interface assertion to
api.SubCommandThis follows the coding guidelines for dependency injection via constructors and implementing a common interface.
Also applies to: 23-23, 38-38
89-92:bootstrapConfigcorrectly receivesappCtx.The
Completemethod properly passest.appCtxtobootstrapConfig, enabling app-context-aware configuration bootstrapping.
150-172: Constructor follows dependency injection pattern.
NewTemplatecorrectly acceptsappCtx *api.AppContextas the first parameter and injects it into theTemplatestruct. This aligns with the coding guidelines for injecting dependencies via constructors in command structs.pkg/subcmd/config.go (5)
7-7: Correctly integratesAppContextinto Config subcommand.The changes properly:
- Import the
apipackage- Add
appCtxfield to theConfigstruct- Update interface assertion to
api.SubCommandThis follows the coding guidelines for defining commands as structs that implement a common interface.
Also applies to: 26-26, 38-38
85-86: Dynamic namespace default is appropriate.Using
c.appCtx.Namespaceinstead of a static constant allows the namespace to be configured per-application, supporting the framework's goal of reusable installer applications.
178-181: Collection creation updated for app context.The
resolver.NewCollection(c.appCtx, charts)call correctly passes the application context, enabling the collection to derive app-specific metadata.
192-194: DRY-RUN output uses dynamic manager name.Using
c.manager.Name()andconfig.Selectorinstead of hardcoded values ensures consistent naming derived from the application context.
284-304: Constructor properly injects dependencies.
NewConfigcorrectly:
- Accepts
appCtx *api.AppContextas the first parameter- Returns
api.SubCommandinterface type- Initializes
ConfigMapManagerwithappCtx.Namefor dynamic namingThis aligns with the coding guidelines for injecting dependencies like
k8s.Kubeandchartfs.ChartFSvia constructors in command structs. Based on learnings.pkg/annotations/annotations.go (1)
1-17: Annotation constants are well-organized and migration is complete.This package cleanly consolidates all Helm chart annotation keys under a single
RepoURIprefix, eliminating scattered string literals across the codebase. The naming convention is consistent with Kubernetes annotation best practices (reverse domain notation).Migration from the old
tssc.redhat-appstudio.github.comprefix is complete—no legacy references remain in the codebase. The newhelmet.redhat-appstudio.github.comprefix is consistently used across all Chart.yaml files ininstaller/charts/.Note: The annotations package constants are currently defined but not yet imported in any Go code. Consider integrating package imports in Go consumers once they exist to avoid hardcoding annotation keys.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: otaviof, Roming22 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 594757b
into
redhat-appstudio:main
RHTAP-6103: Core Installer Framework
3 participants
This PR implements the core architectural changes required to transform tssc-cli into a reusable installer framework (RHTAP-6103). It decouples the specific TSSC logic from the underlying machinery, allowing other projects to consume this codebase to build custom installers with their own branding, Helm charts, and tools.
Key Changes:
Public Framework API (
pkg/framework):pkg/mcpservertopkg/framework/mcpserverto serve as the generic server wrapper.Generic Filesystem (
pkg/chartfs):NewTarFSutility to support creating filesystems from embedded tarballs (overcominggo:embedsymlink limitations).config.yaml,values.yaml.tpl, andinstructions.md.MCP Server Refactoring:
MCPToolsBuilderandMCPToolsContextto decouple tool creation from the server, allowing consumers to inject custom tools.AppNameacross the MCP stack so tools reflect the consumer's application name.io.Discardfor tool loggers to protect the MCP STDIO protocol.Dynamic Integrations (
pkg/integrations):api.IntegrationModuleto encapsulate integration logic and CLI commands, enabling dynamic registration viaWithIntegrations.Shared API (
pkg/api):SubCommandinterface and Runner topkg/apito break circular dependencies and expose them for external use.Summary by CodeRabbit
New Features
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.