Add log filters to reduce noise in production#11344
Open
raks-tt wants to merge 2 commits intoredhat-appstudio:mainfrom
Open
Add log filters to reduce noise in production#11344raks-tt wants to merge 2 commits intoredhat-appstudio:mainfrom
raks-tt wants to merge 2 commits intoredhat-appstudio:mainfrom
Conversation
Contributor
Kustomize Render DiffComparing
Total: 13 components, +1359 -3 lines 📋 Full diff available in the workflow summary and as a downloadable artifact. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11344 +/- ##
=======================================
Coverage 51.62% 51.62%
=======================================
Files 18 18
Lines 1263 1263
=======================================
Hits 652 652
Misses 539 539
Partials 72 72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/review |
PR Reviewer Guide 🔍(Review updated until commit beee9f3)Here are some key observations to aid the review process:
|
Review Summary by QodoAdd production log filters to reduce noise
WalkthroughsDescription• Add comprehensive log filters to ClusterLogForwarder for production • Drop Tekton reconciliation conflicts and optimistic locking errors • Filter finalizer cleanup, resource request, and label update failures • Remove admission controller, database, leader election, and TLS noise • Apply filters to both application and audit index pipelines Diagramflowchart LR
A["ClusterLogForwarder<br/>Configuration"] -->|"Add filters patch"| B["Filter Definitions"]
B -->|"drop-empty-lines"| C["Application &<br/>Audit Pipelines"]
B -->|"multiline-exception"| C
B -->|"Tekton/Kueue<br/>reconciliation"| C
B -->|"Finalizer/Resource<br/>cleanup"| C
B -->|"Leader election &<br/>TLS noise"| C
C -->|"Filtered logs"| D["Splunk Index"]
File Changes1. components/monitoring/logging/production/base/kustomization.yaml
|
Code Review by Qodo
1. Brittle pipeline index patch
|
Drop Tekton controller reconciliation conflicts, finalizer cleanup, duplicate database key errors , leader election locking conflicts, finalizers not found, resource requetes in progress, label update failures, admission controller nil annotations and TLS EOF noise
raks-tt
force-pushed
the
add_log_filters_prod
branch
from
8332153 to
beee9f3
Compare
Contributor
Author
|
/review |
|
Persistent review updated to latest commit beee9f3 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pacho-rh, raks-tt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop Tekton controller reconciliation conflicts, finalizer cleanup, duplicate database key errors , leader election locking conflicts, finalizers not found, resource requetes in progress, label update failures, admission controller nil annotations and TLS EOF noise