Skip to content

[RAPPS-DB] Fix theming/wallpapers to be more consistant in the database.#309

Merged
julenuri merged 4 commits intoreactos:masterfrom
julenuri:MinorFixes-1
Jul 5, 2025
Merged

[RAPPS-DB] Fix theming/wallpapers to be more consistant in the database.#309
julenuri merged 4 commits intoreactos:masterfrom
julenuri:MinorFixes-1

Conversation

@julenuri
Copy link
Copy Markdown
Collaborator

@julenuri julenuri commented Jul 5, 2025

No description provided.

@julenuri julenuri merged commit 67bd95c into reactos:master Jul 5, 2025
1 check passed
@whindsaks
Copy link
Copy Markdown
Contributor

  • Why did you move wallpapers into the themes category?
  • Why did you give both visual styles and wallpapers the same icon?

It's really annoying to tell wallpapers and visual styles apart now!

@julenuri
Copy link
Copy Markdown
Collaborator Author

julenuri commented Jul 8, 2025

  • Why did you move wallpapers into the themes category?

Because they don't fit in other categories the way they fit into Theming. They are not tools and neither Others. Because it's a aesthetic/theming/wallpaper feature.

  • Why did you give both visual styles and wallpapers the same icon?

I don't have any other Tango functional icon in hand. If there are alternative icons that are interesting, just ping me or commit it.

It's really annoying to tell wallpapers and visual styles apart now!

Well, It's way easier to find them than in the Others category. If we want different icons, ask me, I will find some.

Happens the same with the IME and KJC fonts. They don't fit exactly in categories.

@whindsaks
Copy link
Copy Markdown
Contributor

whindsaks commented Jul 8, 2025

I don't have any other Tango functional icon in hand.

I would personally just not have an icon and get the default package icon. If you want something better, the desk.cpl icon is slightly different from the wallpaper icon. (Install the Royale Noir theme and look in the uninstall section of Rapps to see it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants