[NEP-19833]: Fetching normal and shared datasets separately#51
Open
soundarya-mv wants to merge 1 commit intodevelopfrom
Open
[NEP-19833]: Fetching normal and shared datasets separately#51soundarya-mv wants to merge 1 commit intodevelopfrom
soundarya-mv wants to merge 1 commit intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
separate_shared_datasetswhich when true makes the instance method dataset_details to return the results this way{ 'datasets' => [], 'shared_datasets' => [] }Here shared_datasets holds the datasets that are being shared across different dashboards filters.
Eg:
On the books monthdatasetThis is useful when we do a bulk delete cascade for recreation of dashboards to avoid the deletion of shared datasets which will cause all the dashboards using the dataset to break.
To set the dataset as shared dataset, we use the extra field in superset dataset settings.
ignore_duplicate_datasetswhich when true, does not throw validation error if a dataset is already present in tenant during dashboard duplication and proceeds with duplication.