Fix pandoc#1588
Conversation
|
Coverage is 94.897% — 2.4.5/fix/pandoc into 2.4.5/release. No base build found for |
| pandoc_version = get_pandoc_version() | ||
| pandoc_args = list(settings.EXPORT_PANDOC_ARGS.get(export_format, [])) # without list(), settings would be changed | ||
|
|
||
| if pandoc_version < Version('2'): |
There was a problem hiding this comment.
there is something going on with these multiple --resourse-path args, https://pandoc.org/releases.html#pandoc-2.12-2021-03-08.
So maybe increase the minimum version to explicitly to 2.12??
from GPT:
get_pandoc_args()now requires only pandoc >= 2.0, but it may pass --resource-path multiple times. That only became safe in Pandoc 2.12; before that, the last --resource-path replaced earlier ones. So with Pandoc 2.0–2.11, STATIC_ROOT can be silently dropped when context["resource_path"] is present.
There was a problem hiding this comment.
Yes indeed, it seems it was broken all the time (for pandoc < 2.12). The correct way is to combine the path with : (or ; on Windows), which is os.pathsep. See also jgm/pandoc#6152 (comment). I also fixed the test a bit to use proper pathlib.Path to also work in Windows.
3 participants
This PR fixes the display of images when exporting via Pandoc (which nobody noticed yet...).
It also fixes
test_get_pandoc_content, which failed on more recent pandoc versions (which appearantly got pickier when they cannot find images to include).