Fix PulseAudio backend not working by updating SoundCard dep#108
Fix PulseAudio backend not working by updating SoundCard dep#108renyuneyun wants to merge 1 commit intorbn42:stablefrom
Conversation
|
Considering the repo hasn't had a commit in 2 years, and there are basically no other decent audio visualizer plasmoids (that I can find), I may build and install this PR for my desktop if it works for you xd |
|
As you mentioned "The key change needed is to use git clone https://github.com/rbn42/panon.git
cd panon
# Download SoundCard and hsluv-glsl
git submodule update --initThen modify ...
#The comment part are the lines before modification.
#import collections
import collections.abc
...
# if isinstance(self.channels, collections.Iterable):
if isinstance(self.channels, collections.abc.Iterable):
...
# if isinstance(self.channels, collections.Iterable):
if isinstance(self.channels, collections.abc.Iterable):
...Finally build as said in README: # Build translations (optional)
mkdir build
cd build
cmake ../translations
make install DESTDIR=../plasmoid/contents/locale
cd ..
# To install
kpackagetool5 -t Plasma/Applet --install plasmoidDone. PulseAudio backend now works for me. Sure there should be a better way to solve the problem, but this is the fastest way. BTW, my Desktop information:
Bug is the same as #107 |
|
I can confirm that this makes the widget work again on OpenSUSE Tumbleweed |
|
what about we create a new repository base of this one and then publish it? If I do will you support me? |
|
I have tried, it work also for Ubuntu 23. What do you think about the idea I have given. |
|
I have also tried this and it works on Nobara Linux 37 (Fedora 37 Based), would love for this to get merged and a new release to be made so that the plasmoid store version becomes working again as well @rbn42 :D |
|
@qspidy You do not need to compile and install from source, if you download the latest version from the plasmoid store and then run |
I have just sent an email to Chen-ZZ which is currently beeing followed by rbn42 and asked him if he is able to contact him, we'll see how this goes, it would be nice if we could keep this project here and with the same name. update: I have also found rbn42's email and sent one to him as well. |
|
@creeloper27 good idea |
|
Any responses? @creeloper27 |
It's almost been a year and I got back 0 responses unfortunately :/ Meanwhile someone else forked the project and republished with the name |
|
So let me get this straight: the plug-in broke because Python team made a breaking change, moving collections under a different package name, to a minor version upgrade? seriously? Regardless, correcting the package issue just unveils a new bug due to outdated dependencies. Looks like this project needs dusting off before it can be usable again. |
|
@MadMartian perhaps the repository owner is dead. |
This should fix #107. Though, I'm not sure if this is the best remote version to use.
This is due to a change in Python 3.10.
The key change needed is to use
collections.abs.Iterationrather thancollections.Iteration.The way SoundCard fixes this is correct, but it may not be the best. In theory, it may cause backward-compatibility issues for older Python versions. Though the
collections.abcmodule was introduced in version 3.3, which should only cause problems on really old systems.If really needed, see this SO answer for a better practice.