[CI][Serve] Install ray-haproxy in Serve CI Docker image#62590
Merged
aslonnie merged 5 commits intoray-project:masterfrom Apr 14, 2026
Merged
[CI][Serve] Install ray-haproxy in Serve CI Docker image#62590aslonnie merged 5 commits intoray-project:masterfrom
aslonnie merged 5 commits intoray-project:masterfrom
Conversation
Signed-off-by: seiji <seiji@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the ray-haproxy package to the Docker build to support experimental pip-based HAProxy. Feedback recommends adding the --no-deps flag to the installation command to maintain environment consistency and avoid unpinned dependency conflicts. Additionally, it was noted that this introduces a redundant HAProxy installation alongside the existing manual build, which should be addressed to avoid path ambiguity.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit b3abc95. Configure here.
Signed-off-by: seiji <seiji@anyscale.com>
aslonnie
approved these changes
Apr 14, 2026
ci/docker/serve.build.Dockerfile
Outdated
| # Install ray-haproxy (vendored HAProxy binary) for experimental pip-based | ||
| # HAProxy support. Gated behind RAY_SERVE_EXPERIMENTAL_PIP_HAPROXY=1. | ||
| # --no-deps: ray-haproxy is a standalone binary wheel with no Python dependencies. | ||
| uv pip install --system --no-cache-dir --no-deps ray-haproxy |
Collaborator
There was a problem hiding this comment.
can we use a depset and pin a version?
Signed-off-by: seiji <seiji@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Install the
ray-haproxyPyPI package in the Serve CI Docker image. This is a prerequisite for the main PR #62589 which addsRAY_SERVE_EXPERIMENTAL_PIP_HAPROXYsupport.ray-haproxyis a standalone binary wheel containing a vendored HAProxy binary atsite-packages/ray_haproxy/bin/haproxy. It has no Python dependencies (--no-deps) and does not add anything to PATH — the binary is only accessible viafrom ray_haproxy import get_haproxy_binary. It will not interfere with the existing system-installed HAProxy in the Serve image.The package is installed but not used by default. It will only be activated when the experimental flag is set in a follow-up PR.
Test plan
serve.build.Dockerfilebuilds successfully