[Core] (Resource Isolation 7/n) Move common killing policy helper functions to util#61297
Merged
israbbani merged 3 commits intoray-project:masterfrom Feb 25, 2026
Merged
Conversation
Signed-off-by: davik <davik@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a good quality-of-life improvement that refactors common test helper functions for creating and killing mock workers into a shared utility file (src/ray/raylet/tests/util.h). This reduces code duplication in worker_killing_policy_group_by_owner_test.cc and makes these helpers available for future tests. The implementation of the new utility functions is mostly solid, but I have a few suggestions to improve clarity and remove redundancy.
Signed-off-by: davik <davik@anyscale.com>
israbbani
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR provides basic quality-of-life update to move the common killing policy helper functions out of the group by owner killing policy tests and into util. This way, future killing policy tests can reuse these functions without redundancy.
Related issues
Additional information