dataloader: use positional iloc indexing in __getitem__#11
Closed
SAY-5 wants to merge 1 commit into
Closed
Conversation
Fixes ratschlab#7. Series.__getitem__ on a non-default obs_names index falls back to label-based lookup, which emits FutureWarning today and raises KeyError on pandas >= 3.0. Signed-off-by: SAY-5 <saiasish.cnp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7.
CustomDataset.__getitem__reads cluster labels viaSeries[idx]whereidxis a positional integer from the DataLoader. With non-default obs indexes (string barcodes, or shuffled integers fromtrain_test_splitwhentrain_sizeis set), pandas falls back to label-based lookup, which emitsFutureWarningtoday and raisesKeyErroron pandas >= 3.0. Switched to.iloc[idx]for positional access and added a regression test that runs withoutFutureWarningand exercises the broken path.