Change a couple of hardcoded numbers to PIO_INSTRUCTION_COUNT for clarity#2832
Open
Change a couple of hardcoded numbers to PIO_INSTRUCTION_COUNT for clarity#2832
Conversation
peterharperuk
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
32 is:
so this PR clarifies "which 32" is being used here 😉 (Which IMHO also tallies nicely with the
assert(program->length <= PIO_INSTRUCTION_COUNT);on line 67)I was also tempted to change
to
to match up with the error being returned here from
add_program_at_offset_check, but I refrained from doing so in case that would be considered a backwards-incompatible change.