Multi-line f-string for vs code configuration file contents#87
Multi-line f-string for vs code configuration file contents#87paulober wants to merge 1 commit intoraspberrypi:update_vscode_json_to_sdk1_5from
Conversation
| "cmake.buildBeforeRun": true, | ||
| "cmake.configureOnOpen": true, | ||
| "cmake.configureSettings": {{ | ||
| "CMAKE_MODULE_PATH": "${{env:PICO_INSTALL_PATH}}/pico-sdk-tools" |
There was a problem hiding this comment.
Just a note, PICO_INSTALL_PATH only exists on Windows when the installer is used. Should be harmless otherwise but should be tested I think.
|
Not exactly related to what this PR is addressing, but a somewhat larger discussion: should we consider keeping all of these config files in a single source somewhere? As it stands we have three "official" locations:
Users are certainly confused about which set is the latest and greatest one, so it would make sense to have just one location. I think the pico-examples repo might be a good candidate, because that would work for people using our installer or generator, and also for people DIY'ing their toolchain. I can set up the installer to pull from the pico-examples repo. Maybe we can set up the generator to do the same, or include it in releases. |
|
I have been wondering about converting this part of the generator to use some sort of template which the generator then fills in the fields. Those templates could be anywhere. Jinja was one templating library that has been suggested. |
That sounds like an excellent question. Ping @P33M @kilograham @ghollingworth |
- Fix comments for templates
c825605 to
ff59f6b
Compare
No description provided.