test(exporter): detect_format from a real exporter write#276
Open
mbrobbel wants to merge 1 commit into
Open
Conversation
mbrobbel
added
improvement
mbrobbel
force-pushed
the
quent-open-detect-format-test
branch
2 times, most recently
from
June 30, 2026 19:52
a1624d4 to
20d81f6
Compare
mbrobbel
force-pushed
the
quent-open-detect-format-test
branch
5 times, most recently
from
July 1, 2026 09:42
267c57a to
54477d7
Compare
rapids-bot Bot
pushed a commit
that referenced
this pull request
Jul 1, 2026
) Follow-up to #264 review (johanpel): let the analyzer detect the artifact's serialization format instead of threading it through `quent-open`. `QuentViewer::import_events` and the `model!`-generated `import_events` now take just the context directory and detect the format from the on-disk streams (new `quent_exporter::FileSystemFormat::detect`). The server's `index_query_engines` detects per-context too. The generated viewer wrapper enables all exporter formats so any artifact opens, and `quent-open` drops `Format`/`detect_format` and the format component of its cache key. **Breaking:** `QuentViewer::import_events` / `Model::import_events` drop the `format` argument; `index_query_engines` drops its `format` parameter. Downstream `QuentViewer` impls (e.g. sirius) drop the `format` param and call `Model::import_events(dir)`. **Compatibility:** `quent-open` builds the wrapper against the quent/analyzer commits pinned in `model.qmi` and now emits the one-argument calls, so it can only open artifacts whose pinned commits already include this change. Artifacts pinned to earlier commits (from the pre-release window) won't build a viewer — an accepted consequence of this breaking change; versioning the sidecar/codegen against the pinned API is left as future work. Off `main`, independent of the merged quent-open work (#265) and the open stack (#266/#273/#276). Whichever of this PR and that stack lands second needs a rebase — both touch `quent-open`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Authors: - Matthijs Brobbel (https://github.com/mbrobbel) Approvers: - Johan Peltenburg (https://github.com/johanpel) URL: #277
`FileSystemFormat::detect` (added in rapidsai#277, currently untested) recognizes an artifact's format from the streams on disk. Cover it with an integration test that drives the real filesystem exporter — laying out `<root>/<entity>/<uuid>.<ext>` — rather than hand-fabricating an `events.<ext>` layout the exporter never writes. Originally proposed against `quent-open` (johanpel review, rapidsai#264); rapidsai#277 moved format detection out of `quent-open` into the exporter, so the test moves with it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mbrobbel
force-pushed
the
quent-open-detect-format-test
branch
from
July 1, 2026 15:18
54477d7 to
eaf31b5
Compare
mbrobbel
changed the title
mbrobbel
marked this pull request as ready for review
July 1, 2026 15:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration test for
quent_exporter::FileSystemFormat::detect(added in #277, previously untested): drive the real filesystem exporter — which lays out<root>/<entity>/<uuid>.<ext>— and assertdetectrecognizes the format, rather than hand-fabricating anevents.<ext>layout the exporter never writes.Originally proposed against
quent-open(follow-up to #264 review). #277 moved format detection out ofquent-openinto the exporter, so this test moved with it (crates/exporter/tests/), gated on themsgpackfeature.🤖 Generated with Claude Code