Add Helper to Create NumPy Files #1645
Open
+65
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduces `create_numpy_file` in the file_io.hpp header. - The function creates numpy files with pre-allocated space and writes the appropriate header based on the specified shape and data type. - Removes duplicated code. - Partly addresses rapidsai#1486.
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
10 tasks
cjnolet
moved this from Todo
to In Progress
in Vector Search, ML, & Data Mining Release Board
cjnolet
added
improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
create_numpy_filein the file_io.hpp header. It creates NumPy files with pre-allocated space and writes the appropriate header based on the specified shape and data type. This removes duplicated code in CAGRA ACE incagra_build.cuh. It addresses one follow-up item of #1486.CC @tfeher