Remove redundant template instantiations from table contains#23323
Remove redundant template instantiations from table contains#23323PointKernel wants to merge 1 commit into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe contains implementation removes explicit template instantiations, simplifies its includes and aliases, and updates the cudf build target to exclude the separate nested and primitive CUDA compilation units. ChangesContains implementation cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Description
Related to #21973
Follows #23282
This PR removes redundant explicit template instantiations from table contains.
contains_table.cualready instantiates the required primitive and nested implementations, so the separate instantiation TUs only add compile work and object code.In an uncached CUDA 13.0 build, this eliminates the 1,455s nested TU and the 665s primitive TU. The affected object size drops from 7.98 MB to 3.96 MB.
Runtime performance is unchanged on B200.
Checklist