A11y ratchet gate - #18513
Draft
rak-phillip wants to merge 7 commits into
Draft
Conversation
This introduces Introduce a ratchet mechanism for the accessibility suite. The suite already records violations via `cy.checkA11y(..., skipFailures=true)` but never enforces them. These scripts allow known failures to pass while we work on fixing known issues. Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
This adds a ledger of accepted a11y violations for the gate to reference. It is seeded from a real a11y-test run rather than a local render. The file lives next to the spec because `cypress/accessibility/` is gitignored. `yarn a11y:compare` reports 102 baselined and 0 new. Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
This runs the ratchet after the accessibility suite so new violations are surfaced on every PR. - Upload report now runs `if: always()`, so the artifact is captured even when a test step or the gate itself fails. Without it, a failing run loses the report needed to triage it - The new "A11y ratchet" step also runs `if: always()` and reads the `A11Y_RATCHET_ENFORCE` repo variable. Setting it to 'true' turns on hard failure for new A11y violations Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Contributor
|
🔄 Auto-Retry Failed Run The Tests workflow run Follow up on the retried run here if needed: https://github.com/rancher/dashboard/actions/runs/30306984849 |
Contributor
|
🔄 Auto-Retry Failed Run The Tests workflow run Follow up on the retried run here if needed: https://github.com/rancher/dashboard/actions/runs/30309596667 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist
Admin,Standard UserandUser Base