Added LabeledSelectWithCreate and NamespaceSelect components - #18512
Added LabeledSelectWithCreate and NamespaceSelect components#18512eva-vashkevich wants to merge 3 commits into
Conversation
|
🔄 Auto-Retry Failed Run The Tests workflow run Follow up on the retried run here if needed: https://github.com/rancher/dashboard/actions/runs/30298338728 |
|
🔄 Auto-Retry Failed Run The Tests workflow run Follow up on the retried run here if needed: https://github.com/rancher/dashboard/actions/runs/30401859829 |
|
🔄 Auto-Retry Failed Run The Tests workflow run Follow up on the retried run here if needed: https://github.com/rancher/dashboard/actions/runs/30408772034 |
04040f7 to
d7e3c5a
Compare
|
🔄 Auto-Retry Failed Run The Tests workflow run Follow up on the retried run here if needed: https://github.com/rancher/dashboard/actions/runs/30426842715 |
Summary
Fixes #18510
Needed for rancher/virtual-clusters-ui#76
Occurred changes and/or fixed issues
Added new LabeledSelectWithCreate and NamespaceSelect components to standardize a namespace control that creates a new namespace in addition to allowing selecting existing ones.
Technical notes summary
There are more components that are doing similar logic (SelectOrCreateAuthSecret, persistentVolumeClaim/index.vue, credentials.vue) but they are different enough to not migrate at this time.
The point of this PR is to isolate this logic instead of re-inventing the wheel every time we need it, as we often run into the need to create namespaces while offering user to select one.
Areas or cases that should be tested
Mostly regression testing is required. There shouldn't be any noticeable change in behavior for the users when selecting existing or creating a new namespace.
Areas which could experience regressions
Any pages that use nameNsDescription component could be affected, but we don't need to test all of them.
make sure that the behavior is the same for core pages, like workload creation, chart installation, etc
Screenshot/Video
Checklist
Admin,Standard UserandUser Base