Skip to content

Added LabeledSelectWithCreate and NamespaceSelect components - #18512

Open
eva-vashkevich wants to merge 3 commits into
rancher:masterfrom
eva-vashkevich:select_with_new
Open

Added LabeledSelectWithCreate and NamespaceSelect components#18512
eva-vashkevich wants to merge 3 commits into
rancher:masterfrom
eva-vashkevich:select_with_new

Conversation

@eva-vashkevich

@eva-vashkevich eva-vashkevich commented Jul 27, 2026

Copy link
Copy Markdown
Member

Summary

Fixes #18510

Needed for rancher/virtual-clusters-ui#76

Occurred changes and/or fixed issues

Added new LabeledSelectWithCreate and NamespaceSelect components to standardize a namespace control that creates a new namespace in addition to allowing selecting existing ones.

Technical notes summary

There are more components that are doing similar logic (SelectOrCreateAuthSecret, persistentVolumeClaim/index.vue, credentials.vue) but they are different enough to not migrate at this time.
The point of this PR is to isolate this logic instead of re-inventing the wheel every time we need it, as we often run into the need to create namespaces while offering user to select one.

Areas or cases that should be tested

Mostly regression testing is required. There shouldn't be any noticeable change in behavior for the users when selecting existing or creating a new namespace.

Areas which could experience regressions

Any pages that use nameNsDescription component could be affected, but we don't need to test all of them.
make sure that the behavior is the same for core pages, like workload creation, chart installation, etc

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@github-actions

Copy link
Copy Markdown
Contributor

🔄 Auto-Retry Failed Run

The Tests workflow run 30298338728 failed and has been automatically retried.

Follow up on the retried run here if needed: https://github.com/rancher/dashboard/actions/runs/30298338728

@github-actions

Copy link
Copy Markdown
Contributor

🔄 Auto-Retry Failed Run

The Tests workflow run 30401859829 failed and has been automatically retried.

Follow up on the retried run here if needed: https://github.com/rancher/dashboard/actions/runs/30401859829

@github-actions

Copy link
Copy Markdown
Contributor

🔄 Auto-Retry Failed Run

The Tests workflow run 30408772034 failed and has been automatically retried.

Follow up on the retried run here if needed: https://github.com/rancher/dashboard/actions/runs/30408772034

@github-actions

Copy link
Copy Markdown
Contributor

🔄 Auto-Retry Failed Run

The Tests workflow run 30426842715 failed and has been automatically retried.

Follow up on the retried run here if needed: https://github.com/rancher/dashboard/actions/runs/30426842715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a LabeledSelect component that supports namespace creation

1 participant