Fix keyboard interrupt handling in download function#2380
Open
phanimullapudi wants to merge 1 commit intoranaroussi:mainfrom
Open
Fix keyboard interrupt handling in download function#2380phanimullapudi wants to merge 1 commit intoranaroussi:mainfrom
phanimullapudi wants to merge 1 commit intoranaroussi:mainfrom
Conversation
Collaborator
|
Looks fine just move to dev branch #1084 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #1382 by implementing proper keyboard interrupt handling for yfinance's download function, especially when using threaded downloads.
Problem
When running yf.download() with multiple tickers and threads enabled, keyboard interruptions (Ctrl+C) were not being properly caught, resulting in two issues:
Solution