Open
Conversation
R5dan
suggested changes
Feb 1, 2025
Contributor
R5dan
left a comment
There was a problem hiding this comment.
Is there any way to let the user just put in there username and password and send a request to yahoo to verify?
| else: | ||
| return False | ||
| except Exception as e: | ||
| print(f"Error confirming login: {e}") |
Contributor
There was a problem hiding this comment.
Might want to change this to logging
Collaborator
|
Wait for me to review and merge #2216, might make more sense to combine with config. |
eac2588 to
e3a877b
Compare
Collaborator
|
I've merged in the start of a config here #2391. Maybe |
|
any updates on this? |
Contributor
Author
|
Will fix today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
Authclass that allows for login functionality by settings cookies.Inspired by #2220