fix: default the retrieval of the Host header if passed using -H#278
fix: default the retrieval of the Host header if passed using -H#278shashanklmurthy wants to merge 1 commit intorakyll:masterfrom
Conversation
Signed-off-by: Shashank Murthy <[email protected]>
|
@rakyll - for approval |
|
Overall, we have two possibilities to set the Host currently, Nonetheless, why two possibilities for the same purpose ? I would agree with the fact that |
|
@jclegras - The two ways of doing this does seem wonky but my assessment would be that since Whilst trying to use this to simulate a load test, I ran into an issue due to the host not being passed through the headers which I thought was a weird behaviour given that I was passing all the rest of the headers the same way and seeing them in the downstream application, I would favour keeping the two options so that a user could do it one way or another (setting both |
Defaults the host header to the one passed using the -H option
Signed-off-by: Shashank Murthy [email protected]